Skip to content

Commit f19d6e8

Browse files
committed
COMP: Do not force JsonCpp and ParameterSerializer DIR variable to empty string
This commit ensures project expected to find JsonCpp after finding SlicerExecutionModel can do successfully even when SlicerExecutionModel is built without ParameterSerializer support. See Slicer/Slicer#5080
1 parent 60e43e9 commit f19d6e8

File tree

2 files changed

+30
-6
lines changed

2 files changed

+30
-6
lines changed

GenerateCLP/GenerateCLPConfig.cmake.in

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,21 @@ set(SlicerExecutionModel_CMAKE_DIR "@SlicerExecutionModel_CMAKE_DIR@")
1212
set(TCLAP_DIR "@TCLAP_DIR@")
1313
set(ModuleDescriptionParser_DIR "@ModuleDescriptionParser_DIR@")
1414
set(ITK_DIR "@ITK_DIR_CONFIG@")
15-
set(JsonCpp_INCLUDE_DIR "@JsonCpp_INCLUDE_DIR@")
16-
set(JsonCpp_LIBRARY "@JsonCpp_LIBRARY@")
17-
set(ParameterSerializer_DIR "@ParameterSerializer_DIR@")
15+
16+
set(GenerateCLP_JsonCpp_INCLUDE_DIR "@JsonCpp_INCLUDE_DIR@")
17+
if(NOT "${GenerateCLP_JsonCpp_INCLUDE_DIR}" STREQUAL "")
18+
set(JsonCpp_INCLUDE_DIR ${GenerateCLP_JsonCpp_INCLUDE_DIR})
19+
endif()
20+
21+
set(GenerateCLP_JsonCpp_LIBRARY "@JsonCpp_LIBRARY@")
22+
if(NOT "${GenerateCLP_JsonCpp_LIBRARY}" STREQUAL "")
23+
set(JsonCpp_LIBRARY ${GenerateCLP_JsonCpp_LIBRARY})
24+
endif()
25+
26+
set(GenerateCLP_ParameterSerializer_DIR "@ParameterSerializer_DIR@")
27+
if(NOT "${GenerateCLP_ParameterSerializer_DIR}" STREQUAL "")
28+
set(ParameterSerializer_DIR ${GenerateCLP_ParameterSerializer_DIR})
29+
endif()
1830

1931
find_program(GENERATECLP_EXE
2032
NAMES GenerateCLPLauncher GenerateCLP

SlicerExecutionModelConfig.cmake.in

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,21 @@ endif()
146146
set(ModuleDescriptionParser_DIR ${SlicerExecutionModel_DIR}/ModuleDescriptionParser)
147147
set(GenerateCLP_DIR ${SlicerExecutionModel_DIR}/GenerateCLP)
148148
set(TCLAP_DIR ${SlicerExecutionModel_DIR}/tclap)
149-
set(JsonCpp_INCLUDE_DIR "@JsonCpp_INCLUDE_DIR@")
150-
set(JsonCpp_LIBRARY "@JsonCpp_LIBRARY@")
151-
set(ParameterSerializer_DIR "@ParameterSerializer_DIR@")
149+
150+
set(SlicerExecutionModel_JsonCpp_INCLUDE_DIR "@JsonCpp_INCLUDE_DIR@")
151+
if(NOT "${SlicerExecutionModel_JsonCpp_INCLUDE_DIR}" STREQUAL "")
152+
set(JsonCpp_INCLUDE_DIR ${SlicerExecutionModel_JsonCpp_INCLUDE_DIR})
153+
endif()
154+
155+
set(SlicerExecutionModel_JsonCpp_LIBRARY "@JsonCpp_LIBRARY@")
156+
if(NOT "${SlicerExecutionModel_JsonCpp_LIBRARY}" STREQUAL "")
157+
set(JsonCpp_LIBRARY ${SlicerExecutionModel_JsonCpp_LIBRARY})
158+
endif()
159+
160+
set(SlicerExecutionModel_ParameterSerializer_DIR "@ParameterSerializer_DIR@")
161+
if(NOT "${SlicerExecutionModel_ParameterSerializer_DIR}" STREQUAL "")
162+
set(ParameterSerializer_DIR ${SlicerExecutionModel_ParameterSerializer_DIR})
163+
endif()
152164

153165
#
154166
# Find ModuleDescriptionParser, GenerateCLP and TCLAP so that the associated

0 commit comments

Comments
 (0)