Merge pull request #3008 from SixLabors/js/fix-2999

Fix detection of canonical sRGB profiles

Author: JimBobSquarePants

src/ImageSharp/ColorProfiles/ColorProfileConverterExtensionsCieLabCieLab.cs

@@ -6,8 +6,24 @@
 
 namespace SixLabors.ImageSharp.ColorProfiles;
 
-internal static class ColorProfileConverterExtensionsCieLabCieLab
+/// <summary>
+/// Allows conversion between two color profiles based on the CIE Lab color space.
+/// </summary>
+public static class ColorProfileConverterExtensionsCieLabCieLab
 {
+    /// <summary>
+    /// Converts a color value from one color profile to another using the specified color profile converter.
+    /// </summary>
+    /// <remarks>
+    /// The conversion process may use ICC profiles if available; otherwise, it performs a manual
+    /// conversion through the profile connection space (PCS) with chromatic adaptation as needed. The method requires
+    /// both source and target types to be value types implementing the appropriate color profile interface.
+    /// </remarks>
+    /// <typeparam name="TFrom">The source color profile type. Must implement <see cref="IColorProfile{TFrom, CieLab}"/>.</typeparam>
+    /// <typeparam name="TTo">The target color profile type. Must implement <see cref="IColorProfile{TTo, CieLab}"/>.</typeparam>
+    /// <param name="converter">The color profile converter to use for the conversion.</param>
+    /// <param name="source">The source color value to convert.</param>
+    /// <returns>A value of type <typeparamref name="TTo"/> representing the converted color in the target color profile.</returns>
     public static TTo Convert<TFrom, TTo>(this ColorProfileConverter converter, in TFrom source)
         where TFrom : struct, IColorProfile<TFrom, CieLab>
         where TTo : struct, IColorProfile<TTo, CieLab>
@@ -34,6 +50,20 @@ public static TTo Convert<TFrom, TTo>(this ColorProfileConverter converter, in T
         return TTo.FromProfileConnectingSpace(options, in pcsTo);
     }
 
+    /// <summary>
+    /// Converts a span of color values from one color profile to another using the specified color profile converter.
+    /// </summary>
+    /// <remarks>
+    /// This method performs color conversion between two color profiles, handling necessary
+    /// transformations such as profile connection space conversion and chromatic adaptation. If ICC profiles are
+    /// available and applicable, the conversion uses them for improved accuracy. The method does not allocate memory
+    /// for the destination; the caller is responsible for providing a suitably sized span.
+    /// </remarks>
+    /// <typeparam name="TFrom">The type representing the source color profile. Must implement <see cref="IColorProfile{TFrom, CieLab}"/>.</typeparam>
+    /// <typeparam name="TTo">The type representing the destination color profile. Must implement <see cref="IColorProfile{TTo, CieLab}"/>.</typeparam>
+    /// <param name="converter">The color profile converter to use for the conversion operation.</param>
+    /// <param name="source">A read-only span containing the source color values to convert.</param>
+    /// <param name="destination">A span that receives the converted color values. Must be at least as long as the source span.</param>
     public static void Convert<TFrom, TTo>(this ColorProfileConverter converter, ReadOnlySpan<TFrom> source, Span<TTo> destination)
         where TFrom : struct, IColorProfile<TFrom, CieLab>
         where TTo : struct, IColorProfile<TTo, CieLab>

src/ImageSharp/ColorProfiles/ColorProfileConverterExtensionsCieLabCieXyz.cs

@@ -6,8 +6,24 @@
 
 namespace SixLabors.ImageSharp.ColorProfiles;
 
-internal static class ColorProfileConverterExtensionsCieLabCieXyz
+/// <summary>
+/// Allows conversion between two color profiles based on the CIE Lab and CIE XYZ color spaces.
+/// </summary>
+public static class ColorProfileConverterExtensionsCieLabCieXyz
 {
+    /// <summary>
+    /// Converts a color value from one color profile to another using the specified color profile converter.
+    /// </summary>
+    /// <remarks>
+    /// The conversion process may use ICC profiles if available; otherwise, it performs a manual
+    /// conversion through the profile connection space (PCS) with chromatic adaptation as needed. The method requires
+    /// both source and target types to be value types implementing the appropriate color profile interface.
+    /// </remarks>
+    /// <typeparam name="TFrom">The source color profile type. Must implement <see cref="IColorProfile{TFrom, CieLab}"/>.</typeparam>
+    /// <typeparam name="TTo">The target color profile type. Must implement <see cref="IColorProfile{TTo, CieXyz}"/>.</typeparam>
+    /// <param name="converter">The color profile converter to use for the conversion.</param>
+    /// <param name="source">The source color value to convert.</param>
+    /// <returns>A value of type <typeparamref name="TTo"/> representing the converted color in the target color profile.</returns>
     public static TTo Convert<TFrom, TTo>(this ColorProfileConverter converter, in TFrom source)
         where TFrom : struct, IColorProfile<TFrom, CieLab>
         where TTo : struct, IColorProfile<TTo, CieXyz>
@@ -33,6 +49,20 @@ public static TTo Convert<TFrom, TTo>(this ColorProfileConverter converter, in T
         return TTo.FromProfileConnectingSpace(options, in pcsTo);
     }
 
+    /// <summary>
+    /// Converts a span of color values from one color profile to another using the specified color profile converter.
+    /// </summary>
+    /// <remarks>
+    /// This method performs color conversion between two color profiles, handling necessary
+    /// transformations such as profile connection space conversion and chromatic adaptation. If ICC profiles are
+    /// available and applicable, the conversion uses them for improved accuracy. The method does not allocate memory
+    /// for the destination; the caller is responsible for providing a suitably sized span.
+    /// </remarks>
+    /// <typeparam name="TFrom">The type representing the source color profile. Must implement <see cref="IColorProfile{TFrom, CieLab}"/>.</typeparam>
+    /// <typeparam name="TTo">The type representing the destination color profile. Must implement <see cref="IColorProfile{TTo, CieXyz}"/>.</typeparam>
+    /// <param name="converter">The color profile converter to use for the conversion operation.</param>
+    /// <param name="source">A read-only span containing the source color values to convert.</param>
+    /// <param name="destination">A span that receives the converted color values. Must be at least as long as the source span.</param>
     public static void Convert<TFrom, TTo>(this ColorProfileConverter converter, ReadOnlySpan<TFrom> source, Span<TTo> destination)
         where TFrom : struct, IColorProfile<TFrom, CieLab>
         where TTo : struct, IColorProfile<TTo, CieXyz>

src/ImageSharp/ColorProfiles/ColorProfileConverterExtensionsCieLabRgb.cs

@@ -6,8 +6,24 @@
 
 namespace SixLabors.ImageSharp.ColorProfiles;
 
-internal static class ColorProfileConverterExtensionsCieLabRgb
+/// <summary>
+/// Allows conversion between two color profiles based on the CIE Lab and RGB color spaces.
+/// </summary>
+public static class ColorProfileConverterExtensionsCieLabRgb
 {
+    /// <summary>
+    /// Converts a color value from one color profile to another using the specified color profile converter.
+    /// </summary>
+    /// <remarks>
+    /// The conversion process may use ICC profiles if available; otherwise, it performs a manual
+    /// conversion through the profile connection space (PCS) with chromatic adaptation as needed. The method requires
+    /// both source and target types to be value types implementing the appropriate color profile interface.
+    /// </remarks>
+    /// <typeparam name="TFrom">The source color profile type. Must implement <see cref="IColorProfile{TFrom, CieLab}"/>.</typeparam>
+    /// <typeparam name="TTo">The target color profile type. Must implement <see cref="IColorProfile{TTo, Rgb}"/>.</typeparam>
+    /// <param name="converter">The color profile converter to use for the conversion.</param>
+    /// <param name="source">The source color value to convert.</param>
+    /// <returns>A value of type <typeparamref name="TTo"/> representing the converted color in the target color profile.</returns>
     public static TTo Convert<TFrom, TTo>(this ColorProfileConverter converter, in TFrom source)
         where TFrom : struct, IColorProfile<TFrom, CieLab>
         where TTo : struct, IColorProfile<TTo, Rgb>
@@ -34,6 +50,20 @@ public static TTo Convert<TFrom, TTo>(this ColorProfileConverter converter, in T
         return TTo.FromProfileConnectingSpace(options, in pcsTo);
     }
 
+    /// <summary>
+    /// Converts a span of color values from one color profile to another using the specified color profile converter.
+    /// </summary>
+    /// <remarks>
+    /// This method performs color conversion between two color profiles, handling necessary
+    /// transformations such as profile connection space conversion and chromatic adaptation. If ICC profiles are
+    /// available and applicable, the conversion uses them for improved accuracy. The method does not allocate memory
+    /// for the destination; the caller is responsible for providing a suitably sized span.
+    /// </remarks>
+    /// <typeparam name="TFrom">The type representing the source color profile. Must implement <see cref="IColorProfile{TFrom, CieLab}"/>.</typeparam>
+    /// <typeparam name="TTo">The type representing the destination color profile. Must implement <see cref="IColorProfile{TTo, Rgb}"/>.</typeparam>
+    /// <param name="converter">The color profile converter to use for the conversion operation.</param>
+    /// <param name="source">A read-only span containing the source color values to convert.</param>
+    /// <param name="destination">A span that receives the converted color values. Must be at least as long as the source span.</param>
     public static void Convert<TFrom, TTo>(this ColorProfileConverter converter, ReadOnlySpan<TFrom> source, Span<TTo> destination)
         where TFrom : struct, IColorProfile<TFrom, CieLab>
         where TTo : struct, IColorProfile<TTo, Rgb>

src/ImageSharp/ColorProfiles/ColorProfileConverterExtensionsCieXyzCieLab.cs

@@ -6,8 +6,24 @@
 
 namespace SixLabors.ImageSharp.ColorProfiles;
 
-internal static class ColorProfileConverterExtensionsCieXyzCieLab
+/// <summary>
+/// Allows conversion between two color profiles based on the CIE XYZ and CIE Lab color spaces.
+/// </summary>
+public static class ColorProfileConverterExtensionsCieXyzCieLab
 {
+    /// <summary>
+    /// Converts a color value from one color profile to another using the specified color profile converter.
+    /// </summary>
+    /// <remarks>
+    /// The conversion process may use ICC profiles if available; otherwise, it performs a manual
+    /// conversion through the profile connection space (PCS) with chromatic adaptation as needed. The method requires
+    /// both source and target types to be value types implementing the appropriate color profile interface.
+    /// </remarks>
+    /// <typeparam name="TFrom">The source color profile type. Must implement <see cref="IColorProfile{TFrom, CieXyz}"/>.</typeparam>
+    /// <typeparam name="TTo">The target color profile type. Must implement <see cref="IColorProfile{TTo, CieLab}"/>.</typeparam>
+    /// <param name="converter">The color profile converter to use for the conversion.</param>
+    /// <param name="source">The source color value to convert.</param>
+    /// <returns>A value of type <typeparamref name="TTo"/> representing the converted color in the target color profile.</returns>
     public static TTo Convert<TFrom, TTo>(this ColorProfileConverter converter, in TFrom source)
         where TFrom : struct, IColorProfile<TFrom, CieXyz>
         where TTo : struct, IColorProfile<TTo, CieLab>
@@ -33,6 +49,20 @@ public static TTo Convert<TFrom, TTo>(this ColorProfileConverter converter, in T
         return TTo.FromProfileConnectingSpace(options, in pcsTo);
     }
 
+    /// <summary>
+    /// Converts a span of color values from one color profile to another using the specified color profile converter.
+    /// </summary>
+    /// <remarks>
+    /// This method performs color conversion between two color profiles, handling necessary
+    /// transformations such as profile connection space conversion and chromatic adaptation. If ICC profiles are
+    /// available and applicable, the conversion uses them for improved accuracy. The method does not allocate memory
+    /// for the destination; the caller is responsible for providing a suitably sized span.
+    /// </remarks>
+    /// <typeparam name="TFrom">The type representing the source color profile. Must implement <see cref="IColorProfile{TFrom, CieXyz}"/>.</typeparam>
+    /// <typeparam name="TTo">The type representing the destination color profile. Must implement <see cref="IColorProfile{TTo, CieLab}"/>.</typeparam>
+    /// <param name="converter">The color profile converter to use for the conversion operation.</param>
+    /// <param name="source">A read-only span containing the source color values to convert.</param>
+    /// <param name="destination">A span that receives the converted color values. Must be at least as long as the source span.</param>
     public static void Convert<TFrom, TTo>(this ColorProfileConverter converter, ReadOnlySpan<TFrom> source, Span<TTo> destination)
         where TFrom : struct, IColorProfile<TFrom, CieXyz>
         where TTo : struct, IColorProfile<TTo, CieLab>

src/ImageSharp/ColorProfiles/ColorProfileConverterExtensionsCieXyzCieXyz.cs

@@ -6,8 +6,24 @@
 
 namespace SixLabors.ImageSharp.ColorProfiles;
 
-internal static class ColorProfileConverterExtensionsCieXyzCieXyz
+/// <summary>
+/// Allows conversion between two color profiles based on the CIE XYZ color space.
+/// </summary>
+public static class ColorProfileConverterExtensionsCieXyzCieXyz
 {
+    /// <summary>
+    /// Converts a color value from one color profile to another using the specified color profile converter.
+    /// </summary>
+    /// <remarks>
+    /// The conversion process may use ICC profiles if available; otherwise, it performs a manual
+    /// conversion through the profile connection space (PCS) with chromatic adaptation as needed. The method requires
+    /// both source and target types to be value types implementing the appropriate color profile interface.
+    /// </remarks>
+    /// <typeparam name="TFrom">The source color profile type. Must implement <see cref="IColorProfile{TFrom, CieXyz}"/>.</typeparam>
+    /// <typeparam name="TTo">The target color profile type. Must implement <see cref="IColorProfile{TTo, CieXyz}"/>.</typeparam>
+    /// <param name="converter">The color profile converter to use for the conversion.</param>
+    /// <param name="source">The source color value to convert.</param>
+    /// <returns>A value of type <typeparamref name="TTo"/> representing the converted color in the target color profile.</returns>
     public static TTo Convert<TFrom, TTo>(this ColorProfileConverter converter, in TFrom source)
         where TFrom : struct, IColorProfile<TFrom, CieXyz>
         where TTo : struct, IColorProfile<TTo, CieXyz>
@@ -30,6 +46,20 @@ public static TTo Convert<TFrom, TTo>(this ColorProfileConverter converter, in T
         return TTo.FromProfileConnectingSpace(options, in pcsFrom);
     }
 
+    /// <summary>
+    /// Converts a span of color values from one color profile to another using the specified color profile converter.
+    /// </summary>
+    /// <remarks>
+    /// This method performs color conversion between two color profiles, handling necessary
+    /// transformations such as profile connection space conversion and chromatic adaptation. If ICC profiles are
+    /// available and applicable, the conversion uses them for improved accuracy. The method does not allocate memory
+    /// for the destination; the caller is responsible for providing a suitably sized span.
+    /// </remarks>
+    /// <typeparam name="TFrom">The type representing the source color profile. Must implement <see cref="IColorProfile{TFrom, CieXyz}"/>.</typeparam>
+    /// <typeparam name="TTo">The type representing the destination color profile. Must implement <see cref="IColorProfile{TTo, CieXyz}"/>.</typeparam>
+    /// <param name="converter">The color profile converter to use for the conversion operation.</param>
+    /// <param name="source">A read-only span containing the source color values to convert.</param>
+    /// <param name="destination">A span that receives the converted color values. Must be at least as long as the source span.</param>
     public static void Convert<TFrom, TTo>(this ColorProfileConverter converter, ReadOnlySpan<TFrom> source, Span<TTo> destination)
         where TFrom : struct, IColorProfile<TFrom, CieXyz>
         where TTo : struct, IColorProfile<TTo, CieXyz>

src/ImageSharp/ColorProfiles/ColorProfileConverterExtensionsCieXyzRgb.cs

@@ -6,8 +6,24 @@
 
 namespace SixLabors.ImageSharp.ColorProfiles;
 
-internal static class ColorProfileConverterExtensionsCieXyzRgb
+/// <summary>
+/// Allows conversion between two color profiles based on the CIE XYZ and RGB color spaces.
+/// </summary>
+public static class ColorProfileConverterExtensionsCieXyzRgb
 {
+    /// <summary>
+    /// Converts a color value from one color profile to another using the specified color profile converter.
+    /// </summary>
+    /// <remarks>
+    /// The conversion process may use ICC profiles if available; otherwise, it performs a manual
+    /// conversion through the profile connection space (PCS) with chromatic adaptation as needed. The method requires
+    /// both source and target types to be value types implementing the appropriate color profile interface.
+    /// </remarks>
+    /// <typeparam name="TFrom">The source color profile type. Must implement <see cref="IColorProfile{TFrom, CieXyz}"/>.</typeparam>
+    /// <typeparam name="TTo">The target color profile type. Must implement <see cref="IColorProfile{TTo, Rgb}"/>.</typeparam>
+    /// <param name="converter">The color profile converter to use for the conversion.</param>
+    /// <param name="source">The source color value to convert.</param>
+    /// <returns>A value of type <typeparamref name="TTo"/> representing the converted color in the target color profile.</returns>
     public static TTo Convert<TFrom, TTo>(this ColorProfileConverter converter, in TFrom source)
         where TFrom : struct, IColorProfile<TFrom, CieXyz>
         where TTo : struct, IColorProfile<TTo, Rgb>
@@ -33,6 +49,20 @@ public static TTo Convert<TFrom, TTo>(this ColorProfileConverter converter, in T
         return TTo.FromProfileConnectingSpace(options, in pcsTo);
     }
 
+    /// <summary>
+    /// Converts a span of color values from one color profile to another using the specified color profile converter.
+    /// </summary>
+    /// <remarks>
+    /// This method performs color conversion between two color profiles, handling necessary
+    /// transformations such as profile connection space conversion and chromatic adaptation. If ICC profiles are
+    /// available and applicable, the conversion uses them for improved accuracy. The method does not allocate memory
+    /// for the destination; the caller is responsible for providing a suitably sized span.
+    /// </remarks>
+    /// <typeparam name="TFrom">The type representing the source color profile. Must implement <see cref="IColorProfile{TFrom, CieXyz}"/>.</typeparam>
+    /// <typeparam name="TTo">The type representing the destination color profile. Must implement <see cref="IColorProfile{TTo, Rgb}"/>.</typeparam>
+    /// <param name="converter">The color profile converter to use for the conversion operation.</param>
+    /// <param name="source">A read-only span containing the source color values to convert.</param>
+    /// <param name="destination">A span that receives the converted color values. Must be at least as long as the source span.</param>
     public static void Convert<TFrom, TTo>(this ColorProfileConverter converter, ReadOnlySpan<TFrom> source, Span<TTo> destination)
         where TFrom : struct, IColorProfile<TFrom, CieXyz>
         where TTo : struct, IColorProfile<TTo, Rgb>