Moved hasLocalChanges to Bucket with a callback, and overridden by channel.

Bumped version and updated the test.

Author: roundhill

package.json

@@ -1,6 +1,6 @@
 {
   "name": "simperium",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "A simperium client for node.js",
   "main": "./lib/simperium/index.js",
   "repository": {

src/simperium/bucket.js

@@ -31,6 +31,10 @@ Bucket.prototype.update = function( id, data, options, callback ) {
 	return this.store.update( id, data, this.isIndexing, callback );
 };
 
+Bucket.prototype.hasLocalChanges = function( callback ) {
+	callback( false );
+};
+
 Bucket.prototype.getVersion = function( id, callback ) {
 	callback( null, 0 );
 };

src/simperium/channel.js

@@ -293,6 +293,10 @@ export default function Channel( appid, access_token, bucket, store ) {
 		collectionRevisions( channel, id, callback );
 	};
 
+	bucket.hasLocalChanges = function( callback ) {
+		callback( channel.localQueue.hasChanges() );
+	};
+
 	bucket.getVersion = function( id, callback ) {
 		store.get( id ).then(
 			( ghost ) => {

src/simperium/client.js

@@ -71,10 +71,6 @@ Client.prototype.bucket = function( name ) {
 
 	if ( this.open ) channel.onConnect();
 
-	bucket.hasLocalChanges = function() {
-		return channel.localQueue.hasChanges();
-	};
-
 	return bucket;
 };
 

test/simperium/channel_test.js

@@ -312,24 +312,14 @@ describe( 'Channel', function() {
 
 		it( 'should have local changes on send', function( done ) {
 			channel.once( 'send', function() {
-				assert.equal( channel.localQueue.hasChanges(), true );
-				done();
-			} );
-
-			store.put( '123', 3, {title: 'hello world'} ).then( function() {
-				bucket.update( '123', {title: 'goodbye world!!'} );
-			} );
-		} );
-
-		it( 'should have no local changes after ack', function( done ) {
-			channel.on( 'acknowledge', function() {
-				assert.equal( channel.localQueue.hasChanges(), false );
-				done();
+				bucket.hasLocalChanges( hasChanges => {
+					assert.equal( hasChanges, true );
+					done();
+				} );
 			} );
 
 			store.put( '123', 3, {title: 'hello world'} ).then( function() {
 				bucket.update( '123', {title: 'goodbye world!!'} );
-				done();
 			} );
 		} );