Skip to content

Commit 6a66c37

Browse files
committed
Remove rubocop-thread_safety
After evaluating this plugin against real code, we have decided it is not worth including in this gem. Consumers can manually configure it as desired.
1 parent d025018 commit 6a66c37

File tree

4 files changed

+0
-49
lines changed

4 files changed

+0
-49
lines changed

Gemfile.lock

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ PATH
44
rubocop-shopify (3.0.0)
55
lint_roller
66
rubocop (~> 1.72, >= 1.72.1)
7-
rubocop-thread_safety (>= 0.7.1)
87

98
GEM
109
remote: https://rubygems.org/
@@ -42,9 +41,6 @@ GEM
4241
lint_roller (~> 1.1)
4342
rubocop (>= 1.75.0, < 2.0)
4443
rubocop-ast (>= 1.38.0, < 2.0)
45-
rubocop-thread_safety (0.7.2)
46-
lint_roller (~> 1.1)
47-
rubocop (~> 1.72, >= 1.72.1)
4844
ruby-progressbar (1.13.0)
4945
unicode-display_width (3.1.4)
5046
unicode-emoji (~> 4.0, >= 4.0.4)

rubocop-shopify.gemspec

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,5 @@ Gem::Specification.new do |s|
3030
s.required_ruby_version = ">= 3.2.0"
3131

3232
s.add_dependency("rubocop", "~> 1.72", ">= 1.72.1")
33-
s.add_dependency("rubocop-thread_safety", ">= 0.7.1")
3433
s.add_dependency("lint_roller")
3534
end

rubocop.yml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
plugins:
66
- rubocop-shopify
7-
- rubocop-thread_safety
87

98
inherit_mode:
109
merge:
@@ -1406,14 +1405,3 @@ Style/YodaCondition:
14061405
Style/ZeroLengthPredicate:
14071406
Enabled: false
14081407

1409-
ThreadSafety/ClassInstanceVariable:
1410-
Enabled: false
1411-
1412-
ThreadSafety/MutableClassInstanceVariable:
1413-
Enabled: false
1414-
1415-
ThreadSafety/NewThread:
1416-
Enabled: false
1417-
1418-
ThreadSafety/RackMiddlewareInstanceVariable:
1419-
Enabled: false

test/fixtures/full_config.yml

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -4616,38 +4616,6 @@ Lint/NoReturnInMemoization:
46164616
VersionAdded: 3.0.0
46174617
Description: Checks for the use of a `return` with a value in `begin..end` blocks
46184618
in the context of instance variable assignment such as memoization.
4619-
ThreadSafety/ClassAndModuleAttributes:
4620-
Description: Avoid mutating class and module attributes.
4621-
Enabled: true
4622-
ActiveSupportClassAttributeAllowed: false
4623-
ThreadSafety/ClassInstanceVariable:
4624-
Description: Avoid class instance variables.
4625-
Enabled: false
4626-
ThreadSafety/MutableClassInstanceVariable:
4627-
Description: Do not assign mutable objects to class instance variables.
4628-
Enabled: false
4629-
EnforcedStyle: literals
4630-
SafeAutoCorrect: false
4631-
SupportedStyles:
4632-
- literals
4633-
- strict
4634-
ThreadSafety/NewThread:
4635-
Description: Avoid starting new threads. Let a framework like Sidekiq handle the
4636-
threads.
4637-
Enabled: false
4638-
ThreadSafety/DirChdir:
4639-
Description: Avoid using `Dir.chdir` due to its process-wide effect.
4640-
Enabled: true
4641-
AllowCallWithBlock: false
4642-
ThreadSafety/RackMiddlewareInstanceVariable:
4643-
Description: Avoid instance variables in Rack middleware.
4644-
Enabled: false
4645-
Include:
4646-
- app/middleware/**/*.rb
4647-
- lib/middleware/**/*.rb
4648-
- app/middlewares/**/*.rb
4649-
- lib/middlewares/**/*.rb
4650-
AllowedIdentifiers: []
46514619
inherit_mode:
46524620
merge:
46534621
- Exclude

0 commit comments

Comments
 (0)