Bump ruby-lsp to v0.24.0 (#625)

Author: alexcrocha

Gemfile.lock

@@ -2,7 +2,7 @@ PATH
   remote: .
   specs:
     ruby-lsp-rails (0.4.5)
-      ruby-lsp (>= 0.23.18, < 0.24.0)
+      ruby-lsp (>= 0.24.0, < 0.25.0)
 
 GEM
   remote: https://rubygems.org/
@@ -79,9 +79,9 @@ GEM
       tzinfo (~> 2.0, >= 2.0.5)
       uri (>= 0.13.1)
     ast (2.4.3)
-    base64 (0.2.0)
-    benchmark (0.4.0)
-    bigdecimal (3.1.9)
+    base64 (0.3.0)
+    benchmark (0.4.1)
+    bigdecimal (3.2.2)
     builder (3.3.0)
     concurrent-ruby (1.3.5)
     connection_pool (2.5.3)
@@ -102,7 +102,7 @@ GEM
       pp (>= 0.6.0)
       rdoc (>= 4.0.0)
       reline (>= 0.4.2)
-    json (2.12.1)
+    json (2.12.2)
     language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
     logger (1.7.0)
@@ -145,7 +145,7 @@ GEM
     nokogiri (1.18.8-x86_64-linux-musl)
       racc (~> 1.4)
     parallel (1.27.0)
-    parser (3.3.7.1)
+    parser (3.3.8.0)
       ast (~> 2.4.1)
       racc
     pp (0.6.2)
@@ -158,7 +158,7 @@ GEM
     puma (6.6.0)
       nio4r (~> 2.0)
     racc (1.8.1)
-    rack (3.1.15)
+    rack (3.1.16)
     rack-session (2.1.1)
       base64 (>= 0.1.0)
       rack (>= 3.0.0)
@@ -196,63 +196,71 @@ GEM
       thor (~> 1.0, >= 1.2.2)
       zeitwerk (~> 2.6)
     rainbow (3.1.1)
-    rake (13.2.1)
-    rbi (0.2.4)
+    rake (13.3.0)
+    rbi (0.3.3)
       prism (~> 1.0)
+      rbs (>= 3.4.4)
       sorbet-runtime (>= 0.5.9204)
-    rbs (3.9.4)
+    rbs (4.0.0.dev.4)
       logger
+      prism (>= 1.3.0)
     rdoc (6.14.0)
       erb
       psych (>= 4.0.0)
     regexp_parser (2.10.0)
     reline (0.6.1)
       io-console (~> 0.5)
-    rubocop (1.73.2)
+    require-hooks (0.2.2)
+    rexml (3.4.1)
+    rubocop (1.76.0)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.38.0, < 2.0)
+      rubocop-ast (>= 1.45.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.38.1)
-      parser (>= 3.3.1.0)
-    rubocop-minitest (0.37.1)
+    rubocop-ast (1.45.0)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
+    rubocop-minitest (0.38.1)
       lint_roller (~> 1.1)
-      rubocop (>= 1.72.1, < 2.0)
+      rubocop (>= 1.75.0, < 2.0)
       rubocop-ast (>= 1.38.0, < 2.0)
     rubocop-rake (0.7.1)
       lint_roller (~> 1.1)
       rubocop (>= 1.72.1)
-    rubocop-shopify (2.16.0)
+    rubocop-shopify (2.17.1)
       rubocop (~> 1.62)
-    rubocop-sorbet (0.8.9)
-      rubocop (>= 1)
-    ruby-lsp (0.23.23)
+    rubocop-sorbet (0.10.2)
+      lint_roller
+      rubocop (>= 1.75.2)
+    ruby-lsp (0.24.0)
       language_server-protocol (~> 3.17.0)
       prism (>= 1.2, < 2.0)
       rbs (>= 3, < 5)
       sorbet-runtime (>= 0.5.10782)
     ruby-progressbar (1.13.0)
     ruby2_keywords (0.0.5)
     securerandom (0.4.1)
-    sorbet (0.5.12087)
-      sorbet-static (= 0.5.12087)
-    sorbet-runtime (0.5.12087)
-    sorbet-static (0.5.12087-aarch64-linux)
-    sorbet-static (0.5.12087-universal-darwin)
-    sorbet-static (0.5.12087-x86_64-linux)
-    sorbet-static-and-runtime (0.5.12087)
-      sorbet (= 0.5.12087)
-      sorbet-runtime (= 0.5.12087)
-    spoom (1.5.4)
+    sorbet (0.5.12157)
+      sorbet-static (= 0.5.12157)
+    sorbet-runtime (0.5.12157)
+    sorbet-static (0.5.12157-aarch64-linux)
+    sorbet-static (0.5.12157-universal-darwin)
+    sorbet-static (0.5.12157-x86_64-linux)
+    sorbet-static-and-runtime (0.5.12157)
+      sorbet (= 0.5.12157)
+      sorbet-runtime (= 0.5.12157)
+    spoom (1.7.2)
       erubi (>= 1.10.0)
       prism (>= 0.28.0)
-      rbi (>= 0.2.3)
+      rbi (>= 0.3.3)
+      rbs (>= 4.0.0.dev.4)
+      rexml (>= 3.2.6)
       sorbet-static-and-runtime (>= 0.5.10187)
       thor (>= 0.19.2)
     sqlite3 (2.6.0-aarch64-linux-gnu)
@@ -263,14 +271,15 @@ GEM
     sqlite3 (2.6.0-x86_64-linux-gnu)
     sqlite3 (2.6.0-x86_64-linux-musl)
     stringio (3.1.7)
-    tapioca (0.16.11)
+    tapioca (0.17.1)
       benchmark
       bundler (>= 2.2.25)
       netrc (>= 0.11.0)
       parallel (>= 1.21.0)
-      rbi (~> 0.2)
+      rbi (>= 0.3.1)
+      require-hooks (>= 0.2.2)
       sorbet-static-and-runtime (>= 0.5.11087)
-      spoom (>= 1.2.0)
+      spoom (>= 1.7.0)
       thor (>= 1.2.0)
       yard-sorbet
     thor (1.3.2)
@@ -284,7 +293,7 @@ GEM
     unicode-emoji (4.0.4)
     uri (1.0.3)
     useragent (0.16.11)
-    websocket-driver (0.7.7)
+    websocket-driver (0.8.0)
       base64
       websocket-extensions (>= 0.1.0)
     websocket-extensions (0.1.5)

lib/ruby_lsp/ruby_lsp_rails/completion.rb

@@ -36,7 +36,7 @@ def handle_active_record_where_completions(node:, receiver:)
         resolved_class = @client.model(receiver.name.to_s)
         return if resolved_class.nil?
 
-        arguments = @node_context.call_node.arguments&.arguments
+        arguments = @node_context.call_node&.arguments&.arguments
         indexed_call_node_args = {} #: Hash[String, Prism::Node]
 
         if arguments

lib/ruby_lsp/ruby_lsp_rails/hover.rb

@@ -29,18 +29,20 @@ def initialize(client, response_builder, node_context, global_state, dispatcher)
       #: (Prism::ConstantPathNode node) -> void
       def on_constant_path_node_enter(node)
         entries = @index.resolve(node.slice, @nesting)
-        return unless entries
+        item = entries&.first
+        return unless item
 
-        name = entries.first.name
+        name = item.name
         generate_column_content(name)
       end
 
       #: (Prism::ConstantReadNode node) -> void
       def on_constant_read_node_enter(node)
         entries = @index.resolve(node.name.to_s, @nesting)
-        return unless entries
+        item = entries&.first
+        return unless item
 
-        generate_column_content(entries.first.name)
+        generate_column_content(item.name)
       end
 
       private

lib/ruby_lsp/ruby_lsp_rails/rails_test_style.rb

@@ -53,10 +53,10 @@ def resolve_test_commands(items)
       #: (ResponseBuilders::TestCollection response_builder, GlobalState global_state, Prism::Dispatcher dispatcher, URI::Generic uri) -> void
       def initialize(response_builder, global_state, dispatcher, uri)
         @parent_stack = [response_builder] #: Array[(Requests::Support::TestItem | ResponseBuilders::TestCollection)?]
-        super(response_builder, global_state, dispatcher, uri)
+        super(response_builder, global_state, uri)
 
-        dispatcher.register(
-          self,
+        register_events(
+          dispatcher,
           :on_class_node_enter,
           :on_call_node_enter,
           :on_def_node_enter,

lib/ruby_lsp/ruby_lsp_rails/server.rb

@@ -401,7 +401,7 @@ def route_location(name)
 
       #: (String) -> Hash[Symbol | String, untyped]?
       def resolve_database_info_from_model(model_name)
-        const = ActiveSupport::Inflector.safe_constantize(model_name)
+        const = ActiveSupport::Inflector.safe_constantize(model_name) # rubocop:disable Sorbet/ConstantsFromStrings
         return unless active_record_model?(const)
 
         info = {
@@ -420,7 +420,7 @@ def resolve_database_info_from_model(model_name)
 
       #: (Hash[Symbol | String, untyped]) -> Hash[Symbol | String, untyped]?
       def resolve_association_target(params)
-        const = ActiveSupport::Inflector.safe_constantize(params[:model_name])
+        const = ActiveSupport::Inflector.safe_constantize(params[:model_name]) # rubocop:disable Sorbet/ConstantsFromStrings
         return unless active_record_model?(const)
 
         association_klass = const.reflect_on_association(params[:association_name].intern).klass

ruby-lsp-rails.gemspec

@@ -24,5 +24,5 @@ Gem::Specification.new do |spec|
     Dir["lib/**/*", "LICENSE.txt", "Rakefile", "README.md"]
   end
 
-  spec.add_dependency("ruby-lsp", ">= 0.23.18", "< 0.24.0")
+  spec.add_dependency("ruby-lsp", ">= 0.24.0", "< 0.25.0")
 end