Convert maximum depth exceeded error to warning

Author: naqvitalha

src/recyclerview/RecyclerView.tsx

@@ -208,8 +208,18 @@ const RecyclerViewComponent = <T,>(
       return { index, dimensions: layout };
     });
 
+    const hasExceededMaxRendersWithoutCommit =
+      renderTimeTracker.hasExceededMaxRendersWithoutCommit();
+
+    if (hasExceededMaxRendersWithoutCommit) {
+      console.warn(
+        "FlashList: Exceeded max renders without commit, check for duplicate keys or parent being a ScrollView"
+      );
+    }
+
     if (
-      recyclerViewManager.modifyChildrenLayout(layoutInfo, data?.length ?? 0)
+      recyclerViewManager.modifyChildrenLayout(layoutInfo, data?.length ?? 0) &&
+      !hasExceededMaxRendersWithoutCommit
     ) {
       // Trigger re-render if layout modifications were made
       setRenderId((prev) => prev + 1);

src/recyclerview/helpers/RenderTimeTracker.ts

@@ -6,8 +6,11 @@ export class RenderTimeTracker {
   private lastTimerStartedAt = -1;
   private maxRenderTime = 32; // TODO: Improve this even more
   private defaultRenderTime = 16;
+  private rendersWithoutCommit = 0;
+  private maxRendersWithoutCommit = 40;
 
   startTracking() {
+    this.rendersWithoutCommit++;
     if (!PlatformConfig.trackAverageRenderTimeForOffsetProjection) {
       return;
     }
@@ -17,6 +20,7 @@ export class RenderTimeTracker {
   }
 
   markRenderComplete() {
+    this.rendersWithoutCommit = 0;
     if (!PlatformConfig.trackAverageRenderTimeForOffsetProjection) {
       return;
     }
@@ -26,6 +30,10 @@ export class RenderTimeTracker {
     }
   }
 
+  hasExceededMaxRendersWithoutCommit() {
+    return this.rendersWithoutCommit >= this.maxRendersWithoutCommit;
+  }
+
   getRawValue() {
     return this.renderTimeAvgWindow.currentValue;
   }