Skip to content

Commit 71c288f

Browse files
authored
Enable iOS E2E tests in CI (#1963)
- Uncomment iOS E2E test job in GitHub Actions workflow - Update Detox from 20.36.4 to 20.44.0 - Simplify Contacts test by removing SectionList comparison - Add @objc annotation to reactNativeFactory in AppDelegate - Update iOS E2E test snapshots to current baseline - Remove obsolete test artifacts and old AppDelegate file
1 parent 0cf8775 commit 71c288f

File tree

34 files changed

+82
-186
lines changed

34 files changed

+82
-186
lines changed

.github/workflows/flash-list.yml

Lines changed: 37 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -177,40 +177,40 @@ jobs:
177177
cd fixture/react-native/android
178178
./gradlew assembleDebug
179179
180-
# run-e2e-ios:
181-
# name: "Run iOS e2e tests"
182-
# runs-on: macos-latest
183-
# steps:
184-
# - name: Repository checkout
185-
# uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
186-
# - name: Node setup
187-
# uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
188-
# with:
189-
# node-version: ${{ env.NODE_VERSION }}
190-
# cache: "yarn"
191-
# - name: ruby setup
192-
# uses: ruby/setup-ruby@e34163cd15f4bb403dcd72d98e295997e6a55798 # v1.238.0
193-
# with:
194-
# ruby-version: ${{ env.RUBY_VERSION }}
195-
# bundler-cache: true
196-
# - name: Install dependencies
197-
# run: |
198-
# yarn
199-
# brew tap wix/brew
200-
# brew install applesimutils
201-
# yarn build
202-
# cd fixture/react-native
203-
# yarn
204-
# cd ios
205-
# bundle exec pod install
206-
# - name: Build and Run e2e tests
207-
# run: |
208-
# cd fixture/react-native
209-
# yarn e2e:build:ios
210-
# yarn e2e:test:ios
211-
# - name: Archive iOS e2e artifacts
212-
# if: failure()
213-
# uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
214-
# with:
215-
# name: ios-e2e-artifacts
216-
# path: fixture/react-native/e2e/artifacts/ios/diff/*.png
180+
run-e2e-ios:
181+
name: "Run iOS e2e tests"
182+
runs-on: macos-latest
183+
steps:
184+
- name: Repository checkout
185+
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
186+
- name: Node setup
187+
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
188+
with:
189+
node-version: ${{ env.NODE_VERSION }}
190+
cache: "yarn"
191+
- name: ruby setup
192+
uses: ruby/setup-ruby@e34163cd15f4bb403dcd72d98e295997e6a55798 # v1.238.0
193+
with:
194+
ruby-version: ${{ env.RUBY_VERSION }}
195+
bundler-cache: true
196+
- name: Install dependencies
197+
run: |
198+
yarn
199+
brew tap wix/brew
200+
brew install applesimutils
201+
yarn build
202+
cd fixture/react-native
203+
yarn
204+
cd ios
205+
bundle exec pod install
206+
- name: Build and Run e2e tests
207+
run: |
208+
cd fixture/react-native
209+
yarn e2e:build:ios
210+
yarn e2e:test:ios
211+
- name: Archive iOS e2e artifacts
212+
if: failure()
213+
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
214+
with:
215+
name: ios-e2e-artifacts
216+
path: fixture/react-native/e2e/artifacts/ios/diff/*.png

fixture/react-native/.detoxrc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ module.exports = {
3030
simulator: {
3131
type: "ios.simulator",
3232
device: {
33-
type: "iPhone 15",
33+
type: "iPhone 16 Pro",
3434
},
3535
},
3636
emulator: {
109 KB
Loading
207 KB
Loading
109 KB
Loading
11.7 KB
Loading
13.2 KB
Loading
13.8 KB
Loading
13.8 KB
Loading
Loading

0 commit comments

Comments
 (0)