Clean up warnings and exceptions

Author: naqvitalha

src/__tests__/ViewabilityHelper.test.ts

@@ -1,8 +1,7 @@
 import { Dimension, Layout } from "recyclerlistview";
 
-import CustomError from "../errors/CustomError";
-import ExceptionList from "../errors/ExceptionList";
 import ViewabilityHelper from "../recyclerview/viewability/ViewabilityHelper";
+import { ErrorMessages } from "../errors/ErrorMessages";
 
 describe("ViewabilityHelper", () => {
   const viewableIndicesChanged = jest.fn();
@@ -246,9 +245,7 @@ describe("ViewabilityHelper", () => {
       viewableIndicesChanged
     );
     expect(() => updateViewableItems({ viewabilityHelper })).toThrow(
-      new CustomError(
-        ExceptionList.multipleViewabilityThresholdTypesNotSupported
-      )
+      ErrorMessages.multipleViewabilityThresholdTypesNotSupported
     );
   });
 

src/benchmark/JSFPSMonitor.ts

@@ -1,3 +1,5 @@
+import { ErrorMessages } from "../errors/ErrorMessages";
+
 import { roundToDecimalPlaces } from "./roundToDecimalPlaces";
 
 /**
@@ -44,9 +46,7 @@ export class JSFPSMonitor {
 
   public startTracking() {
     if (this.startTime !== 0) {
-      throw new Error(
-        "This FPS Monitor has already been run, please create a new instance"
-      );
+      throw new Error(ErrorMessages.fpsMonitorAlreadyRunning);
     }
     this.startTime = Date.now();
     this.timeWindow.startTime = Date.now();

src/benchmark/useBenchmark.ts

@@ -1,6 +1,7 @@
 import React, { useEffect } from "react";
 
 import { FlashListRef } from "../FlashListRef";
+import { ErrorMessages } from "../errors/ErrorMessages";
 
 import { autoScroll, Cancellable } from "./AutoScrollHelper";
 import { JSFPSMonitor, JSFPSResult } from "./JSFPSMonitor";
@@ -48,7 +49,7 @@ export function useBenchmark(
     const suggestions: string[] = [];
     if (flashListRef.current) {
       if (!(Number(flashListRef.current.props.data?.length) > 0)) {
-        throw new Error("Data is empty, cannot run benchmark");
+        throw new Error(ErrorMessages.dataEmptyCannotRunBenchmark);
       }
     }
     const cancelTimeout = setTimeout(async () => {

src/benchmark/useFlatListBenchmark.ts

@@ -1,6 +1,8 @@
 import { useEffect } from "react";
 import { FlatList } from "react-native";
 
+import { ErrorMessages } from "../errors/ErrorMessages";
+
 import { autoScroll, Cancellable } from "./AutoScrollHelper";
 import { JSFPSMonitor } from "./JSFPSMonitor";
 import {
@@ -27,7 +29,7 @@ export function useFlatListBenchmark(
     const cancellable = new Cancellable();
     if (flatListRef.current && flatListRef.current.props) {
       if (!(Number(flatListRef.current.props.data?.length) > 0)) {
-        throw new Error("Data is empty, cannot run benchmark");
+        throw new Error(ErrorMessages.dataEmptyCannotRunBenchmark);
       }
     }
     const cancelTimeout = setTimeout(async () => {

src/errors/CustomError.ts

@@ -0,0 +1,26 @@
+export const ErrorMessages = {
+  multipleViewabilityThresholdTypesNotSupported:
+    "You can set exactly one of itemVisiblePercentThreshold or viewAreaCoveragePercentThreshold. Specifying both is not supported.",
+  flashListV2OnlySupportsNewArchitecture:
+    "FlashList v2 is only supported on new architecture",
+  layoutManagerNotInitializedLayoutInfo:
+    "LayoutManager is not initialized, layout info is unavailable",
+  layoutManagerNotInitializedChildContainer:
+    "LayoutManager is not initialized, child container layout is unavailable",
+  layoutManagerNotInitializedWindowSize:
+    "LayoutManager is not initialized, window size is unavailable",
+  horizontalPropCannotBeToggled:
+    "Horizontal prop cannot be toggled, you can use a key on FlashList to recreate it.",
+  layoutManagerNotInitializedVisibleIndices:
+    "LayoutManager is not initialized, visible indices are not unavailable",
+  masonryAndHorizontalIncompatible:
+    "Masonry and horizontal props are incompatible",
+  numColumnsAndHorizontalIncompatible:
+    "numColumns and horizontal props are incompatible",
+  indexOutOfBounds: "index out of bounds, not enough layouts",
+  fpsMonitorAlreadyRunning:
+    "This FPS Monitor has already been run, please create a new instance",
+  dataEmptyCannotRunBenchmark: "Data is empty, cannot run benchmark",
+  stickyHeadersNotSupportedForHorizontal:
+    "Sticky headers are not supported when list is horizontal",
+};

src/errors/ErrorMessages.ts

@@ -0,0 +1,4 @@
+export const WarningMessages = {
+  keyExtractorNotDefinedForAnimation:
+    "keyExtractor is not defined. This might cause the animations to not work as expected.",
+};

src/errors/ExceptionList.ts

@@ -1,5 +1,6 @@
 // Keep this unmodified for TS type checking
 import { isNewArch } from "./isNewArch";
+import { ErrorMessages } from "./errors/ErrorMessages";
 
 export { FlashList } from "./FlashList";
 export { FlashListRef } from "./FlashListRef";
@@ -34,5 +35,5 @@ export {
 } from "./recyclerview/LayoutCommitObserver";
 
 if (!isNewArch()) {
-  throw new Error("FlashList v2 is only supported on new architecture");
+  throw new Error(ErrorMessages.flashListV2OnlySupportsNewArchitecture);
 }

src/errors/WarningMessages.ts

@@ -20,6 +20,7 @@ import {
 } from "react-native";
 
 import { FlashListRef } from "../FlashListRef";
+import { ErrorMessages } from "../errors/ErrorMessages";
 
 import { RVDimension } from "./layout-managers/LayoutManager";
 import {
@@ -384,6 +385,9 @@ const RecyclerViewComponent = <T,>(
       stickyHeaderIndices &&
       stickyHeaderIndices.length > 0
     ) {
+      if (horizontal) {
+        throw new Error(ErrorMessages.stickyHeadersNotSupportedForHorizontal);
+      }
       return (
         <StickyHeaders
           stickyHeaderIndices={stickyHeaderIndices}
@@ -402,6 +406,7 @@ const RecyclerViewComponent = <T,>(
     stickyHeaderIndices,
     renderItem,
     scrollY,
+    horizontal,
     recyclerViewManager,
     extraData,
   ]);