Skip to content

Added check for use of gs.sleep in all script fields #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Added check for use of gs.sleep in all script fields #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
vdzK57T2bhYH4R3tr5_N6r8DKdLmhtc5_AMSqsrGL2lDDQtzZxnmirx38up8Jm2-CI3CDMpa7Udq0cV06a0WfIeCBFsws8y-joYHTxiD-lAbbpy7LKyBy-szR_kO4mFszdz7Kikp9bbMUwWTIPbtRQzbapfu6HH7iEFepuUdA9SOlwPJAAaBRxCUQeo8Hg9Hxb7ubHmvx87l7IwoGN2ezq07g2EMDh3wkpLdXVXdMoPd-Hf9g8X-V4ENLaGI-5wQnvXgX_w_shWoupz_WdTA3ir94Eh3Nu2jiM29wNQDNrlsTvslryId4vq8M8ME13Vi7UpuHw6Ec-ooT6OXdBMkvgsVAtCARdy79UbAgT_p9E3KL3rbJPozp-7I8wOf3n1WETwJkDsAUMzBp3LWF8_BqfxFeYFCEQV3l3xC8ic2ZQn_98i9fpgURFU9Ec2BEGbbMfpm7KehrFl0bNOVDTDEWIETdt80lvfR1i0-8Yk1vHWvLdB94dHoPw1a77oWht1HxEMkNzE1m38ANVQVZq2-pbVdIiAYCLeRBdd5i_LrNLpF7iCHBpAawuxX5BQIVKBW3WNTPhWUdV9_a1_394CDBmYswn8XiQSx0Vi0hfjuuMp9J9sQxOVVq2MFyWZiDvhIX2CJutq8xn27shQc7Y5xeZN5SVosFrv3irWYkzJuKoU
nhuHHs1aLCFq8_gazv38F27cJpjm5lhUjoMSHChokLB0jrGEjxXGNA1QVgIlG5E8wC4T1b49yi6F0XVm4u-H7cmfHK2zEbQx7CvOJuK9DoLRspSYHhLoI_DZN0vhui8lh-ihFSs1OJDV5d0UrksP4ZcVn2FKB7b3jsnNQ7f8zxADXi8Rs0r3moUfpHLVwxygWIRtOOfJ2Qlx1tdEfn4Ny1esDxnG02mPZ5RyiRtmRAlHYJhI1dE3OXBKNXN70e5njtLzB5pzTbe7idQ-SUshCNBkQS5ejYcDHtmAI1HEguWXfAqIY7YIw4ZiNwGfs3BrJJnie34bf336AO_EsUVu0iBlgzh7YMj6je-yxAxitsLvVh8W9MA71L2Uenuls95ATR80N9Uhy534pyr5uj5cN9GoZeoz8VcAqIqhxe-7sStkkWtAYKIJxeUT_0_XYdQXd0ovP0qS_U9j5y1I_29yq9u1-v8sQje62kbAzVtMEl6abEJ1A6bDtZmYmvMLGhpq4AI5qUWxndz8-DwvPuDzqbpzqKSMNR5IWBgnk05J9YYieOtMJcFXT3MrMNB_fhu0n8IcoyKBW9tPM7MjS4m56QbfHwEgq6m-3vEHX_6waYOHoCMl1bEaD-oTBe2kS8KdJCeupk9wVUW53KArlVn8qfJbBAkJPjlZtXwICt7SQMU
48 changes: 48 additions & 0 deletions ...9abc10ce0f62c3b24bcbaa/update/scan_column_type_check_57d17e91c3dd56108dbc32f1b4013125.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_column_type_check">
<scan_column_type_check action="INSERT_OR_UPDATE">
<active>true</active>
<category>performance</category>
<column_type>script</column_type>
<description>Avoid using gs.sleep() in any script because it does not release session and will cause delays, and add logs to the script whenever gs.sleep() has to be used.</description>
<documentation_url>https://support.servicenow.com/kb?id=kb_article_view&amp;sysparm_article=KB0747610</documentation_url>
<finding_type>scan_finding</finding_type>
<name>Avoid Use of gs.sleep() in Server-side scripts</name>
<priority>2</priority>
<resolution_details>Use gs.eventQueueScheduled() or wait timers in workflow/flow as an altrenative approach based on the use case</resolution_details>
<run_condition/>
<score_max>100</score_max>
<score_min>0</score_min>
<score_scale>1</score_scale>
<script><![CDATA[(function (engine) {

if (engine.columnValue.indexOf("gs.sleep()") > -1)
engine.finding.increment();

})(engine);]]></script>
<short_description>Avoid Use of gs.sleep() in Server-side scripts</short_description>
<sys_class_name>scan_column_type_check</sys_class_name>
<sys_created_by>nia.mccash</sys_created_by>
<sys_created_on>2024-10-16 14:13:00</sys_created_on>
<sys_id>57d17e91c3dd56108dbc32f1b4013125</sys_id>
<sys_mod_count>3</sys_mod_count>
<sys_name>Avoid Use of gs.sleep() in Server-side scripts</sys_name>
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
<sys_policy/>
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
<sys_update_name>scan_column_type_check_57d17e91c3dd56108dbc32f1b4013125</sys_update_name>
<sys_updated_by>nia.mccash</sys_updated_by>
<sys_updated_on>2024-10-16 15:00:47</sys_updated_on>
</scan_column_type_check>
<sys_translated_text action="delete_multiple" query="documentkey=57d17e91c3dd56108dbc32f1b4013125"/>
<sys_es_latest_script action="INSERT_OR_UPDATE">
<id>57d17e91c3dd56108dbc32f1b4013125</id>
<sys_created_by>nia.mccash</sys_created_by>
<sys_created_on>2024-10-16 14:13:00</sys_created_on>
<sys_id>3d4376d1c3dd56108dbc32f1b4013112</sys_id>
<sys_mod_count>0</sys_mod_count>
<sys_updated_by>nia.mccash</sys_updated_by>
<sys_updated_on>2024-10-16 14:13:00</sys_updated_on>
<table>scan_column_type_check</table>
<use_es_latest>true</use_es_latest>
</sys_es_latest_script>
</record_update>
Loading