Add new instance check definition for gs.sleep #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d with the usage of setWorkflow(false) method in business rule
…() in server-side scripts and especially in inbound email actions
Add new instance scan check definition to avoid use of gs.sleep in server-side scripts
Contributor
|
Thanks for your contribution. I am merging this for now but you might want to consider developing an improved check. I noticed that your check only checks the Inbound Email Actions [sysevent_in_email_action] table and it would be nice to have a check that checks all server side scripts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use of gs.sleep will cause performance issues if used in any server-side scripts. If it is used in inbound email action, it can have critical impact on schedule workers