From fbdf901d711f5b3b121be9a76c7ddb79392c4279 Mon Sep 17 00:00:00 2001
From: admin <admin@example.com>
Date: Mon, 7 Oct 2024 11:36:26 -0700
Subject: [PATCH 1/3] Check for tickets without assignment group

---
 ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt |  2 +-
 ...check_7334dda283455210ae0854b6feaad378.xml | 45 +++++++++++++++++++
 2 files changed, 46 insertions(+), 1 deletion(-)
 create mode 100644 ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_7334dda283455210ae0854b6feaad378.xml

diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
index e02742d..5388fb7 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
@@ -1 +1 @@
-CuRfUCF5TEEar0o-4-1zN_c4AEm04tYOYyitzaQ_ex8I7N1JnJYMxjgZkKwGNaxquET4kyKZwNGgOGLwBZBGQqV0ad_q9I2iqmSUNivzapvftarN9j3ub-8HHtzDLdZBhLnOsB8_AjaPv-Eh_ggd7Hq1LXsfJR-l2YKbNaYWGEXz3eOtbbMEtaN3alsPdg5xSkjvK9JKAkrc5bGTECXU4roa_kZ-uGIFs-qEsoX2JLGSCx_aN3WFyHzUxK0G_TeT80_oLemMf-ZR5tSP0MOFefZs3yckoTXG35VZfAHf4Y7GLJ2ue-KUTTVyHcmBeXwWVAvAHqfZufjne18FtwGdyXbVMV2NmSYcIfMhjkRVvI-DFT1zbEVdkhZAfueYlHevUDcAbwJlY0d0jAe9XbcK_z8b0jdGgruv6aO-NQiekLsMi2uQtb2XsEs7ZNRpSJ_uMGL4SaEIJRjF-Tvcaw-Lls2ejcFD8cZGsUMlfOSHGkNL7N4gjjSZSayzWZSYAnFYGV85NzxJSHt9TDSD0k1TsUiFplvaPqh8sjPvhCk4CbsEadTIm73aWOwmakBfWH6uENaUgBxAwOFayH2fN4r0PkrjsP1Yj6kHxkWBZhIZT8nhMDGM1eTWhP6duu2uY3ANpE2Hl3tv_6LEqDQbZjFNa5o3mL2r7GHxwheQBmq-Cv4
\ No newline at end of file
+UyeJAZLOPzkqTZioReDZ3QqkmprUdOX4RrzwUqB3iBIUZXID2pxZdDd8-zzVgJ8zrY3LhCdiW5tdvLasslCHZd532Pq7cRCZZuHLjQ-iJ8wlTMmybRT2u-1I429W1lv-sjEOZqeo3oo_RPq12pyxgtGJLOW5I9cPTZrOnLp6VxT4LSRCeliudBQ_8CwylpHtVIGiRDXrerTEk9jAitMPfkJu6qpO-UxLWs0UGIdOZQBmqpOWMww9NtzjI3azrpbzkSBYvqyKR-SJaiDrk77xyN7jfAMg7IZcWd4umGYlrfmLjI_SNPLuLZYpPXAMpjOMd_cAjzh1_R3279D26M9aA0JdhPUNTIJYgn_qht0i8GR249Wx72B57wY8Oi7IhDJYg4guUFeAzK16zCfqGS0ATMaRXHejSgTXZUGe6hm0emFqvHRiYOsS9EmHoJSXCi59YopRy3yIbsaw3-IN2yVOKQiLr41KqxL-M_rD6oYVN3rvS1DQ9IPEzuR6ezCIhY02LP8DvqPF9I33GgUjsGyDk8HYttR-2bQaItpfJz3StKRG6r7oMpaZ_Rp-aUlD4o-TgzUlYGCvSSwqk7IqCFP44WCjVj7Z9AieehbONdFJsMxgTCuWvgmobMRHp5O98ZdyNhoYN_28qSCuRYMOzmwE1ZBVObCNKBS6VyF5P8qCxqw
\ No newline at end of file
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_7334dda283455210ae0854b6feaad378.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_7334dda283455210ae0854b6feaad378.xml
new file mode 100644
index 0000000..3b8ef60
--- /dev/null
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_7334dda283455210ae0854b6feaad378.xml
@@ -0,0 +1,45 @@
+<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
+    <scan_table_check action="INSERT_OR_UPDATE">
+        <active>true</active>
+        <advanced>true</advanced>
+        <category>manageability</category>
+        <conditions table="incident">active=true^EQ<item endquery="false" field="active" goto="false" newquery="false" operator="=" or="false" value="true"/>
+            <item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
+        </conditions>
+        <description>Tickets from tables such as Incident, Change Request, Problem, and other task-related tables should always have an Assignment Group specified. These tickets represent issues or requests that require attention and action. Leaving the Assignment Group field empty can result in unresolved issues or delays in implementing fixes, as no team will be accountable for the resolution. Since the Assignment Group is meant to designate the responsible team for managing these tickets, it should never be left blank.</description>
+        <documentation_url/>
+        <finding_type>scan_finding</finding_type>
+        <name>Check for Orphaned tickets</name>
+        <priority>2</priority>
+        <resolution_details>Identify the records with emopty assignment group and assign them to respective assignment groups so that they can work on the tickets and to further prevent it try creating assignment lookup rules</resolution_details>
+        <run_condition/>
+        <score_max>100</score_max>
+        <score_min>0</score_min>
+        <score_scale>1</score_scale>
+        <script><![CDATA[(function(finding, current) {
+    var IncID = current.getValue('sys_id');
+    var inc = new GlideRecord('incident');
+    inc.addQuery('sys_id', IncID);
+    inc.addEncodedQuery("assignment_group!=null");
+    if (!inc.hasNext()) {
+        finding.increment();
+    }
+})(finding, current);]]></script>
+        <short_description>Tickets from Incident table should have assignment group specified.</short_description>
+        <sys_class_name>scan_table_check</sys_class_name>
+        <sys_created_by>admin</sys_created_by>
+        <sys_created_on>2024-10-07 18:22:05</sys_created_on>
+        <sys_id>7334dda283455210ae0854b6feaad378</sys_id>
+        <sys_mod_count>9</sys_mod_count>
+        <sys_name>Check for Orphaned tickets</sys_name>
+        <sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
+        <sys_policy/>
+        <sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
+        <sys_update_name>scan_table_check_7334dda283455210ae0854b6feaad378</sys_update_name>
+        <sys_updated_by>admin</sys_updated_by>
+        <sys_updated_on>2024-10-07 18:33:38</sys_updated_on>
+        <table>incident</table>
+        <use_manifest>false</use_manifest>
+    </scan_table_check>
+    <sys_translated_text action="delete_multiple" query="documentkey=7334dda283455210ae0854b6feaad378"/>
+</record_update>

From 4f91aaf6be4799b292954993cc8182b434eeb6be Mon Sep 17 00:00:00 2001
From: Sai Charan Koratala <sai.koratala@gmail.com>
Date: Tue, 8 Oct 2024 00:14:18 +0530
Subject: [PATCH 2/3] Update README.md

---
 README.md | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/README.md b/README.md
index 8a064da..395a282 100644
--- a/README.md
+++ b/README.md
@@ -146,6 +146,9 @@ During the time it can be a situation that person is no longer active in the sys
 ### Unsupported API GlideLDAP
 GlideLDAP API usage is unsupported by ServiceNow and hence should be avoided, rather use LDAP Server Data Sources to pull data from LDAP via MID Server or directly through an internet facing LDAP.
 
+### Check for Orphaned Tickets
+Tickets from tables such as Incident, Change Request, Problem, and other task-related tables should always have an Assignment Group specified. These tickets represent issues or requests that require attention and action. Leaving the Assignment Group field empty can result in unresolved issues or delays in implementing fixes, as no team will be accountable for the resolution. Since the Assignment Group is meant to designate the responsible team for managing these tickets, it should never be left blank.
+
 
 ## Category: Upgradability
 

From dc0442a11cfe7ffcf90b498c1b49bbb12c713997 Mon Sep 17 00:00:00 2001
From: admin <admin@example.com>
Date: Tue, 8 Oct 2024 23:40:51 -0700
Subject: [PATCH 3/3] Instead of using GlideRecord unnecessarily, made use of
 the table filters. This has improved the efficiency and optimized the run
 time as well.

---
 ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt |  2 +-
 ...check_7334dda283455210ae0854b6feaad378.xml | 24 +++++++++++--------
 2 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
index 5388fb7..4944b02 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/checksum.txt
@@ -1 +1 @@
-UyeJAZLOPzkqTZioReDZ3QqkmprUdOX4RrzwUqB3iBIUZXID2pxZdDd8-zzVgJ8zrY3LhCdiW5tdvLasslCHZd532Pq7cRCZZuHLjQ-iJ8wlTMmybRT2u-1I429W1lv-sjEOZqeo3oo_RPq12pyxgtGJLOW5I9cPTZrOnLp6VxT4LSRCeliudBQ_8CwylpHtVIGiRDXrerTEk9jAitMPfkJu6qpO-UxLWs0UGIdOZQBmqpOWMww9NtzjI3azrpbzkSBYvqyKR-SJaiDrk77xyN7jfAMg7IZcWd4umGYlrfmLjI_SNPLuLZYpPXAMpjOMd_cAjzh1_R3279D26M9aA0JdhPUNTIJYgn_qht0i8GR249Wx72B57wY8Oi7IhDJYg4guUFeAzK16zCfqGS0ATMaRXHejSgTXZUGe6hm0emFqvHRiYOsS9EmHoJSXCi59YopRy3yIbsaw3-IN2yVOKQiLr41KqxL-M_rD6oYVN3rvS1DQ9IPEzuR6ezCIhY02LP8DvqPF9I33GgUjsGyDk8HYttR-2bQaItpfJz3StKRG6r7oMpaZ_Rp-aUlD4o-TgzUlYGCvSSwqk7IqCFP44WCjVj7Z9AieehbONdFJsMxgTCuWvgmobMRHp5O98ZdyNhoYN_28qSCuRYMOzmwE1ZBVObCNKBS6VyF5P8qCxqw
\ No newline at end of file
+UBvFrDYpp6F473PapuKpJKvmmOUFgHEiVD5h695pnIT46m0IVAx59x1ktpNoZWBTXgM7AdJP1coxhN00Shmw9bNXm_HzYL92UD4dYmuICsujNrQr31qwCPeozLHR3BkzlPvWytL5BfPWcqGU-XSsarhtGPDjxgC2FP4hthcVI3uLDUY6HVQ8NAuLvOL3sEcCUuAMpVy6ZZjVZMVULf47a0Q8uS3aVM-Nn2UB4i5ifDA10sVReTr6N9HxC3A54aCwdMBDEY8krcVl7O_2q2QNS2UPoXc2Os0PxlJCzfBZYgvdq2Wa07TUEPv9hM_Gd-MYKC_9tJpmGuiIwkdUKo1Sdg0zrfTBq5bK03aonAUQ3YohDTcbHXyDJ0vXycn1eb4wgzzgZwlY5yILELwfm3t4_A1KYANrO3IC_ImJNe3nj8GGhuKVhdAVxfbrfjmcredgTeCIY5AyzzhR815b2zX0PPxvYYJOIVTajm6GWIH8yvUwV5q1lSrMYHw4nDIRsDUjH30qpg7EIV4ivBtO-lrCmwbXCsv6wpXJWqbtReK82OCZEWN3ovn1RYThAD55WAJkMt40_D0X7t1afak0eKUDTDK_V8lSQSeZ9d_D6cMtr2QlgZgHxX7jdmkn8KK0f9TCa07z4J5s4TJUFUxkriPZDimd3NcG3gpIJzV3AJOgqeE
\ No newline at end of file
diff --git a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_7334dda283455210ae0854b6feaad378.xml b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_7334dda283455210ae0854b6feaad378.xml
index 3b8ef60..1cb46f2 100644
--- a/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_7334dda283455210ae0854b6feaad378.xml
+++ b/ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_7334dda283455210ae0854b6feaad378.xml
@@ -3,7 +3,8 @@
         <active>true</active>
         <advanced>true</advanced>
         <category>manageability</category>
-        <conditions table="incident">active=true^EQ<item endquery="false" field="active" goto="false" newquery="false" operator="=" or="false" value="true"/>
+        <conditions table="incident">active=true^assignment_group=^EQ<item endquery="false" field="active" goto="false" newquery="false" operator="=" or="false" value="true"/>
+            <item endquery="false" field="assignment_group" goto="false" newquery="false" operator="=" or="false" value=""/>
             <item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
         </conditions>
         <description>Tickets from tables such as Incident, Change Request, Problem, and other task-related tables should always have an Assignment Group specified. These tickets represent issues or requests that require attention and action. Leaving the Assignment Group field empty can result in unresolved issues or delays in implementing fixes, as no team will be accountable for the resolution. Since the Assignment Group is meant to designate the responsible team for managing these tickets, it should never be left blank.</description>
@@ -17,27 +18,30 @@
         <score_min>0</score_min>
         <score_scale>1</score_scale>
         <script><![CDATA[(function(finding, current) {
-    var IncID = current.getValue('sys_id');
-    var inc = new GlideRecord('incident');
-    inc.addQuery('sys_id', IncID);
-    inc.addEncodedQuery("assignment_group!=null");
-    if (!inc.hasNext()) {
-        finding.increment();
-    }
+    //var IncID = current.getValue('sys_id');
+    // var inc = new GlideRecord('incident');
+    // inc.addQuery('sys_id', IncID);
+    // inc.addEncodedQuery("assignment_group!=null");
+    // if (!inc.hasNext()) {
+    //     finding.increment();
+    // }
+	//if(current.assignment_group!=null){
+         finding.increment();
+     //}
 })(finding, current);]]></script>
         <short_description>Tickets from Incident table should have assignment group specified.</short_description>
         <sys_class_name>scan_table_check</sys_class_name>
         <sys_created_by>admin</sys_created_by>
         <sys_created_on>2024-10-07 18:22:05</sys_created_on>
         <sys_id>7334dda283455210ae0854b6feaad378</sys_id>
-        <sys_mod_count>9</sys_mod_count>
+        <sys_mod_count>12</sys_mod_count>
         <sys_name>Check for Orphaned tickets</sys_name>
         <sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
         <sys_policy/>
         <sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
         <sys_update_name>scan_table_check_7334dda283455210ae0854b6feaad378</sys_update_name>
         <sys_updated_by>admin</sys_updated_by>
-        <sys_updated_on>2024-10-07 18:33:38</sys_updated_on>
+        <sys_updated_on>2024-10-09 06:30:13</sys_updated_on>
         <table>incident</table>
         <use_manifest>false</use_manifest>
     </scan_table_check>