Skip to content

Commit a70f769

Browse files
author
admin
committed
Created new instance scan to check to make sure that Client script doesn't contain GlideRecord API.
1 parent f6dba2c commit a70f769

File tree

2 files changed

+40
-1
lines changed

2 files changed

+40
-1
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
ZCv9qMuUECPrTGsjutWyjVM6cefm_yWSCqBvdU5jOa9uSn7hiI95_m0V8_jlfMEU2FiFlapN-Ss6Q_K-REFvJw12mEIr5QB3H8K0mrWENPYVncsHXtvXlfBikpUcSt21sf_7WU5JFeDIzLXNmeLSiQFFVVcvbTX50yMmURQ9pr9IZJUeKj9a-gbJqYsQxZg0BggN9TxjY3gZzjmLc6mH7aPl_QarAd_mhvzNTODSrAKl3C3SPzdJiPggT_KyR4ZzjwbOpUnQj05jprKUXFkJ9JqbaIHyPHZW7IUuy0vHZa4Qu1_Yv1DS16MfyqYSZZJSXHTOQv1dL6BtpZnhVAm5DJ5QLNrkcALIX9lG6Ij3nL_W8CF9utf39dUlmrQcD43S03VUaB9931k44KoSylO60i3UIxSs_-hqaI1nrtKOogaTtN47-Gw66GqS_OmduFl5gZsNAkjZcf2Cp8IdBgia4wUzThFjDVIBvyDsdmCJs6egUXHw9OMf1YCdp4WS-819ePV4gAJzFs0yoM6uYMhLocgkVBVQI0VeNxIWcm-9ztoLxZ4n2V6vqg9f-Q7UKVLSdbPOBbwXhzU7J50BsMwE8mZ5GhzJ1wnbavlZs_oyyhyZZOJHO1mSLNLpHzvC58AE87ur5OZCoc3tUlkl38lZSChiTMa_Ds9RajkJT5A0uyE
1+
wfk5cLJIFILf--CScx11T_HxKnvFi_tvVGWQ4MVoUD4xRjeg23hbQQ-YthZaO5rdQRi5RO0Ek_vy1jQxfj8my5NnSqX76ss9Totvk18Z5SgfR8FHjV9QH256pks9HGGF8Fbyn3AtYoCn4KUpxUI-hW2X1yAAwp0PKYgo9q_DlLzvRd1yem1bLqaCLTW-CW_IDtQoDlk5wdVR2XKYqeAsNOKgOI_7m84DsgiIZwn78t5DcQ-jEtyZKCIFsznrSce2sFSW0EZOwYVQsFwvXIhSpsyNaLesyP7N8PVuw3rBsw5nojwgPkNbJW_sYegEICD8CTNIm-OdS5tsS0nifJQNN5erG3FlGykruc1JjG1YWoQs2Nxq4FCevGLSjX-C9g9AZUtnMmyGt2wZTPTdPYwzKmoYQ1642r7CJdJ8fvjHWViLp2__NT9Wo4rJBHqYxd7rADLu-on_5a1FTXlTKLuck-Ges27pJcmyYz1RqJJHwJQ2bPeZZ6AgYIdqvLKhx87K_kDj76p9QIw36GDaNuUCAhOuB3JU5UCBdWtS_G-6GebWyasL0pMVt5DXczRH2BUeJTttW7stKIfY3p4_7pDVvd2gcE8LI6TRLGA-k-KX6c-6MeIAp8LFoOMwGH07Dc-fgPQDfhrvOnyF1jMAq2scd1kDC005jUwjKCNiM-JqiyE
Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
2+
<scan_table_check action="INSERT_OR_UPDATE">
3+
<active>true</active>
4+
<advanced>false</advanced>
5+
<category>performance</category>
6+
<conditions table="sys_script_client">scriptLIKEGlideRecord^EQ<item endquery="false" field="script" goto="false" newquery="false" operator="LIKE" or="false" value="GlideRecord"/>
7+
<item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
8+
</conditions>
9+
<description>Client script should be using GlideAjax if you need to make asyc calls to Server to get data from Server. GlideRecord() API shouldn't be used to avoid performance issues.</description>
10+
<documentation_url/>
11+
<finding_type>scan_finding</finding_type>
12+
<name>GlideRecord API in client script</name>
13+
<priority>2</priority>
14+
<resolution_details>Client scripts run on browser and they uses either data available on the form or data retrieved from the database.&#13;
15+
Use client data as much as possible to eliminate the need for time-consuming server lookups i.e. GlideRecord.&#13;
16+
The best ways to get data into form/browser from the database are g_scratchpad, and asynchronous GlideAjax lookup</resolution_details>
17+
<run_condition/>
18+
<score_max>100</score_max>
19+
<score_min>0</score_min>
20+
<score_scale>1</score_scale>
21+
<script><![CDATA[(function (engine) {
22+
23+
// Add your code here
24+
25+
})(engine);]]></script>
26+
<short_description>Client script with GlideRecord API calls</short_description>
27+
<sys_class_name>scan_table_check</sys_class_name>
28+
<sys_created_by>admin</sys_created_by>
29+
<sys_created_on>2022-09-30 21:33:04</sys_created_on>
30+
<sys_id>ba0c998d875251106b0f20af8bbb3515</sys_id>
31+
<sys_name>GlideRecord API in client script</sys_name>
32+
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
33+
<sys_policy/>
34+
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
35+
<sys_update_name>scan_table_check_ba0c998d875251106b0f20af8bbb3515</sys_update_name>
36+
<table>sys_script_client</table>
37+
<use_manifest>false</use_manifest>
38+
</scan_table_check>
39+
</record_update>

0 commit comments

Comments
 (0)