Skip to content

Commit 8ae282e

Browse files
SapphicFireSapphicFire
authored
Merge branch 'master' into bgrk-instancescan
2 parents cf74876 + 8c57a83 commit 8ae282e

File tree

3 files changed

+126
-44
lines changed

3 files changed

+126
-44
lines changed

‎README.md‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,6 @@ Connection test for the remote instance defined did not result in a positive res
6161
### Duplicate Script Include Name
6262
This uses a table check to find other Script Includes having the same API name. Technically this is possible, but causes issues as there is no way to control which Script Include will be instantiated when being called.
6363

64-
### Don't use new Array()
65-
In general, you should use the array literal notation when possible. It is easier to read, it gives the compiler a chance to optimize your code, and it's mostly faster too.
66-
6764
### Don't use new Object()
6865
In general, you should use the object literal notation when possible. It is easier to read, it gives the compiler a chance to optimize your code, and it's mostly faster too.
6966

‎ca8467c41b9abc10ce0f62c3b24bcbaa/author_elective_update/scan_table_check_eb21adf797697110710650081153af9c.xml‎

Lines changed: 126 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,126 @@
1+
<?xml version="1.0" encoding="UTF-8"?><record_update table="scan_table_check">
2+
<scan_table_check action="DELETE">
3+
<active>true</active>
4+
<advanced>false</advanced>
5+
<category>security</category>
6+
<conditions table="sys_security_acl">scriptISNOTEMPTY^advanced=false^EQ<item endquery="false" field="script" goto="false" newquery="false" operator="ISNOTEMPTY" or="false" value=""/>
7+
<item endquery="false" field="advanced" goto="false" newquery="false" operator="=" or="false" value="false"/>
8+
<item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/>
9+
</conditions>
10+
<description>Script in ACL executes even if Advanced is unchecked. This may lead to confusion and unexpected behavior, coming from the script being hidden on the form but executed.</description>
11+
<documentation_url>https://docs.servicenow.com/bundle/utah-platform-security/page/administer/contextual-security/task/t_CreateAnACLRule.html</documentation_url>
12+
<finding_type>scan_finding</finding_type>
13+
<name>Script in ACL when Advanced is unchecked</name>
14+
<priority>1</priority>
15+
<resolution_details>Either check Advanced or Remove the script from the ACL, while making sure to maintain the same ACL result.</resolution_details>
16+
<run_condition/>
17+
<score_max>100</score_max>
18+
<score_min>0</score_min>
19+
<score_scale>1</score_scale>
20+
<script><![CDATA[(function (engine) {
21+
22+
// Add your code here
23+
24+
})(engine);]]></script>
25+
<short_description>Script in ACL executes even if Advanced is unchecked.</short_description>
26+
<sys_class_name>scan_table_check</sys_class_name>
27+
<sys_created_by>admin</sys_created_by>
28+
<sys_created_on>2023-10-04 20:36:19</sys_created_on>
29+
<sys_id>eb21adf797697110710650081153af9c</sys_id>
30+
<sys_mod_count>0</sys_mod_count>
31+
<sys_name>Script in ACL when Advanced is unchecked</sys_name>
32+
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
33+
<sys_policy/>
34+
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
35+
<sys_update_name>scan_table_check_eb21adf797697110710650081153af9c</sys_update_name>
36+
<sys_updated_by>admin</sys_updated_by>
37+
<sys_updated_on>2023-10-04 20:36:19</sys_updated_on>
38+
<table>sys_security_acl</table>
39+
<use_manifest>false</use_manifest>
40+
</scan_table_check>
41+
<sys_update_version action="INSERT_OR_UPDATE">
42+
<action>DELETE</action>
43+
<application display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</application>
44+
<file_path/>
45+
<instance_id>7c7abcb4db5631d82f082a5913961914</instance_id>
46+
<instance_name>dev200172</instance_name>
47+
<name>scan_table_check_eb21adf797697110710650081153af9c</name>
48+
<payload>&lt;?xml version="1.0" encoding="UTF-8"?&gt;&lt;record_update table="scan_table_check"&gt;
49+
&lt;scan_table_check action="INSERT_OR_UPDATE"&gt;
50+
&lt;active&gt;true&lt;/active&gt;
51+
&lt;advanced&gt;false&lt;/advanced&gt;
52+
&lt;category&gt;security&lt;/category&gt;
53+
&lt;conditions table="sys_security_acl"&gt;scriptISNOTEMPTY^advanced=false^EQ&lt;item endquery="false" field="script" goto="false" newquery="false" operator="ISNOTEMPTY" or="false" value=""/&gt;
54+
&lt;item endquery="false" field="advanced" goto="false" newquery="false" operator="=" or="false" value="false"/&gt;
55+
&lt;item endquery="true" field="" goto="false" newquery="false" operator="=" or="false" value=""/&gt;
56+
&lt;/conditions&gt;
57+
&lt;description&gt;Script in ACL executes even if Advanced is unchecked. This may lead to confusion and unexpected behavior, coming from the script being hidden on the form but executed.&lt;/description&gt;
58+
&lt;documentation_url&gt;https://docs.servicenow.com/bundle/utah-platform-security/page/administer/contextual-security/task/t_CreateAnACLRule.html&lt;/documentation_url&gt;
59+
&lt;finding_type&gt;scan_finding&lt;/finding_type&gt;
60+
&lt;name&gt;Script in ACL when Advanced is unchecked&lt;/name&gt;
61+
&lt;priority&gt;1&lt;/priority&gt;
62+
&lt;resolution_details&gt;Either check Advanced or Remove the script from the ACL, while making sure to maintain the same ACL result.&lt;/resolution_details&gt;
63+
&lt;run_condition/&gt;
64+
&lt;score_max&gt;100&lt;/score_max&gt;
65+
&lt;score_min&gt;0&lt;/score_min&gt;
66+
&lt;score_scale&gt;1&lt;/score_scale&gt;
67+
&lt;script&gt;&lt;![CDATA[(function (engine) {
68+
69+
// Add your code here
70+
71+
})(engine);]]&gt;&lt;/script&gt;
72+
&lt;short_description&gt;Script in ACL executes even if Advanced is unchecked.&lt;/short_description&gt;
73+
&lt;sys_class_name&gt;scan_table_check&lt;/sys_class_name&gt;
74+
&lt;sys_created_by&gt;admin&lt;/sys_created_by&gt;
75+
&lt;sys_created_on&gt;2023-10-04 20:36:19&lt;/sys_created_on&gt;
76+
&lt;sys_id&gt;eb21adf797697110710650081153af9c&lt;/sys_id&gt;
77+
&lt;sys_mod_count&gt;0&lt;/sys_mod_count&gt;
78+
&lt;sys_name&gt;Script in ACL when Advanced is unchecked&lt;/sys_name&gt;
79+
&lt;sys_package display_value="Example Instance Checks" source="x_appe_exa_checks"&gt;ca8467c41b9abc10ce0f62c3b24bcbaa&lt;/sys_package&gt;
80+
&lt;sys_policy/&gt;
81+
&lt;sys_scope display_value="Example Instance Checks"&gt;ca8467c41b9abc10ce0f62c3b24bcbaa&lt;/sys_scope&gt;
82+
&lt;sys_update_name&gt;scan_table_check_eb21adf797697110710650081153af9c&lt;/sys_update_name&gt;
83+
&lt;sys_updated_by&gt;admin&lt;/sys_updated_by&gt;
84+
&lt;sys_updated_on&gt;2023-10-04 20:36:19&lt;/sys_updated_on&gt;
85+
&lt;table&gt;sys_security_acl&lt;/table&gt;
86+
&lt;use_manifest&gt;false&lt;/use_manifest&gt;
87+
&lt;/scan_table_check&gt;
88+
&lt;/record_update&gt;</payload>
89+
<payload_hash>1356454248</payload_hash>
90+
<record_name>Script in ACL when Advanced is unchecked</record_name>
91+
<reverted_from/>
92+
<source>f587d90bc3dd1250faa4bd33e4013147</source>
93+
<source_table>sys_upgrade_history</source_table>
94+
<state>previous</state>
95+
<sys_created_by>admin</sys_created_by>
96+
<sys_created_on>2024-10-21 18:01:38</sys_created_on>
97+
<sys_id>2387514bc3dd1250faa4bd33e40131fe</sys_id>
98+
<sys_mod_count>0</sys_mod_count>
99+
<sys_recorded_at>192b03de1990000001</sys_recorded_at>
100+
<sys_updated_by>admin</sys_updated_by>
101+
<sys_updated_on>2024-10-21 18:01:38</sys_updated_on>
102+
<type>Table Check</type>
103+
<update_guid>2f87514b95dd1250d8d7157d4a5955fd</update_guid>
104+
<update_guid_history>2f87514b95dd1250d8d7157d4a5955fd:0,e267d9c752dd1250e0ae7bf3aa17e665:-2023533997,eea83dedc1c5de50dcb00ddc90e599ae:1356454248</update_guid_history>
105+
</sys_update_version>
106+
<sys_metadata_delete action="INSERT_OR_UPDATE">
107+
<sys_audit_delete display_value="Script in ACL when Advanced is unchecked">1379110bc3dd1250faa4bd33e4013183</sys_audit_delete>
108+
<sys_class_name>sys_metadata_delete</sys_class_name>
109+
<sys_created_by>admin</sys_created_by>
110+
<sys_created_on>2024-10-21 18:10:05</sys_created_on>
111+
<sys_db_object display_value="" name="scan_table_check">scan_table_check</sys_db_object>
112+
<sys_id>6497f98bb9dc40a28cfd0e9f7ed83e24</sys_id>
113+
<sys_metadata>eb21adf797697110710650081153af9c</sys_metadata>
114+
<sys_mod_count>0</sys_mod_count>
115+
<sys_name>Script in ACL when Advanced is unchecked</sys_name>
116+
<sys_package display_value="Example Instance Checks" source="x_appe_exa_checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_package>
117+
<sys_parent/>
118+
<sys_policy/>
119+
<sys_scope display_value="Example Instance Checks">ca8467c41b9abc10ce0f62c3b24bcbaa</sys_scope>
120+
<sys_scope_delete display_value="">30a78b9b9290467a96959a65d2b2d304</sys_scope_delete>
121+
<sys_update_name>scan_table_check_eb21adf797697110710650081153af9c</sys_update_name>
122+
<sys_update_version display_value="scan_table_check_eb21adf797697110710650081153af9c">2387514bc3dd1250faa4bd33e40131fe</sys_update_version>
123+
<sys_updated_by>admin</sys_updated_by>
124+
<sys_updated_on>2024-10-21 18:10:05</sys_updated_on>
125+
</sys_metadata_delete>
126+
</record_update>

‎ca8467c41b9abc10ce0f62c3b24bcbaa/update/scan_table_check_eb21adf797697110710650081153af9c.xml‎

Lines changed: 0 additions & 41 deletions
This file was deleted.

0 commit comments

Comments
 (0)