Skip to content

Fix emoji xss #2601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2025
Merged

Fix emoji xss #2601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdf0782
Remove risky output text handling in emoji replacer
SapphicFire Oct 28, 2025
82e7b20
Fix typo in output preview heading
SapphicFire Oct 28, 2025
f451894
Include emoji output image in README
SapphicFire Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ts/Emoji Replacer Widget/Client Script.cs → ...ts/Emoji Replacer Widget/Client Script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
api.controller=function($scope,$sce) {
api.controller=function($scope) {
/* widget controller */
var c = this;

Expand All @@ -20,6 +20,6 @@
var regex = new RegExp(key.replace(/([.*+?^${}()|\[\]\/\\])/g,"\\$1"),'g');
text = text.replace(regex,c.emojiMap[key]);
}
c.outputText= $sce.trustAsHtml(text);
c.outputText= text;
}
};
2 changes: 1 addition & 1 deletion Modern Development/Service Portal Widgets/Emoji Replacer Widget/HTML.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ <h4>😊
placeholder="Type your message here..."></textarea>
<div class ="mt-3">
<h5>
Ouput Preview:
Output Preview:
</h5>
<div class="p-2 border rounded bg-light" ng-bind-html="c.outputText">

Expand Down
2 changes: 1 addition & 1 deletion Modern Development/Service Portal Widgets/Emoji Replacer Widget/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ This widget enhances the user experience by automatically converting emojis code
":tada:":🎉
## Output


![Emoji Output](emoji.png)
Loading