Skip to content

Conversation

@ChaseMillers
Copy link
Contributor

PR Description:

Simplified Table Hierarchy Traversal: Replaced manual parent table traversal and sys_dictionary queries with ServiceNow’s built-in [GlideRecord.getElements() to list all fields (including inherited ones) for a table.

Simplified Field Existence Check: Replaced custom logic with [GlideRecord.isValidField(fieldName)] to check if a field exists in the table or its ancestors.

Optional Table Ancestor Output: Added a check for [SNC.TableEditor.getTableAncestors] to print table ancestors if the API is available.

Removed Redundant Code: Eliminated duplicate and verbose logic for parent/field lookup, making the script more maintainable and idiomatic for ServiceNow developers.

Test:
image
image

Pull Request Checklist

Overview

  • Put an x inside of the square brackets to check each item.
  • I have read and understood the CONTRIBUTING.md guidelines
  • My pull request has a descriptive title that accurately reflects the changes and the description has been filled in above.
  • I've included only files relevant to the changes described in the PR title and description
  • I've created a new branch in my forked repository for this contribution

Code Quality

  • My code is relevant to ServiceNow developers
  • My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • I've disclosed use of ES2021 features (if applicable)
  • I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • I've used appropriate sub-categories within the top-level categories
  • Each code snippet has its own folder with a descriptive name

Documentation

  • I've included a README.md file for each code snippet
  • The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • My PR does not contain sensitive information (passwords, API keys, tokens)
  • My PR does not include changes that fall outside the described scope

@mskoddow mskoddow self-assigned this Oct 27, 2025
@mskoddow
Copy link
Contributor

Many thanks for considering my suggestions regarding code optimizations in your previous PR (#2497)!

@mskoddow mskoddow merged commit 70518c2 into ServiceNowDevProgram:main Oct 27, 2025
2 checks passed
@ChaseMillers
Copy link
Contributor Author

Many thanks for considering my suggestions regarding code optimizations in your previous PR (#2497)!

Thanks for providing it! have a couple more simplifications coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants