Skip to content

Conversation

@arigalamani
Copy link

@arigalamani arigalamani commented Oct 26, 2025

PR Description:

replace this with your description

Pull Request Checklist

Overview

  • Put an x inside of the square brackets to check each item.
  • I have read and understood the CONTRIBUTING.md guidelines
  • My pull request has a descriptive title that accurately reflects the changes and the description has been filled in above.
  • I've included only files relevant to the changes described in the PR title and description
  • I've created a new branch in my forked repository for this contribution

Code Quality

  • My code is relevant to ServiceNow developers
  • My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • I've disclosed use of ES2021 features (if applicable)
  • I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • I've used appropriate sub-categories within the top-level categories
  • Each code snippet has its own folder with a descriptive name

Documentation

  • I've included a README.md file for each code snippet
  • The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • My PR does not contain sensitive information (passwords, API keys, tokens)
  • My PR does not include changes that fall outside the described scope

Onchange validation client script
Validates the onchange client script based on the category, priority and urgency
@rohi-v rohi-v self-assigned this Oct 27, 2025
@github-actions
Copy link

👋 Unassigning @rohi-v due to inactivity (> 60 min without comments/reviews). This PR remains open for other reviewers.

// Prevent invalid data combination (client-side validation)
if (category === 'software' && impact === '1' && urgency === '1') {
alert('High impact & urgency for software incidents require manager approval before submission.');
g_form.setValue('state', ''); // Reset state to stop progression
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @arigalamani
Why is the state being set to empty value here..?

@ravichandra1998g
Copy link
Contributor

Hello @arigalamani
Did you get a chance to check?

@ravichandra1998g
Copy link
Contributor

I'm closing this PR for now.

Please reopen a new PR after making the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants