Skip to content

Conversation

@naveensnow
Copy link
Contributor

PR Description:

Pull Request Checklist

Overview

  • I have read and understood the CONTRIBUTING.md guidelines
  • My pull request has a descriptive title that accurately reflects the changes
  • I've included only files relevant to the changes described in the PR title and description
  • I've created a new branch in my forked repository for this contribution

Code Quality

  • My code is relevant to ServiceNow developers
  • My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • I've disclosed use of ES2021 features (if applicable)
  • I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • I've used appropriate sub-categories within the top-level categories
  • Each code snippet has its own folder with a descriptive name

Documentation

  • I've included a README.md file for each code snippet
  • The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • My PR does not contain sensitive information (passwords, API keys, tokens)
  • My PR does not include changes that fall outside the described scope

@rohi-v rohi-v self-assigned this Oct 4, 2025
@rohi-v rohi-v closed this Oct 4, 2025
@naveensnow naveensnow deleted the Resolve-Incident-Modal branch October 4, 2025 06:54
@naveensnow naveensnow restored the Resolve-Incident-Modal branch October 4, 2025 06:54
@naveensnow
Copy link
Contributor Author

Thanks for your submission. It appears that this pull request contains more files than intended. Please review and update the pull request to either remove the extra/unintended files.

Ensure your contributions are meaningful and adhere to the project’s standards. [If applicable: You can create a new branch on your forked repository to avoid accidental inclusions of new commits in the future.]. Closing this for now. Once you make additional changes, feel free to re-open this Pull Request or create a new one.

Thanks for your submission. It appears that this pull request contains more files than intended. Please review and update the pull request to either remove the extra/unintended files.

Ensure your contributions are meaningful and adhere to the project’s standards. [If applicable: You can create a new branch on your forked repository to avoid accidental inclusions of new commits in the future.]. Closing this for now. Once you make additional changes, feel free to re-open this Pull Request or create a new one.

hi @rohi-v Thanks for reviewing. can you please let me know which file you are referring as intended. as a functionality to work we need UI action, script include, you want that be in single file? i aslo added readme file.

@rohi-v
Copy link
Contributor

rohi-v commented Oct 4, 2025

@naveensnow yes, Reopened.

Validating.

Copy link
Contributor

@rohi-v rohi-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the readme file to explain the use case and how it works.

added more description of use case and how it works
@naveensnow
Copy link
Contributor Author

Please update the readme file to explain the use case and how it works.

@rohi-v can you please validate

Copy link
Contributor

@rohi-v rohi-v Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention as a comment in below code on where below code will be used.

I can see 2 seperate codes for UI Action, keep the necessary one and remove the file which is not requ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention as a comment in below code on where below code will be used.

I can see 2 seperate codes for UI Action, keep the necessary one and remove the file which is not required.

@rohi-v i dont see any two files which one you are referring
image

Copy link
Contributor

@rohi-v rohi-v Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's updated now. Thank you.

there were 2 codes so specifying which one to use where will help because the method name 'ResolveIncident()' is same in both the scripts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's updated now. Thank you.

there were 2 codes so specifying which one to use where will help because the method name 'ResolveIncident()' is same in both the scripts.

@rohi-v updated the function name.

Copy link
Contributor

@rohi-v rohi-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good

When I submit without filling the details, It's still resolving the incident. I would suggest making the fields mandatory in the Popup.

making the values mandatory
adding option None to make the validation
@naveensnow
Copy link
Contributor Author

Everything looks good

When I submit without filling the details, It's still resolving the incident. I would suggest making the fields mandatory in the Popup.

@rohi-v updated

@rohi-v
Copy link
Contributor

rohi-v commented Oct 4, 2025

Looks Good, Approved.

Thank you for your contribution.

@rohi-v rohi-v merged commit fb13cf2 into ServiceNowDevProgram:main Oct 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants