Skip to content

Conversation

@shivamvish160
Copy link
Contributor

PR Description:

Pull Request Checklist

Overview

  • I have read and understood the CONTRIBUTING.md guidelines
  • My pull request has a descriptive title that accurately reflects the changes
  • I've included only files relevant to the changes described in the PR title and description
  • I've created a new branch in my forked repository for this contribution

Code Quality

  • My code is relevant to ServiceNow developers
  • My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • I've disclosed use of ES2021 features (if applicable)
  • I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • I've used appropriate sub-categories within the top-level categories
  • Each code snippet has its own folder with a descriptive name

Documentation

  • I've included a README.md file for each code snippet
  • The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • My PR does not contain sensitive information (passwords, API keys, tokens)
  • My PR does not include changes that fall outside the described scope

@kmxo kmxo self-assigned this Oct 3, 2025
@kmxo
Copy link
Contributor

kmxo commented Oct 3, 2025

Hello @shivamvish160 , thank you for your contribution.

I believe you need some refactoring here. For example:
When you code
gr.addQuery('sys_id', '!=', '');
it will work fine.

But if you do
gr.addQuery(priority, 1);
I think it will not work. You need quotes in the first parameter.

Please do some tests and let me know what you think. I'll be here.
You can reopen this PR or create a new one.

@kmxo
Copy link
Contributor

kmxo commented Oct 3, 2025

Thank you for your contribution.

@kmxo kmxo closed this Oct 3, 2025
@shivamvish160
Copy link
Contributor Author

Hello @shivamvish160 , thank you for your contribution.

I believe you need some refactoring here. For example: When you code gr.addQuery('sys_id', '!=', ''); it will work fine.

But if you do gr.addQuery(priority, 1); I think it will not work. You need quotes in the first parameter.

Please do some tests and let me know what you think. I'll be here. You can reopen this PR or create a new one.

Hi @kmxo
Thanks for cheking this but
Here is the input and output i got when i ran in the PDI
So i think it works fine

input:

var helper = new GlideRecordHelper('incident');
var records = helper.getRecords({ priority: 1, active: true });

records.forEach(function(record) {
gs.info(record.number);
});

Output:

x_snc_hack4good_0: INC0000055
x_snc_hack4good_0: INC0000055
x_snc_hack4good_0: INC0000055
x_snc_hack4good_0: INC0000055
x_snc_hack4good_0: INC0000055
x_snc_hack4good_0: INC0000055
x_snc_hack4good_0: INC0000055
x_snc_hack4good_0: INC0000055
x_snc_hack4good_0: INC0000055
x_snc_hack4good_0: INC0000055
x_snc_hack4good_0: INC0000055
x_snc_hack4good_0: INC0000055
x_snc_hack4good_0: INC0000055
x_snc_hack4good_0: INC0000055
x_snc_hack4good_0: INC0000055
x_snc_hack4good_0: INC0000055
x_snc_hack4good_0: INC0000055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants