Merge branch 'main' into bug-fix/Incident-Cancellation-UI-Action

Author: Sriharsha19

.github/pull_request_template.md

@@ -1,8 +1,12 @@
+# PR Description: 
+replace this with your description
+
 # Pull Request Checklist
 
 ## Overview
+- [x] Put an x inside of the square brackets to check each item.
 - [ ] I have read and understood the [CONTRIBUTING.md](CONTRIBUTING.md) guidelines
-- [ ] My pull request has a descriptive title that accurately reflects the changes
+- [ ] My pull request has a descriptive title that accurately reflects the changes and the description has been filled in above.
 - [ ] I've included only files relevant to the changes described in the PR title and description
 - [ ] I've created a new branch in my forked repository for this contribution
 

.github/scripts/validate-structure.js

@@ -49,6 +49,34 @@ function validateFilePath(filePath) {
   const normalized = filePath.replace(/\\/g, '/');
   const segments = normalized.split('/');
 
+  // Check for invalid characters that break local file systems
+  for (let i = 0; i < segments.length; i++) {
+    const segment = segments[i];
+
+    // Check for trailing periods (invalid on Windows)
+    if (segment.endsWith('.')) {
+      return `Invalid folder/file name '${segment}' in path '${normalized}': Names cannot end with a period (.) as this breaks local file system sync on Windows.`;
+    }
+
+    // Check for trailing spaces (invalid on Windows)
+    if (segment.endsWith(' ')) {
+      return `Invalid folder/file name '${segment}' in path '${normalized}': Names cannot end with a space as this breaks local file system sync on Windows.`;
+    }
+
+    // Check for reserved Windows names
+    const reservedNames = ['CON', 'PRN', 'AUX', 'NUL', 'COM1', 'COM2', 'COM3', 'COM4', 'COM5', 'COM6', 'COM7', 'COM8', 'COM9', 'LPT1', 'LPT2', 'LPT3', 'LPT4', 'LPT5', 'LPT6', 'LPT7', 'LPT8', 'LPT9'];
+    const nameWithoutExt = segment.split('.')[0].toUpperCase();
+    if (reservedNames.includes(nameWithoutExt)) {
+      return `Invalid folder/file name '${segment}' in path '${normalized}': '${nameWithoutExt}' is a reserved name on Windows and will break local file system sync.`;
+    }
+
+    // Check for invalid characters (Windows and general file system restrictions)
+    const invalidChars = /[<>:"|?*\x00-\x1F]/;
+    if (invalidChars.test(segment)) {
+      return `Invalid folder/file name '${segment}' in path '${normalized}': Contains characters that are invalid on Windows file systems (< > : " | ? * or control characters).`;
+    }
+  }
+
   if (!allowedCategories.has(segments[0])) {
     return null;
   }

.github/workflows/pr-auto-unassign-stale.yml

@@ -0,0 +1,154 @@
+name: Auto-unassign stale PR assignees
+
+on:
+  schedule:
+    - cron: "*/15 * * * *"   # run every 15 minutes
+  workflow_dispatch:
+    inputs:
+      enabled:
+        description: "Enable this automation"
+        type: boolean
+        default: true
+      max_age_minutes:
+        description: "Unassign if assigned longer than X minutes"
+        type: number
+        default: 60
+      dry_run:
+        description: "Preview only; do not change assignees"
+        type: boolean
+        default: false
+
+permissions:
+  pull-requests: write
+  issues: write
+
+env:
+  # Defaults (can be overridden via workflow_dispatch inputs)
+  ENABLED: "true"
+  MAX_ASSIGN_AGE_MINUTES: "60"
+  DRY_RUN: "false"
+
+jobs:
+  sweep:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Resolve inputs into env
+        run: |
+          # Prefer manual run inputs when present
+          if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then
+            echo "ENABLED=${{ inputs.enabled }}" >> $GITHUB_ENV
+            echo "MAX_ASSIGN_AGE_MINUTES=${{ inputs.max_age_minutes }}" >> $GITHUB_ENV
+            echo "DRY_RUN=${{ inputs.dry_run }}" >> $GITHUB_ENV
+          fi
+          echo "Effective config: ENABLED=$ENABLED, MAX_ASSIGN_AGE_MINUTES=$MAX_ASSIGN_AGE_MINUTES, DRY_RUN=$DRY_RUN"
+
+      - name: Exit if disabled
+        if: ${{ env.ENABLED != 'true' && env.ENABLED != 'True' && env.ENABLED != 'TRUE' }}
+        run: echo "Disabled via ENABLED=$ENABLED. Exiting." && exit 0
+
+      - name: Unassign stale assignees
+        uses: actions/github-script@v7
+        with:
+          script: |
+            const owner = context.repo.owner;
+            const repo  = context.repo.repo;
+
+            const MAX_MIN = parseInt(process.env.MAX_ASSIGN_AGE_MINUTES || "60", 10);
+            const DRY_RUN = ["true","True","TRUE","1","yes"].includes(String(process.env.DRY_RUN));
+            const now = new Date();
+
+            core.info(`Scanning open PRs. Threshold = ${MAX_MIN} minutes. DRY_RUN=${DRY_RUN}`);
+
+            // List all open PRs
+            const prs = await github.paginate(github.rest.pulls.list, {
+              owner, repo, state: "open", per_page: 100
+            });
+
+            let totalUnassigned = 0;
+
+            for (const pr of prs) {
+              if (!pr.assignees || pr.assignees.length === 0) continue;
+
+              const number = pr.number;
+              core.info(`PR #${number}: "${pr.title}" — assignees: ${pr.assignees.map(a => a.login).join(", ")}`);
+
+              // Pull reviews (to see if an assignee started a review)
+              const reviews = await github.paginate(github.rest.pulls.listReviews, {
+                owner, repo, pull_number: number, per_page: 100
+              });
+
+              // Issue comments (general comments)
+              const issueComments = await github.paginate(github.rest.issues.listComments, {
+                owner, repo, issue_number: number, per_page: 100
+              });
+
+              // Review comments (file-level)
+              const reviewComments = await github.paginate(github.rest.pulls.listReviewComments, {
+                owner, repo, pull_number: number, per_page: 100
+              });
+
+              // Issue events (to find assignment timestamps)
+              const issueEvents = await github.paginate(github.rest.issues.listEvents, {
+                owner, repo, issue_number: number, per_page: 100
+              });
+
+              for (const a of pr.assignees) {
+                const assignee = a.login;
+
+                // Find the most recent "assigned" event for this assignee
+                const assignedEvents = issueEvents
+                  .filter(e => e.event === "assigned" && e.assignee && e.assignee.login === assignee)
+                  .sort((x, y) => new Date(y.created_at) - new Date(x.created_at));
+
+                if (assignedEvents.length === 0) {
+                  core.info(`  - @${assignee}: no 'assigned' event found; skipping.`);
+                  continue;
+                }
+
+                const assignedAt = new Date(assignedEvents[0].created_at);
+                const ageMin = (now - assignedAt) / 60000;
+
+                // Has the assignee commented (issue or review comments) or reviewed?
+                const hasIssueComment = issueComments.some(c => c.user?.login === assignee);
+                const hasReviewComment = reviewComments.some(c => c.user?.login === assignee);
+                const hasReview = reviews.some(r => r.user?.login === assignee);
+
+                const eligible =
+                  ageMin >= MAX_MIN &&
+                  !hasIssueComment &&
+                  !hasReviewComment &&
+                  !hasReview &&
+                  pr.state === "open";
+
+                core.info(`  - @${assignee}: assigned ${ageMin.toFixed(1)} min ago; commented=${hasIssueComment || hasReviewComment}; reviewed=${hasReview}; open=${pr.state==='open'} => ${eligible ? 'ELIGIBLE' : 'skip'}`);
+
+                if (!eligible) continue;
+
+                if (DRY_RUN) {
+                  core.notice(`Would unassign @${assignee} from PR #${number}`);
+                } else {
+                  try {
+                    await github.rest.issues.removeAssignees({
+                      owner, repo, issue_number: number, assignees: [assignee]
+                    });
+                    totalUnassigned += 1;
+                    // Optional: leave a gentle heads-up comment
+                    await github.rest.issues.createComment({
+                      owner, repo, issue_number: number,
+                      body: `👋 Unassigning @${assignee} due to inactivity (> ${MAX_MIN} min without comments/reviews). This PR remains open for other reviewers.`
+                    });
+                    core.info(`    Unassigned @${assignee} from #${number}`);
+                  } catch (err) {
+                    core.warning(`    Failed to unassign @${assignee} from #${number}: ${err.message}`);
+                  }
+                }
+              }
+            }
+
+            core.summary
+              .addHeading('Auto-unassign report')
+              .addRaw(`Threshold: ${MAX_MIN} minutes\n\n`)
+              .addRaw(`Total unassignments: ${totalUnassigned}\n`)
+              .write();
+
+          result-encoding: string

.github/workflows/validate-structure.yml

@@ -65,6 +65,8 @@ jobs:
           cat "$tmp_error" >&2
 
           if grep -q 'Folder structure violations found' "$tmp_output" "$tmp_error"; then
+            # Save validation output for use in PR comment
+            cat "$tmp_output" "$tmp_error" > "$RUNNER_TEMP/validation_output.txt"
             echo "status=failed" >> "$GITHUB_OUTPUT"
             exit 0
           fi
@@ -87,11 +89,37 @@ jobs:
             const owner = context.repo.owner;
             const repo = context.repo.repo;
 
+            const fs = require('fs');
+            const output = fs.readFileSync(process.env.RUNNER_TEMP + '/validation_output.txt', 'utf8');
+
+            let commentBody = `Thank you for your contribution. However, it doesn't comply with our contributing guidelines.\n\n`;
+
+            // Check if the error is about invalid file/folder names
+            if (output.includes('Names cannot end with a period') ||
+                output.includes('Names cannot end with a space') ||
+                output.includes('is a reserved name on Windows') ||
+                output.includes('Contains characters that are invalid')) {
+              commentBody += `**❌ Invalid File/Folder Names Detected**\n\n`;
+              commentBody += `Your contribution contains file or folder names that will break when syncing to local file systems (especially Windows):\n\n`;
+              commentBody += `\`\`\`\n${output}\n\`\`\`\n\n`;
+              commentBody += `**Common issues:**\n`;
+              commentBody += `- Folder/file names ending with a period (.) - not allowed on Windows\n`;
+              commentBody += `- Folder/file names ending with spaces - not allowed on Windows\n`;
+              commentBody += `- Reserved names like CON, PRN, AUX, NUL, COM1-9, LPT1-9 - not allowed on Windows\n`;
+              commentBody += `- Invalid characters: < > : " | ? * or control characters\n\n`;
+              commentBody += `Please rename these files/folders to be compatible with all operating systems.\n\n`;
+            } else {
+              commentBody += `As a reminder, the general requirements (as outlined in the [CONTRIBUTING.md file](https://github.com/ServiceNowDevProgram/code-snippets/blob/main/CONTRIBUTING.md)) are the following: follow the folder+subfolder guidelines and include a README.md file explaining what the code snippet does.\n\n`;
+              commentBody += `**Validation errors:**\n\`\`\`\n${output}\n\`\`\`\n\n`;
+            }
+
+            commentBody += `Review your contribution against the guidelines and make the necessary adjustments. Closing this for now. Once you make additional changes, feel free to re-open this Pull Request or create a new one.`;
+
             await github.rest.issues.createComment({
               owner,
               repo,
               issue_number: pullNumber,
-              body: `Thank you for your contribution. However, it doesn't comply with our contributing guidelines. As a reminder, the general requirements (as outlined in the [CONTRIBUTING.md file](https://github.com/ServiceNowDevProgram/code-snippets/blob/main/CONTRIBUTING.md)) are the following: follow the folder+subfolder guidelines and include a README.md file explaining what the code snippet does. Review your contribution against the guidelines and make the necessary adjustments. Closing this for now. Once you make additional changes, feel free to re-open this Pull Request or create a new one.`.trim()
+              body: commentBody.trim()
             });
 
             await github.rest.pulls.update({

CONTRIBUTING.md

@@ -31,10 +31,25 @@ If you plan to submit another pull request while your original is still pending,
 - **Descriptive Pull Request Titles**: Your pull request must have explicit and descriptive titles that accurately represent the changes made.
 - **Scope Adherence**: Changes that fall outside the described scope will result in the entire pull request being rejected.
 - **Quality Over Quantity**: Low-effort or spam pull requests will be marked accordingly.
-- **Expanded Snippets**: Code snippets reused from the [ServiceNow Documentation](https://docs.servicenow.com/) or [API References](https://developer.servicenow.com/dev.do#!/reference/) are acceptable only if they are expanded in a meaningful way (e.g., with additional context, documentation, or variations). Remember: *“QUANTITY IS FUN, QUALITY IS KEY.”*
+- **Expanded Snippets**: Code snippets reused from the [ServiceNow Documentation](https://docs.servicenow.com/) or [API References](https://developer.servicenow.com/dev.do#!/reference/) are acceptable only if they are expanded in a meaningful way (e.g., with additional context, documentation, or variations). Remember: *"QUANTITY IS FUN, QUALITY IS KEY."*
 - **Relevance**: Code should be relevant to ServiceNow Developers.
 - **ES2021 Compatibility**: While ES2021 is allowed, we encourage you to disclose if your code is using ES2021 features, as not everyone may be working with ES2021-enabled applications.
 
+## Core Documentation File Changes
+
+**IMPORTANT**: For changes to core documentation files (README.md, CONTRIBUTING.md, LICENSE, etc.), contributors must:
+
+1. **Submit an Issue First**: Before making any changes to core documentation files, create an issue describing:
+   - What you intend to edit
+   - Why the change is needed
+   - Your proposed approach
+
+2. **Get Assignment**: Wait to be assigned to the issue by a maintainer before submitting a PR.
+
+3. **Reference the Issue**: Include the issue number in your PR title and description.
+
+This process helps prevent merge conflicts when multiple contributors want to update the same documentation files and ensures all changes align with the project's direction.
+
 ## Repository Structure
 
 **IMPORTANT**: The repository has been reorganized into major categories. All new contributions MUST follow this structure for PR approval.

Client-Side Components/Catalog Client Script/Auto Save Draft Feature/README.md

@@ -0,0 +1,114 @@
+# Auto Save Draft Feature for Catalog Items
+
+This snippet provides automatic draft saving functionality for ServiceNow Catalog Items, helping prevent data loss by automatically saving form data at regular intervals.
+
+## Overview
+
+The feature includes two implementations:
+1. Basic Implementation (`basic_implementation.js`)
+2. Advanced Implementation (`advanced_implementation.js`)
+
+## Basic Implementation
+
+### Features
+- Auto-saves form data every minute
+- Stores single draft in sessionStorage
+- Provides draft restoration on form load
+- Basic error handling and user feedback
+
+### Usage
+```javascript
+// Apply in Catalog Client Script
+// Select "onLoad" for "Client script runs"
+// Copy content from basic_implementation.js
+```
+
+## Advanced Implementation
+
+### Enhanced Features
+- Multiple draft support (keeps last 3 drafts)
+- Advanced draft management
+- Draft selection dialog
+- Detailed metadata tracking
+- Improved error handling
+- User-friendly notifications
+
+### Usage
+```javascript
+// Apply in Catalog Client Script
+// Select "onLoad" for "Client script runs"
+// Copy content from advanced_implementation.js
+```
+
+## Technical Details
+
+### Dependencies
+- ServiceNow Platform UI Framework
+- GlideForm API
+- GlideModal (advanced implementation only)
+
+### Browser Support
+- Modern browsers with sessionStorage support
+- ES5+ compatible
+
+### Security Considerations
+- Uses browser's sessionStorage (cleared on session end)
+- No sensitive data transmission
+- Instance-specific storage
+
+## Implementation Guide
+
+1. Create a new Catalog Client Script:
+   - Table: Catalog Client Script [catalog_script_client]
+   - Type: onLoad
+   - Active: true
+
+2. Choose implementation:
+   - For basic needs: Copy `basic_implementation.js`
+   - For advanced features: Copy `advanced_implementation.js`
+
+3. Apply to desired Catalog Items:
+   - Select applicable Catalog Items
+   - Test in dev environment first
+
+## Best Practices
+
+1. Testing:
+   - Test with various form states
+   - Verify draft restoration
+   - Check browser storage limits
+
+2. Performance:
+   - Default 60-second interval is recommended
+   - Adjust based on form complexity
+   - Monitor browser memory usage
+
+3. User Experience:
+   - Clear feedback messages
+   - Confirmation dialogs
+   - Error notifications
+
+## Limitations
+
+- Browser session dependent
+- Storage size limits
+- Form field compatibility varies
+
+## Troubleshooting
+
+Common issues and solutions:
+1. Draft not saving
+   - Check browser console for errors
+   - Verify sessionStorage availability
+   - Check form modification detection
+
+2. Restoration fails
+   - Validate stored data format
+   - Check browser storage permissions
+   - Verify form field compatibility
+
+## Version Information
+
+- Compatible with ServiceNow: Rome and later
+- Browser Requirements: Modern browsers with ES5+ support
+- Last Updated: October 2025