Skip to content

Commit d0aa25e

Browse files
authored
Merge branch 'main' into get-key-value-from-json
2 parents 804df8f + de3ed58 commit d0aa25e

File tree

58 files changed

+1472
-1
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

58 files changed

+1472
-1
lines changed

.github/pull_request_template.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# PR Description:
2+
3+
14
# Pull Request Checklist
25

36
## Overview

.github/scripts/validate-structure.js

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,34 @@ function validateFilePath(filePath) {
4949
const normalized = filePath.replace(/\\/g, '/');
5050
const segments = normalized.split('/');
5151

52+
// Check for invalid characters that break local file systems
53+
for (let i = 0; i < segments.length; i++) {
54+
const segment = segments[i];
55+
56+
// Check for trailing periods (invalid on Windows)
57+
if (segment.endsWith('.')) {
58+
return `Invalid folder/file name '${segment}' in path '${normalized}': Names cannot end with a period (.) as this breaks local file system sync on Windows.`;
59+
}
60+
61+
// Check for trailing spaces (invalid on Windows)
62+
if (segment.endsWith(' ')) {
63+
return `Invalid folder/file name '${segment}' in path '${normalized}': Names cannot end with a space as this breaks local file system sync on Windows.`;
64+
}
65+
66+
// Check for reserved Windows names
67+
const reservedNames = ['CON', 'PRN', 'AUX', 'NUL', 'COM1', 'COM2', 'COM3', 'COM4', 'COM5', 'COM6', 'COM7', 'COM8', 'COM9', 'LPT1', 'LPT2', 'LPT3', 'LPT4', 'LPT5', 'LPT6', 'LPT7', 'LPT8', 'LPT9'];
68+
const nameWithoutExt = segment.split('.')[0].toUpperCase();
69+
if (reservedNames.includes(nameWithoutExt)) {
70+
return `Invalid folder/file name '${segment}' in path '${normalized}': '${nameWithoutExt}' is a reserved name on Windows and will break local file system sync.`;
71+
}
72+
73+
// Check for invalid characters (Windows and general file system restrictions)
74+
const invalidChars = /[<>:"|?*\x00-\x1F]/;
75+
if (invalidChars.test(segment)) {
76+
return `Invalid folder/file name '${segment}' in path '${normalized}': Contains characters that are invalid on Windows file systems (< > : " | ? * or control characters).`;
77+
}
78+
}
79+
5280
if (!allowedCategories.has(segments[0])) {
5381
return null;
5482
}

.github/workflows/validate-structure.yml

Lines changed: 29 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,8 @@ jobs:
6565
cat "$tmp_error" >&2
6666
6767
if grep -q 'Folder structure violations found' "$tmp_output" "$tmp_error"; then
68+
# Save validation output for use in PR comment
69+
cat "$tmp_output" "$tmp_error" > "$RUNNER_TEMP/validation_output.txt"
6870
echo "status=failed" >> "$GITHUB_OUTPUT"
6971
exit 0
7072
fi
@@ -87,11 +89,37 @@ jobs:
8789
const owner = context.repo.owner;
8890
const repo = context.repo.repo;
8991
92+
const fs = require('fs');
93+
const output = fs.readFileSync(process.env.RUNNER_TEMP + '/validation_output.txt', 'utf8');
94+
95+
let commentBody = `Thank you for your contribution. However, it doesn't comply with our contributing guidelines.\n\n`;
96+
97+
// Check if the error is about invalid file/folder names
98+
if (output.includes('Names cannot end with a period') ||
99+
output.includes('Names cannot end with a space') ||
100+
output.includes('is a reserved name on Windows') ||
101+
output.includes('Contains characters that are invalid')) {
102+
commentBody += `**❌ Invalid File/Folder Names Detected**\n\n`;
103+
commentBody += `Your contribution contains file or folder names that will break when syncing to local file systems (especially Windows):\n\n`;
104+
commentBody += `\`\`\`\n${output}\n\`\`\`\n\n`;
105+
commentBody += `**Common issues:**\n`;
106+
commentBody += `- Folder/file names ending with a period (.) - not allowed on Windows\n`;
107+
commentBody += `- Folder/file names ending with spaces - not allowed on Windows\n`;
108+
commentBody += `- Reserved names like CON, PRN, AUX, NUL, COM1-9, LPT1-9 - not allowed on Windows\n`;
109+
commentBody += `- Invalid characters: < > : " | ? * or control characters\n\n`;
110+
commentBody += `Please rename these files/folders to be compatible with all operating systems.\n\n`;
111+
} else {
112+
commentBody += `As a reminder, the general requirements (as outlined in the [CONTRIBUTING.md file](https://github.com/ServiceNowDevProgram/code-snippets/blob/main/CONTRIBUTING.md)) are the following: follow the folder+subfolder guidelines and include a README.md file explaining what the code snippet does.\n\n`;
113+
commentBody += `**Validation errors:**\n\`\`\`\n${output}\n\`\`\`\n\n`;
114+
}
115+
116+
commentBody += `Review your contribution against the guidelines and make the necessary adjustments. Closing this for now. Once you make additional changes, feel free to re-open this Pull Request or create a new one.`;
117+
90118
await github.rest.issues.createComment({
91119
owner,
92120
repo,
93121
issue_number: pullNumber,
94-
body: `Thank you for your contribution. However, it doesn't comply with our contributing guidelines. As a reminder, the general requirements (as outlined in the [CONTRIBUTING.md file](https://github.com/ServiceNowDevProgram/code-snippets/blob/main/CONTRIBUTING.md)) are the following: follow the folder+subfolder guidelines and include a README.md file explaining what the code snippet does. Review your contribution against the guidelines and make the necessary adjustments. Closing this for now. Once you make additional changes, feel free to re-open this Pull Request or create a new one.`.trim()
122+
body: commentBody.trim()
95123
});
96124
97125
await github.rest.pulls.update({
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
## Dynamically Switch Form View Based on Field Value
2+
3+
This client script demonstrates how to **automatically switch form views** based on the value of a field.
4+
5+
**Use case:**
6+
For example, if the **Category** field is set to *Hardware*, the form view switches to **ess**.
7+
You can extend this by updating the mapping object to support additional fields and values (e.g., *Software → itil*, *Network → support*).
8+
9+
**Benefit:**
10+
Improves user experience by guiding users to the **most relevant form view**, ensuring the right fields are shown for the right scenario.
11+
12+
**Test:**
13+
- Change the **Category** field to *Hardware* → Form view should switch to **ess**.
14+
- Update mapping to add new conditions (e.g., *Software → itil*) and verify the view switches accordingly.
15+
16+
**How to Use:**
17+
1. **Modify the table name** in the `switchView` function to match your target table:
18+
```javascript
19+
switchView("section", "<your_table_name>", targetView);
20+
2. **Modify the view mapping**
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
/**
2+
* dynamic-form-view-onchange.js
3+
*
4+
* Dynamically switches the form view automatically depending on the value of a specific field.
5+
* Example: If Category = Hardware → switch to ess view.
6+
* Extendable by modifying the mapping object for different fields/values.
7+
*
8+
*/
9+
10+
function onChange(control, oldValue, newValue, isLoading) {
11+
if (isLoading || !newValue) {
12+
return;
13+
}
14+
15+
// Field value → view name mapping
16+
var viewMapping = {
17+
"hardware": "ess",
18+
"software": "itil",
19+
"network": "support"
20+
};
21+
22+
var fieldValue = newValue.toLowerCase();
23+
var targetView = viewMapping[fieldValue];
24+
25+
if (targetView) {
26+
try {
27+
// Here for example the table name is incident
28+
switchView("section", "incident", targetView);
29+
} catch (e) {
30+
console.error("View switch failed: ", e);
31+
}
32+
}
33+
}
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# Field Completion Counter
2+
3+
## Use Case / Requirement
4+
Display a simple message showing how many fields are completed vs total fields on a form. This helps users track their progress while filling out forms.
5+
6+
## Solution
7+
A simple onLoad client script that:
8+
- Counts filled vs empty fields
9+
- Shows completion status in an info message
10+
- Updates when fields are modified
11+
12+
## Implementation
13+
Add this as an **onLoad** client script on any form.
14+
15+
## Notes
16+
- Excludes system fields and read-only fields
17+
- Updates in real-time as users fill fields
18+
- Simple and lightweight solution
Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
function onLoad() {
2+
// Display field completion counter
3+
showFieldProgress();
4+
5+
// Set up listener for field changes
6+
setupProgressUpdater();
7+
8+
function showFieldProgress() {
9+
var allFields = g_form.getFieldNames();
10+
var visibleFields = [];
11+
var filledFields = 0;
12+
13+
// Count visible, editable fields
14+
for (var i = 0; i < allFields.length; i++) {
15+
var fieldName = allFields[i];
16+
17+
// Skip system fields and hidden/readonly fields
18+
if (fieldName.indexOf('sys_') === 0 ||
19+
!g_form.isVisible(fieldName) ||
20+
g_form.isReadOnly(fieldName)) {
21+
continue;
22+
}
23+
visibleFields.push(fieldName);
24+
25+
// Check if field has value
26+
if (g_form.getValue(fieldName)) {
27+
filledFields++;
28+
}
29+
}
30+
var totalFields = visibleFields.length;
31+
var percentage = totalFields > 0 ? Math.round((filledFields / totalFields) * 100) : 0;
32+
33+
g_form.addInfoMessage('Form Progress: ' + filledFields + '/' + totalFields + ' fields completed (' + percentage + '%)');
34+
}
35+
36+
function setupProgressUpdater() {
37+
// Simple debounced update
38+
var updateTimer;
39+
40+
function updateProgress() {
41+
clearTimeout(updateTimer);
42+
updateTimer = setTimeout(function() {
43+
g_form.clearMessages();
44+
showFieldProgress();
45+
}, 500);
46+
}
47+
48+
// Listen for any field change
49+
var allFields = g_form.getFieldNames();
50+
for (var i = 0; i < allFields.length; i++) {
51+
g_form.addElementChangeListener(allFields[i], updateProgress);
52+
}
53+
}
54+
}
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# The Glide User (g_user) is a global object available within the client side. It provides information about the logged-in user.
2+
3+
Property Description
4+
5+
g_user.userID Sys ID of the currently logged-in user
6+
g_user.name User's Full name
7+
g_user.firstName User's First name
8+
g_user.lastName User's Last name
9+
10+
# It also has some methods available within the client side.
11+
12+
Method Description
13+
14+
g_user.hasRole() Determine whether the logged-in user has a specific role
15+
g_user.hasRoleExactly() Do not consider the admin role while evaluating the method
16+
g_user.hasRoles() You can pass two or more roles in a single method
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
if (g_user.hasRole('admin') || g_user.hasRole('itil')) {
2+
// User has at least one of the roles
3+
g_form.setDisplay('internal_notes', true);
4+
}
5+
6+
if (g_user.hasRole('admin') && g_user.hasRole('itil')) {
7+
// User must have both roles
8+
g_form.setDisplay('advanced_settings', true);
9+
}
10+
11+
//Using the parameters to set a field value
12+
g_form.setValue('short_description', g_user.firstName);
13+
14+
g_form.setValue('short_description', g_user.lastName);
15+
16+
g_form.setValue('short_description', g_user.name);
17+
18+
g_form.setValue('short_description', g_user.userID);
Lines changed: 79 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
1+
# Mandatory Field Highlighter
2+
3+
## Use Case
4+
Provides visual feedback for empty mandatory fields on ServiceNow forms by showing error messages when the form loads. Helps users quickly identify which required fields need to be completed.
5+
6+
## Requirements
7+
- ServiceNow instance
8+
- Client Script execution rights
9+
- Forms with mandatory fields
10+
11+
## Implementation
12+
1. Create a new Client Script with Type "onLoad"
13+
2. Copy the script code from script.js
14+
3. **Customize the fieldsToCheck string** with your form's mandatory field names
15+
4. Apply to desired table/form
16+
5. Save and test on a form with mandatory fields
17+
18+
## Configuration
19+
Edit the `fieldsToCheck` variable to include your form's mandatory fields as a comma-separated string:
20+
21+
```javascript
22+
// Example configurations for different forms:
23+
24+
// For Incident forms:
25+
var fieldsToCheck = 'short_description,priority,category,caller_id,assignment_group';
26+
27+
// For Request forms:
28+
var fieldsToCheck = 'short_description,requested_for,category,priority';
29+
30+
// For Change Request forms:
31+
var fieldsToCheck = 'short_description,category,priority,assignment_group,start_date,end_date';
32+
33+
// For Problem forms:
34+
var fieldsToCheck = 'short_description,category,priority,assignment_group';
35+
36+
// Custom fields (add as needed):
37+
var fieldsToCheck = 'short_description,priority,u_business_justification,u_cost_center';
38+
```
39+
40+
## Features
41+
- Shows error messages under empty mandatory fields on form load
42+
- Easy configuration with comma-separated field names
43+
- Automatically skips fields that don't exist on the form
44+
- Only processes fields that are actually mandatory and visible
45+
- Uses proper ServiceNow client scripting APIs
46+
- No DOM manipulation or unsupported methods
47+
48+
## Common Field Names
49+
- `short_description` - Short Description
50+
- `priority` - Priority
51+
- `category` - Category
52+
- `caller_id` - Caller
53+
- `requested_for` - Requested For
54+
- `assignment_group` - Assignment Group
55+
- `assigned_to` - Assigned To
56+
- `state` - State
57+
- `urgency` - Urgency
58+
- `impact` - Impact
59+
- `start_date` - Start Date
60+
- `end_date` - End Date
61+
- `due_date` - Due Date
62+
- `location` - Location
63+
- `company` - Company
64+
- `department` - Department
65+
66+
## Notes
67+
- Uses g_form.showFieldMsg() method to display error messages
68+
- Uses g_form.hasField() to safely check field existence (built into the safety checks)
69+
- Only runs on form load - provides initial validation feedback
70+
- Easy to customize for different forms by modifying the field list
71+
- Compatible with all standard ServiceNow forms
72+
- Lightweight and focused on essential functionality
73+
74+
## Example Usage
75+
For a typical incident form, simply change the configuration line to:
76+
```javascript
77+
var fieldsToCheck = 'short_description,priority,category,caller_id,assignment_group';
78+
```
79+
Save the Client Script and test on an incident form to see error messages appear under empty mandatory fields.

0 commit comments

Comments
 (0)