Tests: Run Clippy on TagLib tests

Author: Serial-ATA

lofty/tests/taglib/test_mpeg.rs

@@ -17,7 +17,7 @@ fn test_audio_properties_xing_header_cbr() {
 	let f = get_file::<MpegFile>("tests/taglib/data/lame_cbr.mp3");
 
 	assert_eq!(f.properties().duration().as_secs(), 1887); // TODO: Off by 9
-	assert_eq!(f.properties().duration().as_millis(), 1887164);
+	assert_eq!(f.properties().duration().as_millis(), 1_887_164);
 	assert_eq!(f.properties().audio_bitrate(), 64);
 	assert_eq!(f.properties().channels(), 1);
 	assert_eq!(f.properties().sample_rate(), 44100);
@@ -30,7 +30,7 @@ fn test_audio_properties_xing_header_vbr() {
 	let f = get_file::<MpegFile>("tests/taglib/data/lame_vbr.mp3");
 
 	assert_eq!(f.properties().duration().as_secs(), 1887); // TODO: Off by 9
-	assert_eq!(f.properties().duration().as_millis(), 1887164);
+	assert_eq!(f.properties().duration().as_millis(), 1_887_164);
 	assert_eq!(f.properties().audio_bitrate(), 70);
 	assert_eq!(f.properties().channels(), 1);
 	assert_eq!(f.properties().sample_rate(), 44100);
@@ -43,7 +43,7 @@ fn test_audio_properties_vbri_header() {
 	let f = get_file::<MpegFile>("tests/taglib/data/rare_frames.mp3");
 
 	assert_eq!(f.properties().duration().as_secs(), 222); // TODO: Off by 1
-	assert_eq!(f.properties().duration().as_millis(), 222198);
+	assert_eq!(f.properties().duration().as_millis(), 222_198);
 	assert_eq!(f.properties().audio_bitrate(), 233);
 	assert_eq!(f.properties().channels(), 2);
 	assert_eq!(f.properties().sample_rate(), 44100);
@@ -55,7 +55,7 @@ fn test_audio_properties_vbri_header() {
 fn test_audio_properties_no_vbr_headers() {
 	let f = get_file::<MpegFile>("tests/taglib/data/bladeenc.mp3");
 
-	assert_eq!(f.properties().duration().as_secs(), 3); // Off by 1
+	assert_eq!(f.properties().duration().as_secs(), 3);
 	assert_eq!(f.properties().duration().as_millis(), 3553);
 	assert_eq!(f.properties().audio_bitrate(), 64);
 	assert_eq!(f.properties().channels(), 1);
@@ -102,7 +102,7 @@ fn test_skip_invalid_frames_3() {
 fn test_version_2_duration_with_xing_header() {
 	let f = get_file::<MpegFile>("tests/taglib/data/mpeg2.mp3");
 	assert_eq!(f.properties().duration().as_secs(), 5387); // TODO: Off by 15
-	assert_eq!(f.properties().duration().as_millis(), 5387285);
+	assert_eq!(f.properties().duration().as_millis(), 5_387_285);
 }
 
 #[test]

lofty/tests/taglib/test_ogg.rs

@@ -85,7 +85,7 @@ fn test_audio_properties() {
 	assert_eq!(f.properties().sample_rate(), 44100);
 	assert_eq!(f.properties().version(), 0);
 	assert_eq!(f.properties().bitrate_max(), 0);
-	assert_eq!(f.properties().bitrate_nominal(), 112000);
+	assert_eq!(f.properties().bitrate_nominal(), 112_000);
 	assert_eq!(f.properties().bitrate_min(), 0);
 }
 
@@ -104,7 +104,7 @@ fn test_page_checksum() {
 		f.save_to(&mut file, WriteOptions::default()).unwrap();
 
 		file.seek(SeekFrom::Start(0x50)).unwrap();
-		assert_eq!(file.read_u32::<LittleEndian>().unwrap(), 0x3D3BD92D);
+		assert_eq!(file.read_u32::<LittleEndian>().unwrap(), 0x3D3B_D92D);
 	}
 	file.rewind().unwrap();
 	{
@@ -116,7 +116,7 @@ fn test_page_checksum() {
 		f.save_to(&mut file, WriteOptions::default()).unwrap();
 
 		file.seek(SeekFrom::Start(0x50)).unwrap();
-		assert_eq!(file.read_u32::<LittleEndian>().unwrap(), 0xD985291C);
+		assert_eq!(file.read_u32::<LittleEndian>().unwrap(), 0xD985_291C);
 	}
 }
 

lofty/tests/taglib/test_speex.rs

@@ -42,14 +42,14 @@ fn test_split_packets() {
 		let mut f = SpeexFile::read_from(&mut file, ParseOptions::new()).unwrap();
 		file.rewind().unwrap();
 
-		assert_eq!(file.metadata().unwrap().len(), 156330);
+		assert_eq!(file.metadata().unwrap().len(), 156_330);
 		assert_eq!(f.vorbis_comments().title().as_deref(), Some(text.as_str()));
 
 		// NOTE: TagLib exposes the packets and page headers through `Speex::File`.
 		//       Lofty does not keep this information around, so we just double check with `ogg_pager`.
 		let packets = ogg_pager::Packets::read(&mut file).unwrap();
 		assert_eq!(packets.get(0).unwrap().len(), 80);
-		assert_eq!(packets.get(1).unwrap().len(), 131116);
+		assert_eq!(packets.get(1).unwrap().len(), 131_116);
 		assert_eq!(packets.get(2).unwrap().len(), 93);
 		assert_eq!(packets.get(3).unwrap().len(), 93);
 

lofty/tests/taglib/test_wavpack.rs

@@ -19,7 +19,7 @@ fn test_no_length_properties() {
 	assert_eq!(f.properties().audio_bitrate(), 1);
 	assert_eq!(f.properties().channels(), 2);
 	assert_eq!(f.properties().bit_depth(), 16);
-	assert_eq!(f.properties().is_lossless(), true);
+	assert!(f.properties().is_lossless());
 	assert_eq!(f.properties().sample_rate(), 44100);
 	// TODO: CPPUNIT_ASSERT_EQUAL(163392U, f.audioProperties()->sampleFrames());
 	assert_eq!(f.properties().version(), 1031);
@@ -42,8 +42,8 @@ fn test_dsd_stereo_properties() {
 	assert_eq!(f.properties().audio_bitrate(), 2096);
 	assert_eq!(f.properties().channels(), 2);
 	assert_eq!(f.properties().bit_depth(), 8);
-	assert_eq!(f.properties().is_lossless(), true);
-	assert_eq!(f.properties().sample_rate(), 352800);
+	assert!(f.properties().is_lossless());
+	assert_eq!(f.properties().sample_rate(), 352_800);
 	// TODO: CPPUNIT_ASSERT_EQUAL(70560U, f.audioProperties()->sampleFrames());
 	assert_eq!(f.properties().version(), 1040);
 }
@@ -56,7 +56,7 @@ fn test_non_standard_rate_properties() {
 	assert_eq!(f.properties().audio_bitrate(), 0);
 	assert_eq!(f.properties().channels(), 2);
 	assert_eq!(f.properties().bit_depth(), 16);
-	assert_eq!(f.properties().is_lossless(), true);
+	assert!(f.properties().is_lossless());
 	assert_eq!(f.properties().sample_rate(), 1000);
 	// TODO: CPPUNIT_ASSERT_EQUAL(3675U, f.audioProperties()->sampleFrames());
 	assert_eq!(f.properties().version(), 1040);
@@ -70,7 +70,7 @@ fn test_tagged_properties() {
 	assert_eq!(f.properties().audio_bitrate(), 172);
 	assert_eq!(f.properties().channels(), 2);
 	assert_eq!(f.properties().bit_depth(), 16);
-	assert_eq!(f.properties().is_lossless(), false);
+	assert!(!f.properties().is_lossless());
 	assert_eq!(f.properties().sample_rate(), 44100);
 	// TODO: CPPUNIT_ASSERT_EQUAL(156556U, f.audioProperties()->sampleFrames());
 	assert_eq!(f.properties().version(), 1031);