misc: Downgrade Clippy and rustfmt to stable toolchain

Author: Serial-ATA

.github/workflows/ci.yml

@@ -74,7 +74,7 @@ jobs:
       - name: Install Rust toolchain
         uses: dtolnay/rust-toolchain@v1
         with:
-          toolchain: nightly
+          toolchain: stable
           components: clippy
       - run: |
           cargo clippy --all-features -- -Dclippy::all -Dclippy::pedantic
@@ -93,7 +93,7 @@ jobs:
       - name: Install Rust toolchain
         uses: dtolnay/rust-toolchain@v1
         with:
-          toolchain: nightly
+          toolchain: stable
           components: rustfmt
       - run: |
           cargo fmt -- --check

src/id3/v2/tag.rs

@@ -923,7 +923,7 @@ impl MergeTag for SplitTagRemainder {
 			let frame_id = item_key
 				.map_key(TagType::Id3v2, false)
 				.expect("valid frame id");
-			if let Some(text) = join_text_items(&mut tag, [item_key].into_iter()) {
+			if let Some(text) = join_text_items(&mut tag, [item_key]) {
 				let frame = new_text_frame(
 					FrameId::Valid(Cow::Borrowed(frame_id)),
 					text,

src/lib.rs

@@ -136,6 +136,8 @@
 	clippy::manual_let_else,
 	clippy::let_underscore_untyped,
 	clippy::field_reassign_with_default,
+	clippy::manual_range_patterns, /* This is not at all clearer as it suggests */
+	clippy::explicit_iter_loop,
 )]
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
 

src/ogg/mod.rs

@@ -30,7 +30,7 @@ pub use tag::VorbisComments;
 pub use vorbis::properties::VorbisProperties;
 pub use vorbis::VorbisFile;
 
-pub(self) fn verify_signature(content: &[u8], sig: &[u8]) -> Result<()> {
+fn verify_signature(content: &[u8], sig: &[u8]) -> Result<()> {
 	let sig_len = sig.len();
 
 	if content.len() < sig_len || &content[..sig_len] != sig {
@@ -40,7 +40,7 @@ pub(self) fn verify_signature(content: &[u8], sig: &[u8]) -> Result<()> {
 	Ok(())
 }
 
-pub(self) fn find_last_page<R>(data: &mut R) -> Result<Page>
+fn find_last_page<R>(data: &mut R) -> Result<Page>
 where
 	R: Read + Seek,
 {