Test coverage (#59)

* Update UserTest.php

* Update User.php

* Update UserTest.php

* Update AppServiceProvider.php

* Update phpunit.xml

* Don't rehash password on login in tests

* wip

* Create EmailVerificationControllerTest.php

* Update EmailVerificationControllerTest.php

* Update ResetPasswordControllerTest.php

Author: SebKay

app/Models/User.php

@@ -81,11 +81,14 @@ public function updatePassword(?string $new_password = '')
         }
     }
 
-    public function canAccessPanel(Panel $panel): bool
+    public function canAccessPanel(?Panel $panel = null): bool
     {
         return $this->hasRole(Role::SUPER_ADMIN->value);
     }
 
+    /**
+     * @codeCoverageIgnore
+     */
     public function getFilamentName(): string
     {
         return $this->fullName;

app/Providers/AppServiceProvider.php

@@ -24,12 +24,14 @@ public function boot(): void
     {
         JsonResource::withoutWrapping();
 
+        // @codeCoverageIgnoreStart
         Pulse::users(function ($ids) {
             return User::findMany($ids)->map(fn ($user) => [
                 'id' => $user->id,
                 'name' => $user->fullName,
                 'extra' => "{$user->email} ({$user->roles->pluck('name')->implode(', ')})",
             ]);
         });
+        // @codeCoverageIgnoreEnd
     }
 }

phpunit.xml

@@ -14,7 +14,9 @@
       <directory suffix=".php">./app</directory>
     </include>
     <exclude>
-      <directory suffix=".php">app/Filament</directory>
+      <directory suffix=".php">./app/Filament</directory>
+      <directory suffix=".php">./app/Providers/Filament</directory>
+      <file>./app/Providers/HorizonServiceProvider.php</file>
     </exclude>
   </source>
 </phpunit>

tests/Feature/Controllers/EmailVerificationControllerTest.php

@@ -0,0 +1,38 @@
+<?php
+
+use App\Models\User;
+use Illuminate\Support\Facades\Notification;
+use Inertia\Testing\AssertableInertia as Assert;
+
+use function Pest\Laravel\actingAs;
+use function Pest\Laravel\get;
+
+describe('Users', function () {
+    test('Can access the verification page', function () {
+        actingAs(User::factory()->unverified()->create())
+            ->get(route('verification.notice'))
+            ->assertInertia(
+                fn (Assert $page) => $page
+                    ->component('EmailVerification/Show')
+            );
+    });
+
+    test('Can send the verificaiton notice', function () {
+        Notification::fake();
+
+        $user = User::factory()->unverified()->create();
+
+        actingAs($user)
+            ->post(route('verification.send'))
+            ->assertRedirect();
+
+        Notification::assertSentTo($user, Illuminate\Auth\Notifications\VerifyEmail::class);
+    });
+});
+
+describe('Guests', function () {
+    test("Can't access the verification page", function () {
+        get(route('verification.notice'))
+            ->assertRedirect(route('login'));
+    });
+});

tests/Feature/Controllers/ResetPasswordControllerTest.php

@@ -2,7 +2,6 @@
 
 use App\Models\User;
 use Illuminate\Auth\Notifications\ResetPassword;
-use Illuminate\Support\Facades\Hash;
 use Illuminate\Support\Facades\Notification;
 use Illuminate\Support\Facades\Password;
 use Inertia\Testing\AssertableInertia as Assert;
@@ -77,6 +76,4 @@
         'password_confirmation' => $newPassword,
     ]))
         ->assertRedirect();
-
-    expect(Hash::check($newPassword, $user->refresh()->password))->toBeTrue();
 });

tests/Integration/UserTest.php

@@ -1,8 +1,18 @@
 <?php
 
 use App\Models\User;
+use Database\Seeders\RolesAndPermissionsSeeder;
 use Illuminate\Support\Facades\Hash;
 
+it("can get it's \"full_name\" correctly", function () {
+    $user = User::factory()->create([
+        'first_name' => 'John',
+        'last_name' => 'Doe',
+    ]);
+
+    expect($user->full_name)->toBe('John Doe');
+});
+
 it("can update it's password", function () {
     $user = User::factory()->create([
         'password' => 'oldPassword#123',
@@ -30,3 +40,17 @@
 
     expect(Hash::check('oldPassword#123', $user->refresh()->password))->toBeTrue();
 });
+
+describe('With Roles and Permissions', function () {
+    beforeEach(function () {
+        $this->seed(RolesAndPermissionsSeeder::class);
+    });
+
+    it("can only access Filament if it's a \"super-admin\"", function () {
+        $superAdminUser = User::factory()->superAdmin()->create();
+        $adminUser = User::factory()->admin()->create();
+
+        expect($superAdminUser->canAccessPanel())->toBeTrue();
+        expect($adminUser->canAccessPanel())->toBeFalse();
+    });
+});