Test coverage (#63)

* Update AuthServiceProvider.php

* Update AppServiceProvider.php

* Update EmailVerificationControllerTest.php

* Update ResetPasswordController.php

* Update ResetPasswordControllerTest.php

* Update ResetPasswordController.php

* Update EmailVerificationControllerTest.php

Author: SebKay

app/Http/Controllers/ResetPasswordController.php

@@ -22,11 +22,9 @@ public function store(ResetPasswordStore $request)
     {
         $status = Password::sendResetLink($request->only('email'));
 
-        if ($status !== Password::RESET_LINK_SENT) {
-            throw ValidationException::withMessages([
-                'reset_link' => \__($status),
-            ]);
-        }
+        \throw_if($status !== Password::RESET_LINK_SENT, ValidationException::withMessages([
+            'reset_link' => \__($status),
+        ]));
 
         \session()->flash('success', \__('passwords.sent'));
 
@@ -53,11 +51,9 @@ public function update(ResetPasswordUpdate $request)
             \event(new PasswordReset($user));
         });
 
-        if ($status !== Password::PASSWORD_RESET) {
-            throw ValidationException::withMessages([
-                'reset' => __($status),
-            ]);
-        }
+        \throw_if($status !== Password::PASSWORD_RESET, ValidationException::withMessages([
+            'reset' => \__($status),
+        ]));
 
         \session()->flash('success', \__('passwords.reset'));
 

app/Providers/AppServiceProvider.php

@@ -14,6 +14,7 @@ public function boot(): void
     {
         JsonResource::withoutWrapping();
 
+        // @codeCoverageIgnoreStart
         Carbon::macro('inAppTimezone', function () {
             return $this->tz(config('app.timezone_display'));
         });
@@ -22,7 +23,6 @@ public function boot(): void
             return $this->tz(auth()->user()?->timezone ?? config('app.timezone_display'));
         });
 
-        // @codeCoverageIgnoreStart
         Pulse::users(function ($ids) {
             return User::findMany($ids)->map(fn ($user) => [
                 'id' => $user->id,

app/Providers/AuthServiceProvider.php

@@ -11,8 +11,10 @@ class AuthServiceProvider extends ServiceProvider
 {
     public function boot(): void
     {
+        // @codeCoverageIgnoreStart
         Gate::define('viewPulse', function (User $user) {
             return $user->hasRole(Role::SUPER_ADMIN->value);
         });
+        // @codeCoverageIgnoreEnd
     }
 }

tests/Feature/Controllers/EmailVerificationControllerTest.php

@@ -6,6 +6,7 @@
 
 use function Pest\Laravel\actingAs;
 use function Pest\Laravel\get;
+use function Pest\Laravel\withoutExceptionHandling;
 
 describe('Users', function () {
     test('Can access the verification page', function () {
@@ -17,6 +18,24 @@
             );
     });
 
+    test('Can verify their email address', function () {
+        withoutExceptionHandling();
+
+        $user = User::factory()->unverified()->create();
+
+        expect($user->verified_at)->toBeNull();
+
+        actingAs($user)
+            ->withoutMiddleware(Illuminate\Routing\Middleware\ValidateSignature::class)
+            ->get(route('verification.verify', [
+                'id' => $user->getKey(),
+                'hash' => sha1($user->getEmailForVerification()),
+            ]))
+            ->assertRedirect(route('home'));
+
+        expect($user->refresh()->email_verified_at)->not()->toBeNull();
+    });
+
     test('Can send the verificaiton notice', function () {
         Notification::fake();
 

tests/Feature/Controllers/ResetPasswordControllerTest.php

@@ -20,7 +20,7 @@
         );
 });
 
-test('A password reset email can be sent', function () {
+test('A password reset email can be requested', function () {
     Notification::fake();
 
     $user = User::factory()->create();