Refactor tests (#20)

* Update AccountControllerTest.php

* Update LoginControllerTest.php

* Update UserTest.php

Author: SebKay

tests/Feature/Controllers/AccountControllerTest.php

@@ -17,7 +17,7 @@
         );
 });
 
-test("Guests can't edit any accounts", function () {
+test("Guests can't edit accounts", function () {
     get(route('account.edit'))->assertRedirect(route('login'));
 });
 
@@ -43,7 +43,8 @@
             'email' => 'tim@test.com',
             'password' => 'newPassword#123',
         ])
-        ->assertRedirect();
+        ->assertRedirect()
+        ->assertSessionHas('message', 'Your account has been updated.');
 
     $user->refresh();
 
@@ -55,7 +56,7 @@
     expect(Hash::check('newPassword#123', $user->password))->toBeTrue();
 });
 
-test("Guests can't update any details", function () {
+test("Guests can't update details", function () {
     patch(route('account.update'), [
         'name' => 'Tim Drake',
         'email' => 'tim@test.com',

tests/Feature/Controllers/LoginControllerTest.php

@@ -63,7 +63,7 @@
         'email' => $user->email,
         'password' => 'test',
     ])
-        ->assertsessionHasErrors('email');
+        ->assertsessionHasErrors();
 
     assertGuest();
 });

tests/Integration/UserTest.php

@@ -3,26 +3,6 @@
 use App\Models\User;
 use Illuminate\Support\Facades\Hash;
 
-it('has a first name', function () {
-    $firstName = 'Jim';
-
-    $user = User::factory()->create([
-        'first_name' => $firstName,
-    ]);
-
-    expect($user)->first_name->toBe($firstName);
-});
-
-it('has a last name', function () {
-    $lastName = 'Gordon';
-
-    $user = User::factory()->create([
-        'last_name' => $lastName,
-    ]);
-
-    expect($user)->last_name->toBe($lastName);
-});
-
 it("can update it's password", function () {
     $user = User::factory()->create([
         'password' => 'oldPassword#123',