Skip to content

Commit 979f814

Browse files
authored
Add Pest architecture tests (#75)
* Enable Laravel architecture preset * Add "Request" suffix to all form requests
1 parent 8105002 commit 979f814

15 files changed

+37
-23
lines changed

app/Http/Controllers/AccountController.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
namespace App\Http\Controllers;
44

5-
use App\Http\Requests\Account\AccountUpdate;
5+
use App\Http\Requests\Account\AccountUpdateRequest;
66
use App\Http\Resources\UserResource;
77
use Illuminate\Http\Request;
88

@@ -15,7 +15,7 @@ public function edit(Request $request)
1515
]);
1616
}
1717

18-
public function update(AccountUpdate $request)
18+
public function update(AccountUpdateRequest $request)
1919
{
2020
$request->user()->update($request->only('first_name', 'last_name', 'email'));
2121
$request->user()->updatePassword($request->validated('password'));

app/Http/Controllers/LoginController.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
namespace App\Http\Controllers;
44

5-
use App\Http\Requests\Login\LoginStore;
5+
use App\Http\Requests\Login\LoginStoreRequest;
66
use Illuminate\Http\Request;
77
use Illuminate\Validation\ValidationException;
88

@@ -20,7 +20,7 @@ public function show(Request $request)
2020
]);
2121
}
2222

23-
public function store(LoginStore $request)
23+
public function store(LoginStoreRequest $request)
2424
{
2525
\throw_if(
2626
! \auth()->attempt($request->only('email', 'password'), $request->only('remember')),

app/Http/Controllers/OrganisationController.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,20 @@
22

33
namespace App\Http\Controllers;
44

5-
use App\Http\Requests\Organisation\OrganisationEdit;
6-
use App\Http\Requests\Organisation\OrganisationUpdate;
5+
use App\Http\Requests\Organisation\OrganisationEditRequest;
6+
use App\Http\Requests\Organisation\OrganisationUpdateRequest;
77
use App\Http\Resources\OrganisationResource;
88

99
class OrganisationController extends Controller
1010
{
11-
public function edit(OrganisationEdit $request)
11+
public function edit(OrganisationEditRequest $request)
1212
{
1313
return \inertia('Organisation/Edit', [
1414
'organisation' => OrganisationResource::make($request->user()->organisation),
1515
]);
1616
}
1717

18-
public function update(OrganisationUpdate $request)
18+
public function update(OrganisationUpdateRequest $request)
1919
{
2020
$request->user()->organisation->update($request->only('name'));
2121

app/Http/Controllers/RegisterController.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
namespace App\Http\Controllers;
44

55
use App\Enums\Role;
6-
use App\Http\Requests\Register\RegisterStore;
6+
use App\Http\Requests\Register\RegisterStoreRequest;
77
use App\Models\User;
88
use Illuminate\Auth\Events\Registered;
99

@@ -20,7 +20,7 @@ public function show()
2020
] : []);
2121
}
2222

23-
public function store(RegisterStore $request)
23+
public function store(RegisterStoreRequest $request)
2424
{
2525
$user = new User($request->only('first_name', 'last_name', 'email'));
2626

app/Http/Controllers/ResetPasswordController.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
namespace App\Http\Controllers;
44

5-
use App\Http\Requests\ResetPassword\ResetPasswordStore;
6-
use App\Http\Requests\ResetPassword\ResetPasswordUpdate;
5+
use App\Http\Requests\ResetPassword\ResetPasswordStoreRequest;
6+
use App\Http\Requests\ResetPassword\ResetPasswordUpdateRequest;
77
use App\Models\User;
88
use Illuminate\Auth\Events\PasswordReset;
99
use Illuminate\Http\Request;
@@ -18,7 +18,7 @@ public function show(Request $request)
1818
return \inertia('ResetPassword/Show');
1919
}
2020

21-
public function store(ResetPasswordStore $request)
21+
public function store(ResetPasswordStoreRequest $request)
2222
{
2323
$status = Password::sendResetLink($request->only('email'));
2424

@@ -39,7 +39,7 @@ public function edit(Request $request, string $token)
3939
]);
4040
}
4141

42-
public function update(ResetPasswordUpdate $request)
42+
public function update(ResetPasswordUpdateRequest $request)
4343
{
4444
$status = Password::reset($request->only('token', 'email', 'password', 'token'), function (User $user, string $password) {
4545
$user->forceFill([

app/Http/Requests/Account/AccountUpdate.php renamed to app/Http/Requests/Account/AccountUpdateRequest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
use Illuminate\Foundation\Http\FormRequest;
66
use Illuminate\Validation\Rules\Password;
77

8-
class AccountUpdate extends FormRequest
8+
class AccountUpdateRequest extends FormRequest
99
{
1010
public function rules()
1111
{

app/Http/Requests/Login/LoginStore.php renamed to app/Http/Requests/Login/LoginStoreRequest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
use Illuminate\Foundation\Http\FormRequest;
66

7-
class LoginStore extends FormRequest
7+
class LoginStoreRequest extends FormRequest
88
{
99
public function rules()
1010
{

app/Http/Requests/Organisation/OrganisationEdit.php renamed to app/Http/Requests/Organisation/OrganisationEditRequest.php

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,15 @@
55
use Illuminate\Foundation\Http\FormRequest;
66
use Illuminate\Support\Facades\Gate;
77

8-
class OrganisationEdit extends FormRequest
8+
class OrganisationEditRequest extends FormRequest
99
{
10-
public function authorize()
10+
public function authorize(): bool
1111
{
1212
return Gate::allows('edit', $this->user()->organisation);
1313
}
14+
15+
public function rules(): array
16+
{
17+
return [];
18+
}
1419
}

app/Http/Requests/Organisation/OrganisationUpdate.php renamed to app/Http/Requests/Organisation/OrganisationUpdateRequest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
use Illuminate\Foundation\Http\FormRequest;
66
use Illuminate\Support\Facades\Gate;
77

8-
class OrganisationUpdate extends FormRequest
8+
class OrganisationUpdateRequest extends FormRequest
99
{
1010
public function authorize()
1111
{

app/Http/Requests/Register/RegisterStore.php renamed to app/Http/Requests/Register/RegisterStoreRequest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
use Illuminate\Foundation\Http\FormRequest;
66
use Illuminate\Validation\Rules\Password;
77

8-
class RegisterStore extends FormRequest
8+
class RegisterStoreRequest extends FormRequest
99
{
1010
public function rules()
1111
{

0 commit comments

Comments
 (0)