Testing bits (#69)

* Update AccountControllerTest.php

* Update EmailVerificationControllerTest.php

* Update HomeControllerTest.php

* Update LoginControllerTest.php

* Update LogoutControllerTest.php

* Update RolesAndPermissionsSeeder.php

* Update OrganisationControllerTest.php

* Update RegisterControllerTest.php

* Update ResetPasswordControllerTest.php

Author: SebKay

database/seeders/RolesAndPermissionsSeeder.php

@@ -61,9 +61,11 @@ protected function createPermissions()
     protected function assignPermissionsToRoles()
     {
         $this->roles->get(Role::SUPER_ADMIN->value)->givePermissionTo($this->superAdminPermissions);
+        $this->roles->get(Role::SUPER_ADMIN->value)->givePermissionTo($this->orgnaisationPermissions);
+        $this->roles->get(Role::SUPER_ADMIN->value)->givePermissionTo($this->postPermissions);
 
-        $this->roles->get(Role::ADMIN->value)->givePermissionTo($this->postPermissions);
         $this->roles->get(Role::ADMIN->value)->givePermissionTo($this->orgnaisationPermissions);
+        $this->roles->get(Role::ADMIN->value)->givePermissionTo($this->postPermissions);
 
         $this->roles->get(Role::USER->value)->givePermissionTo($this->postPermissions);
     }

tests/Feature/Controllers/AccountControllerTest.php

@@ -15,6 +15,7 @@
 
         actingAs($user)
             ->get(route('account.edit'))
+            ->assertOk()
             ->assertInertia(
                 fn (Assert $page) => $page
                     ->component('Account/Edit')
@@ -42,6 +43,7 @@
                 'password' => 'newPassword#123',
             ])
             ->assertRedirectToRoute('account.edit')
+            ->assertSessionDoesntHaveErrors()
             ->assertSessionHas('success', __('account.updated'));
 
         expect($user->refresh())
@@ -62,10 +64,12 @@
         ]);
 
         actingAs($user)
+            ->from(route('account.edit'))
             ->patch(route('account.update'), $newData = [
                 'email' => 'jim@test.com',
             ])
-            ->assertSessionHasErrors('email');
+            ->assertSessionHasErrors('email')
+            ->assertRedirectToRoute('account.edit');
 
         expect($user->refresh()->email)->not()->toBe($newData['email']);
     });

tests/Feature/Controllers/EmailVerificationControllerTest.php

@@ -13,6 +13,7 @@
     test('Can access the verification page', function () {
         actingAs(User::factory()->unverified()->create())
             ->get(route('verification.notice'))
+            ->assertOk()
             ->assertInertia(
                 fn (Assert $page) => $page
                     ->component('EmailVerification/Show')
@@ -32,6 +33,7 @@
                 'id' => $user->getKey(),
                 'hash' => sha1($user->getEmailForVerification()),
             ]))
+            ->assertSessionDoesntHaveErrors()
             ->assertRedirectToRoute('home');
 
         expect($user->refresh()->email_verified_at)->not()->toBeNull();
@@ -45,6 +47,7 @@
         from(route('verification.notice'))
             ->actingAs($user)
             ->post(route('verification.send'))
+            ->assertSessionDoesntHaveErrors()
             ->assertRedirectToRoute('verification.notice');
 
         Notification::assertSentTo($user, Illuminate\Auth\Notifications\VerifyEmail::class);

tests/Feature/Controllers/HomeControllerTest.php

@@ -10,6 +10,7 @@
     test('Can access the home page', function () {
         actingAs(User::factory()->create())
             ->get(route('home'))
+            ->assertOk()
             ->assertInertia(
                 fn (Assert $page) => $page
                     ->component('Dashboard/Index')

tests/Feature/Controllers/LoginControllerTest.php

@@ -37,6 +37,7 @@
             'email' => $user->email,
             'password' => '12345',
         ])
+            ->assertSessionDoesntHaveErrors()
             ->assertRedirectToRoute('home');
 
         assertAuthenticated();
@@ -55,6 +56,7 @@
                 'password' => '12345',
                 'redirect' => $redirect,
             ])
+            ->assertSessionDoesntHaveErrors()
             ->assertRedirect($redirect);
 
         assertAuthenticated();
@@ -69,7 +71,7 @@
             'email' => $user->email,
             'password' => 'test',
         ])
-            ->assertsessionHasErrors();
+            ->assertSessionHasErrors();
 
         assertGuest();
     });

tests/Feature/Controllers/LogoutControllerTest.php

@@ -10,6 +10,7 @@
     test('Can logout', function () {
         actingAs(User::factory()->create())
             ->post(route('logout'))
+            ->assertSessionDoesntHaveErrors()
             ->assertRedirectToRoute('login');
 
         assertGuest();
@@ -19,6 +20,7 @@
 describe('Guests', function () {
     test("Can't logout", function () {
         post(route('logout'))
+            ->assertSessionDoesntHaveErrors()
             ->assertRedirectToRoute('login');
     });
 });

tests/Feature/Controllers/OrganisationControllerTest.php

@@ -1,6 +1,7 @@
 <?php
 
 use App\Models\User;
+use Inertia\Testing\AssertableInertia as Assert;
 
 use function Pest\Laravel\actingAs;
 use function Pest\Laravel\from;
@@ -23,7 +24,11 @@
     test('Can see the edit page for their current organisation', function () {
         actingAs($this->adminUser)
             ->get(route('organisation.edit'))
-            ->assertOk();
+            ->assertOk()
+            ->assertInertia(
+                fn (Assert $page) => $page
+                    ->component('Organisation/Edit')
+            );
     });
 
     test("Can update their organisation's name", function () {
@@ -34,6 +39,7 @@
             ->patch(route('organisation.update'), [
                 'name' => 'New Name',
             ])
+            ->assertSessionDoesntHaveErrors()
             ->assertRedirectToRoute('organisation.edit');
 
         expect($this->adminUser->organisation->refresh()->name)->toBe('New Name');
@@ -73,11 +79,11 @@
 describe('Guests', function () {
     test("Can't see the edit page of organisations", function () {
         get(route('organisation.edit'))
-            ->assertRedirect();
+            ->assertRedirectToRoute('login');
     });
 
     test("Can't update organisations", function () {
         patch(route('organisation.edit'))
-            ->assertRedirect();
+            ->assertRedirectToRoute('login');
     });
 });

tests/Feature/Controllers/RegisterControllerTest.php

@@ -39,6 +39,7 @@
             'email' => $email,
             'password' => 'P$ssword12345#',
         ])
+            ->assertSessionDoesntHaveErrors()
             ->assertRedirectToRoute('home');
 
         assertDatabaseHas('users', [

tests/Feature/Controllers/ResetPasswordControllerTest.php

@@ -28,6 +28,7 @@
     post(route('password.store'), [
         'email' => $user->email,
     ])
+        ->assertSessionDoesntHaveErrors()
         ->assertRedirectToRoute('login');
 
     Notification::assertSentTo($user, ResetPassword::class);
@@ -40,7 +41,7 @@
         ->post(route('password.store'), [
             'email' => fake()->email(),
         ])
-        ->assertsessionHasErrors('email')
+        ->assertSessionHasErrors('email')
         ->assertRedirectToRoute('password');
 
     Notification::assertNothingSent();
@@ -75,5 +76,6 @@
         'password' => $newPassword,
         'password_confirmation' => $newPassword,
     ]))
+        ->assertSessionDoesntHaveErrors()
         ->assertRedirectToRoute('login');
 });