Changed ImportSpecification::setMaxFetchAttempts to throw exception instead of silently converting invalid values.

Author: Bilge

src/Specification/ImportSpecification.php

@@ -229,8 +229,11 @@ final public function getMaxFetchAttempts()
      */
     final public function setMaxFetchAttempts($attempts)
     {
-        // TODO: Consider throwing exception instead of silently constraining bounds.
-        $this->maxFetchAttempts = max(1, $attempts | 0);
+        if (!is_int($attempts) || $attempts < 1) {
+            throw new \InvalidArgumentException('Fetch attempts must be greater than or equal to 1.');
+        }
+
+        $this->maxFetchAttempts = $attempts;
 
         return $this;
     }

test/Unit/Porter/ImportSpecificationTest.php

@@ -114,27 +114,40 @@ public function testCache()
     }
 
     /**
-     * @param mixed $input
-     * @param int $output
+     * @param int $value
      *
-     * @dataProvider provideFetchAttempts
+     * @dataProvider provideValidFetchAttempts
      */
-    public function testMaxFetchAttempts($input, $output)
+    public function testValidMaxFetchAttempts($value)
     {
-        self::assertSame($output, $this->specification->setMaxFetchAttempts($input)->getMaxFetchAttempts());
+        self::assertSame($value, $this->specification->setMaxFetchAttempts($value)->getMaxFetchAttempts());
     }
 
-    public function provideFetchAttempts()
+    public function provideValidFetchAttempts()
     {
         return [
-            // Valid.
-            [1, 1],
-            [2, 2],
-
-            // Invalid.
-            'Too low, positive' => [0, 1],
-            'Too low, negative' => [-1, 1],
-            'Float in range' => [1.9, 1],
+            [1],
+            [PHP_INT_MAX],
+        ];
+    }
+
+    /**
+     * @param mixed $value
+     *
+     * @dataProvider provideInvalidFetchAttempts
+     */
+    public function testInvalidMaxFetchAttempts($value)
+    {
+        $this->setExpectedException(\InvalidArgumentException::class);
+        $this->specification->setMaxFetchAttempts($value);
+    }
+
+    public function provideInvalidFetchAttempts()
+    {
+        return [
+            'Too low, positive' => [0],
+            'Too low, negative' => [-1],
+            'Float in range' => [1.9],
         ];
     }