Fixed ImportSpecification method parameter naming.

Added test for ImportSpecification::disableCache() to complete code coverage.

Author: Bilge

src/Specification/ImportSpecification.php

@@ -91,13 +91,13 @@ final public function getProviderName()
     /**
      * Sets the provider name.
      *
-     * @param string $tag Provider name.
+     * @param string $providerName Provider name.
      *
      * @return $this
      */
-    final public function setProviderName($tag)
+    final public function setProviderName($providerName)
     {
-        $this->providerName = "$tag";
+        $this->providerName = "$providerName";
 
         return $this;
     }
@@ -228,6 +228,7 @@ final public function getMaxFetchAttempts()
      */
     final public function setMaxFetchAttempts($attempts)
     {
+        // TODO: Consider throwing exception instead of silently constraining bounds.
         $this->maxFetchAttempts = max(1, $attempts | 0);
 
         return $this;

test/Unit/Porter/ImportSpecificationTest.php

@@ -7,6 +7,9 @@
 use ScriptFUSION\Porter\Transform\Transformer;
 use ScriptFUSIONTest\Stubs\Invokable;
 
+/**
+ * @see ImportSpecification
+ */
 final class ImportSpecificationTest extends \PHPUnit_Framework_TestCase
 {
     /** @var ImportSpecification */
@@ -48,14 +51,14 @@ public function testClone()
         self::assertNotSame($handler, $specification->getFetchExceptionHandler());
     }
 
-    public function testProviderData()
+    public function testGetResource()
     {
         self::assertSame($this->resource, $this->specification->getResource());
     }
 
-    public function testProviderTag()
+    public function testProviderName()
     {
-        self::assertSame($tag = 'foo', $this->specification->setProviderName($tag)->getProviderName());
+        self::assertSame($name = 'foo', $this->specification->setProviderName($name)->getProviderName());
     }
 
     public function testAddTransformer()
@@ -105,6 +108,9 @@ public function testCache()
 
         $this->specification->enableCache();
         self::assertTrue($this->specification->mustCache());
+
+        $this->specification->disableCache();
+        self::assertFalse($this->specification->mustCache());
     }
 
     /**