Skip to content

Commit dcd4f9c

Browse files
CopilotVinciGit00
andcommitted
docs: update semantic commit guide to use feat(timeout)
Update SEMANTIC_COMMITS.md to use feat(timeout) instead of docs(timeout) as requested. The timeout feature documentation exposes user-facing functionality and warrants a feature-level semantic version bump. Changed commit 323f26a recommendation from: - docs(timeout): add comprehensive timeout configuration guide To: - feat(timeout): add configurable timeout support for FetchNode Addresses feedback from @VinciGit00. Co-authored-by: VinciGit00 <88108002+VinciGit00@users.noreply.github.com>
1 parent 2920d8b commit dcd4f9c

File tree

1 file changed

+14
-10
lines changed

1 file changed

+14
-10
lines changed

SEMANTIC_COMMITS.md

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
This PR contains commits that need to be rewritten to follow Conventional Commits format for semantic-release compatibility.
66

7+
**Note:** The timeout documentation is marked as `feat(timeout)` (not `docs`) because it exposes a user-facing feature. Even though the implementation existed, this PR makes the feature discoverable and usable by users through documentation, which warrants a feature-level semantic version bump.
8+
79
## Commits to Rewrite
810

911
### Commit 1: 9439fe5
@@ -30,22 +32,23 @@ Fixes #1015
3032

3133
**Should be:**
3234
```
33-
docs(timeout): add comprehensive timeout configuration guide
35+
feat(timeout): add configurable timeout support for FetchNode
3436
35-
Add detailed documentation for FetchNode timeout feature including:
37+
Add comprehensive documentation for the timeout configuration feature:
3638
- Configuration examples with different timeout values
3739
- Use cases for HTTP requests, PDF parsing, and ChromiumLoader
3840
- Graph integration examples
3941
- Best practices and troubleshooting guide
4042
41-
The timeout feature was already implemented in the base code and this
42-
documentation helps users configure and use it effectively.
43+
The timeout feature enables users to control execution time for blocking
44+
operations (HTTP requests, PDF parsing, ChromiumLoader) to prevent
45+
indefinite hangs. Configurable via node_config with 30s default.
4346
4447
Fixes #1015
4548
```
4649

47-
**Type:** `docs` - Documentation changes only
48-
**Scope:** `timeout` - Related to timeout feature documentation
50+
**Type:** `feat` - New feature documentation/exposure to users
51+
**Scope:** `timeout` - Timeout configuration feature
4952

5053
---
5154

@@ -82,16 +85,17 @@ Fixes #1015"
8285
git add docs/
8386

8487
# Commit with semantic message
85-
git commit -m "docs(timeout): add comprehensive timeout configuration guide
88+
git commit -m "feat(timeout): add configurable timeout support for FetchNode
8689
87-
Add detailed documentation for FetchNode timeout feature including:
90+
Add comprehensive documentation for the timeout configuration feature:
8891
- Configuration examples with different timeout values
8992
- Use cases for HTTP requests, PDF parsing, and ChromiumLoader
9093
- Graph integration examples
9194
- Best practices and troubleshooting guide
9295
93-
The timeout feature was already implemented in the base code and this
94-
documentation helps users configure and use it effectively.
96+
The timeout feature enables users to control execution time for blocking
97+
operations (HTTP requests, PDF parsing, ChromiumLoader) to prevent
98+
indefinite hangs. Configurable via node_config with 30s default.
9599
96100
Fixes #1015"
97101

0 commit comments

Comments
 (0)