Incorrect RetCode upon termination due to stalling of iterates or repeated shrinking of TR

Author: FHoltorf

src/trustRegion.jl

@@ -155,15 +155,15 @@ function SciMLBase.__solve(prob::NonlinearProblem,
             shrink_counter += 1
             if shrink_counter > max_shrink_times
                 return SciMLBase.build_solution(prob, alg, x, F;
-                    retcode = ReturnCode.Success)
+                    retcode = ReturnCode.ConvergenceFailure)
             end
         else
             shrink_counter = 0
         end
         if r > η₁
             if isapprox(xₖ₊₁, x, atol = atol, rtol = rtol)
                 return SciMLBase.build_solution(prob, alg, xₖ₊₁, Fₖ₊₁;
-                    retcode = ReturnCode.Success)
+                    retcode = ReturnCode.ConvergenceFailure)
             end
             # Take the step.
             x = xₖ₊₁