Dont default to Polyester

Author: avik-pal

src/nlsolve/halley.jl

@@ -33,7 +33,7 @@ function SciMLBase.__solve(prob::NonlinearProblem, alg::SimpleHalley, args...;
     fx = _get_fx(prob, x)
     T = eltype(x)
 
-    autodiff = __get_concrete_autodiff(prob, alg.autodiff; polyester = Val(false))
+    autodiff = __get_concrete_autodiff(prob, alg.autodiff)
     abstol, reltol, tc_cache = init_termination_cache(abstol, reltol, fx, x,
         termination_condition)
 

src/utils.jl

@@ -365,18 +365,9 @@ end
 
 # Decide which AD backend to use
 @inline __get_concrete_autodiff(prob, ad::ADTypes.AbstractADType; kwargs...) = ad
-@inline function __get_concrete_autodiff(prob, ::Nothing; polyester::Val{P} = Val(true),
-        kwargs...) where {P}
-    if ForwardDiff.can_dual(eltype(prob.u0))
-        if P && __is_extension_loaded(Val(:PolyesterForwardDiff)) &&
-           !(prob.u0 isa Number) && ArrayInterface.can_setindex(prob.u0)
-            return AutoPolyesterForwardDiff()
-        else
-            return AutoForwardDiff()
-        end
-    else
-        return AutoFiniteDiff()
-    end
+@inline function __get_concrete_autodiff(prob, ::Nothing; kwargs...)
+    return ifelse(
+        ForwardDiff.can_dual(eltype(prob.u0)), AutoForwardDiff(), AutoFiniteDiff())
 end
 
 @inline __reshape(x::Number, args...) = x