feat: update the quadratic code

Author: avik-pal

benchmarks/NonlinearProblem/Manifest.toml

@@ -2,7 +2,7 @@
 
 julia_version = "1.10.5"
 manifest_format = "2.0"
-project_hash = "c0341b6caab7bc70b549b0efc4bef4b3156650a1"
+project_hash = "480cf1462c232d469aa9d1beac73134dc94adc3e"
 
 [[deps.ADTypes]]
 git-tree-sha1 = "eea5d80188827b35333801ef97a40c2ed653b081"

benchmarks/NonlinearProblem/quadratic_nonlinear.jmd

@@ -194,7 +194,7 @@ save("static_arrays_quadratic.svg", fig)
 
 ```julia
 probs = [generate_prob(Val(N), Val(false)) for N in [4, 16, 128, 1024]]
-wpsets = [(@show length(prob.u0); generate_wpset(prob, solvers)) for prob in probs]
+wpsets = [generate_wpset(prob, solvers) for prob in probs]
 titles = ["N = 4", "N = 16", "N = 128", "N = 1024"]
 
 fig = plot_all_wpsets(wpsets, solvers, titles, "Regular Julia Arrays")
@@ -207,46 +207,25 @@ save("regular_arrays_quadratic.svg", fig)
 ## Comparison against SimpleNonlinearSolve
 
 ```julia
-function __set_ad_chunksize(solver::GeneralizedFirstOrderAlgorithm{CJ, N}, ck) where {CJ, N}
-    ad = AutoForwardDiff(; chunksize = ck)
-    return GeneralizedFirstOrderAlgorithm{CJ, N}(; solver.descent, solver.linesearch,
-        solver.trustregion, jacobian_ad = ad, solver.max_shrink_times, solver.forward_ad,
-        solver.reverse_ad)
-end
-function __set_ad_chunksize(solver::SimpleNewtonRaphson, ck)
-    solver.autodiff === nothing || return solver
-    autodiff = AutoForwardDiff(; chunksize = ck)
-    return SimpleNewtonRaphson(; autodiff)
-end
-function __set_ad_chunksize(solver::SimpleTrustRegion, ck)
-    solver.autodiff === nothing || return solver
-    autodiff = AutoForwardDiff(; chunksize = ck)
-    return SimpleTrustRegion(; autodiff)
-end
-__set_ad_chunksize(solver, _) = solver
-
 function benchmark_combinations(solvers, probs)
     return map(Iterators.product(solvers, probs)) do (solver, prob)
         try
-            solver_concrete = prob.u0 isa SArray ? solver.solver[:alg] :
-                __set_ad_chunksize(solver.solver[:alg],
-                    min(NonlinearSolve.pickchunksize(prob.u0), 6))
-
-            sol = solve(prob, solver_concrete; abstol = 1e-10, reltol = 1e-10,
+            alg = solver.solver[:alg]
+            sol = solve(prob, alg; abstol = 1e-10, reltol = 1e-10,
                 maxiters = 1000, termination_condition = AbsNormTerminationMode())
             @info "Solver $(solver.name) successfully solved the problem with norm = \
                 $(norm(sol.resid, Inf))."
 
             if norm(sol.resid, Inf) ≤ 1e-10
-                tt = @belapsed solve($prob, $solver_concrete; abstol = 1e-10,
+                tt = @belapsed solve($prob, $alg; abstol = 1e-10,
                     reltol = 1e-10, maxiters = 1000)
                 @info "Solver $(solver.name) took $(tt) seconds."
                 return tt
             else
                 return NaN
             end
         catch e
-            @error "Solver $(solver.name) threw an error."
+            @error "Solver $(solver.name) threw an error." err=e
             return NaN
         end
     end
@@ -299,14 +278,14 @@ fig = begin
 
         ax = Axis(fig[1, i];
             ylabel = "",
-            title = L"N = %$(length(probs_sa[i].u0))$",
+            title = L"N = %$(length(probs_sa[i].u0))%$",
             titlegap = 10, xticksvisible = false, yticksvisible = true,
             xticklabelsvisible = false, yticklabelsvisible = true, titlesize = 22,
             spinewidth = STROKEWIDTH, xlabelsize = 22, ylabelsize = 22,
             xticklabelrotation = π / 4, xticklabelsize = 20, yticklabelsize = 20)
         axs[1, i] = ax
 
-        barplot!(ax, xs, ys; dogde = dodge, color = dodge, colormap = :seaborn_bright,
+        barplot!(ax, xs, ys; dodge, color = dodge, colormap = :seaborn_bright,
             strokewidth = 2)
 
         hlines!(ax, [1.0], color = :black, linestyle = :dash, linewidth = 2)
@@ -324,15 +303,15 @@ fig = begin
 
         ax = Axis(fig[2, i];
             ylabel = "",
-            title = L"N = %$(length(probs_reg[i].u0))$",
+            title = L"N = %$(length(probs_reg[i].u0))%$",
             titlegap = 10, xticksvisible = true, yticksvisible = true,
             xticklabelsvisible = true, yticklabelsvisible = true, titlesize = 22,
             spinewidth = STROKEWIDTH, xlabelsize = 22, ylabelsize = 22,
             xticks = (1:length(df_sa), [d.first for d in df_sa]),
             xticklabelrotation = π / 4, xticklabelsize = 20, yticklabelsize = 20)
         axs[1, i] = ax
 
-        barplot!(ax, xs, ys; color = dodge, dodge = dodge, colormap = :seaborn_bright,
+        barplot!(ax, xs, ys; dodge, color = dodge, colormap = :seaborn_bright,
             strokewidth = 3)
 
         hlines!(ax, [1.0], color = :black, linestyle = :dash, linewidth = 3)