fix isinplace inference and add inference tests

Author: oscardssmith

src/problems/optimization_problems.jl

@@ -131,8 +131,7 @@ function OptimizationProblem(
     OptimizationProblem{isinplace(f)}(f, args...; kwargs...)
 end
 function OptimizationProblem(f, args...; kwargs...)
-    isinplace(f, 2, has_two_dispatches = false)
-    OptimizationProblem{true}(OptimizationFunction{true}(f), args...; kwargs...)
+    OptimizationProblem(OptimizationFunction(f), args...; kwargs...)
 end
 
 function OptimizationFunction(

src/scimlfunctions.jl

@@ -4199,7 +4199,10 @@ IntervalNonlinearFunction(f::IntervalNonlinearFunction; kwargs...) = f
 struct NoAD <: AbstractADType end
 
 (f::OptimizationFunction)(args...) = f.f(args...)
-OptimizationFunction(args...; kwargs...) = OptimizationFunction{true}(args...; kwargs...)
+function OptimizationFunction(f, args...; kwargs...)
+    isinplace(f, 2, outofplace_param_number=2)
+    OptimizationFunction{true}(f, args...; kwargs...)
+end
 
 function OptimizationFunction{iip}(f, adtype::AbstractADType = NoAD();
         grad = nothing, fg = nothing, hess = nothing, hv = nothing, fgh = nothing,
@@ -4251,8 +4254,9 @@ end
 (f::MultiObjectiveOptimizationFunction)(args...) = f.f(args...)
 
 # Convenience constructor
-function MultiObjectiveOptimizationFunction(args...; kwargs...)
-    MultiObjectiveOptimizationFunction{true}(args...; kwargs...)
+function MultiObjectiveOptimizationFunction(f, args...; kwargs...)
+    isinplace(f, 2, outofplace_param_number=2)
+    MultiObjectiveOptimizationFunction{true}(f, args...; kwargs...)
 end
 
 # Constructor with keyword arguments
@@ -4339,15 +4343,17 @@ function BVPFunction{iip, specialize, twopoint}(f, bc;
         if iip_f
             jac = update_coefficients! #(J,u,p,t)
         else
-            jac = (u, p, t) -> update_coefficients!(deepcopy(jac_prototype), u, p, t)
+            jac_prototype_copy = deepcopy(jac_prototype)
+            jac = (u, p, t) -> update_coefficients!(jac_prototype_copy, u, p, t)
         end
     end
 
     if bcjac === nothing && isa(bcjac_prototype, AbstractSciMLOperator)
         if iip_bc
             bcjac = update_coefficients! #(J,u,p,t)
         else
-            bcjac = (u, p, t) -> update_coefficients!(deepcopy(bcjac_prototype), u, p, t)
+            bcjac_prototype_copy = deepcopy(bcjac_prototype)
+            bcjac = (u, p, t) -> update_coefficients!(bcjac_prototype_copy, u, p, t)
         end
     end
 
@@ -4512,15 +4518,17 @@ function DynamicalBVPFunction{iip, specialize, twopoint}(f, bc;
         if iip_f
             jac = update_coefficients! #(J,u,p,t)
         else
-            jac = (u, p, t) -> update_coefficients!(deepcopy(jac_prototype), u, p, t)
+            jac_prototype_copy = deepcopy(jac_prototype)
+            jac = (u, p, t) -> update_coefficients!(jac_prototype_copy, u, p, t)
         end
     end
 
     if bcjac === nothing && isa(bcjac_prototype, AbstractSciMLOperator)
         if iip_bc
             bcjac = update_coefficients! #(J,u,p,t)
         else
-            bcjac = (u, p, t) -> update_coefficients!(deepcopy(bcjac_prototype), u, p, t)
+            bcjac_prototype_copy = deepcopy(jac_prototype)
+            bcjac = (u, p, t) -> update_coefficients!(bcjac_prototype_copy, u, p, t)
         end
     end
 

test/aqua.jl

@@ -29,7 +29,7 @@ end
     # for method_ambiguity in ambs
     #     @show method_ambiguity
     # end
-    @warn "Number of method ambiguities: $(length(ambs))"
+    !isempty(ambs) &&@warn "Number of method ambiguities: $(length(ambs))"
     @test length(ambs) ≤ 8
 end