Update tests to LBFGSB

Author: ChrisRackauckas

lib/OptimizationBase/test/cvxtest.jl

@@ -1,5 +1,5 @@
 using Optimization, OptimizationBase, ForwardDiff, SymbolicAnalysis, LinearAlgebra,
-      Manifolds, OptimizationManopt
+      Manifolds, OptimizationManopt, OptimizationLBFGSB
 
 function f(x, p = nothing)
     return exp(x[1]) + x[1]^2
@@ -8,7 +8,7 @@ end
 optf = OptimizationFunction(f, Optimization.AutoForwardDiff())
 prob = OptimizationProblem(optf, [0.4], structural_analysis = true)
 
-@time sol = solve(prob, Optimization.LBFGS(), maxiters = 1000)
+@time sol = solve(prob, OptimizationLBFGSB.LBFGSB(), maxiters = 1000)
 @test sol.cache.analysis_results.objective.curvature == SymbolicAnalysis.Convex
 @test sol.cache.analysis_results.constraints === nothing
 
@@ -18,7 +18,7 @@ l1 = rosenbrock(x0)
 
 optf = OptimizationFunction(rosenbrock, AutoEnzyme())
 prob = OptimizationProblem(optf, x0, structural_analysis = true)
-@time res = solve(prob, Optimization.LBFGS(), maxiters = 100)
+@time res = solve(prob, OptimizationLBFGSB.LBFGSB(), maxiters = 100)
 @test res.cache.analysis_results.objective.curvature == SymbolicAnalysis.UnknownCurvature
 
 function con2_c(res, x, p)
@@ -28,7 +28,7 @@ end
 optf = OptimizationFunction(rosenbrock, AutoZygote(), cons = con2_c)
 prob = OptimizationProblem(optf, x0, lcons = [1.0, -Inf], ucons = [1.0, 0.0],
     lb = [-1.0, -1.0], ub = [1.0, 1.0], structural_analysis = true)
-@time res = solve(prob, Optimization.LBFGS(), maxiters = 100)
+@time res = solve(prob, OptimizationLBFGSB.LBFGSB(), maxiters = 100)
 @test res.cache.analysis_results.objective.curvature == SymbolicAnalysis.UnknownCurvature
 @test res.cache.analysis_results.constraints[1].curvature == SymbolicAnalysis.Convex
 @test res.cache.analysis_results.constraints[2].curvature ==

lib/OptimizationNLPModels/test/runtests.jl

@@ -1,6 +1,5 @@
 using OptimizationNLPModels, Optimization, NLPModelsTest, Ipopt, OptimizationMOI, Zygote,
-      ReverseDiff,
-      OptimizationOptimJL
+      ReverseDiff, OptimizationLBFGSB, OptimizationOptimJL
 using Test
 
 @testset "NLPModels" begin
@@ -18,8 +17,8 @@ using Test
     nlpmo = NLPModelsTest.HS5()
     converted = OptimizationNLPModels.OptimizationProblem(nlpmo, Optimization.AutoZygote())
 
-    sol_native = solve(oprob, Optimization.LBFGS(), maxiters = 1000)
-    sol_converted = solve(converted, Optimization.LBFGS(), maxiters = 1000)
+    sol_native = solve(oprob, OptimizationLBFGSB.LBFGSB(), maxiters = 1000)
+    sol_converted = solve(converted, OptimizationLBFGSB.LBFGSB(), maxiters = 1000)
 
     @test sol_converted.retcode == sol_native.retcode
     @test sol_converted.u ≈ sol_native.u