cleanup

Author: SebastianM-C

lib/OptimizationGCMAES/src/OptimizationGCMAES.jl

@@ -48,12 +48,8 @@ function __map_optimizer_args(cache::OptimizationBase.OptimizationCache, opt::GC
 end
 
 function SciMLBase.__init(prob::SciMLBase.OptimizationProblem,
-        opt::GCMAESOpt; σ0 = 0.2,
-        callback = (args...) -> (false),
-        progress = false, kwargs...)
-    return OptimizationCache(prob, opt; σ0 = σ0, callback = callback,
-        progress = progress,
-        kwargs...)
+        opt::GCMAESOpt; σ0 = 0.2, kwargs...)
+    return OptimizationCache(prob, opt; σ0 = σ0, kwargs...)
 end
 
 function SciMLBase.__solve(cache::OptimizationCache{O}) where {O <: GCMAESOpt}

lib/OptimizationIpopt/src/OptimizationIpopt.jl

@@ -256,7 +256,8 @@ function __map_optimizer_args(cache,
     )
 
     # Set up progress callback
-    progress_callback = IpoptProgressLogger(progress, callback, prob, cache.n, cache.num_cons, maxiters, cache.iterations)
+    progress_callback = IpoptProgressLogger(
+        progress, callback, prob, cache.n, cache.num_cons, maxiters, cache.iterations)
     intermediate = (args...) -> progress_callback(args...)
     Ipopt.SetIntermediateCallback(prob, intermediate)
 

lib/OptimizationMadNLP/src/OptimizationMadNLP.jl

@@ -345,7 +345,7 @@ function __map_optimizer_args(cache,
     nvar = length(cache.u0)
     ncon = !isnothing(cache.lcons) ? length(cache.lcons) : 0
 
-    if callback !== DEFAULT_CALLBACK || progress
+    if !(callback isa OptimizationBase.NullCallback) || progress
         @warn("MadNLP doesn't currently support user defined callbacks.")
     end
     # TODO: add support for user callbacks in MadNLP
@@ -376,7 +376,7 @@ function __map_optimizer_args(cache,
         print_level = verbose
     end
 
-    !isnothing(reltol) && @warn "reltol not supported by MadNLP."
+    !isnothing(reltol) && @warn "reltol not supported by MadNLP, use abstol instead."
     tol = isnothing(abstol) ? 1e-8 : abstol
     max_iter = isnothing(maxiters) ? 3000 : maxiters
     max_wall_time = isnothing(maxtime) ? 1e6 : maxtime

lib/OptimizationMadNLP/test/runtests.jl

@@ -2,6 +2,7 @@ using OptimizationMadNLP
 using OptimizationBase
 using MadNLP
 using Test
+using ADTypes
 import Zygote, ForwardDiff, ReverseDiff
 using SparseArrays
 using DifferentiationInterface: SecondOrder