Merge pull request #449 from SciML/ap/extra_warning

Don't warn if user specified FiniteDifferencing

Author: ChrisRackauckas

Project.toml

@@ -1,7 +1,7 @@
 name = "NonlinearSolve"
 uuid = "8913a72c-1f9b-4ce2-8d82-65094dcecaec"
 authors = ["SciML"]
-version = "3.12.4"
+version = "3.12.5"
 
 [deps]
 ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"

src/internal/helpers.jl

@@ -57,7 +57,9 @@ end
 function get_concrete_reverse_ad(
         autodiff::ADTypes.AbstractADType, prob, sp::Val{test_sparse} = True,
         args...; check_reverse_mode = true, kwargs...) where {test_sparse}
-    if !isa(ADTypes.mode(autodiff), ADTypes.ReverseMode) && check_reverse_mode
+    if !isa(ADTypes.mode(autodiff), ADTypes.ReverseMode) &&
+       !isa(autodiff, ADTypes.AutoFiniteDiff) && # User specified finite differencing
+       check_reverse_mode
         @warn "$(autodiff)::$(typeof(autodiff)) is not a `ReverseMode`. Use with caution." maxlog=1
     end
     if autodiff isa Union{AutoZygote, AutoSparse{<:AutoZygote}} && isinplace(prob)

test/downstream/mtk_cache_indexing_tests.jl

@@ -11,10 +11,9 @@
     nlprob = NonlinearProblem(nlsys, [X => 1.0], [p => 2.0, d => 3.0])
 
     @testset "$integtype" for (alg, integtype) in [
-            (NewtonRaphson(), NonlinearSolve.GeneralizedFirstOrderAlgorithmCache),
-            (FastShortcutNonlinearPolyalg(), NonlinearSolve.NonlinearSolvePolyAlgorithmCache),
-            (SimpleNewtonRaphson(), NonlinearSolve.NonlinearSolveNoInitCache),
-        ]
+        (NewtonRaphson(), NonlinearSolve.GeneralizedFirstOrderAlgorithmCache),
+        (FastShortcutNonlinearPolyalg(), NonlinearSolve.NonlinearSolvePolyAlgorithmCache),
+        (SimpleNewtonRaphson(), NonlinearSolve.NonlinearSolveNoInitCache)]
         nint = init(nlprob, alg)
         @test nint isa integtype
 

test/misc/other_tests.jl

@@ -0,0 +1,10 @@
+@testitem "No warning tests" tags=[:misc] begin
+    using NonlinearSolve
+
+    f(u, p) = u .* u .- p
+    u0 = [1.0, 1.0]
+    p = 2.0
+    prob = NonlinearProblem(f, u0, p)
+    @test_nowarn solve(
+        prob, NewtonRaphson(autodiff = AutoFiniteDiff(), linesearch = LineSearchesJL()))
+end