form and test

Author: rayegun

src/factorization.jl

@@ -397,31 +397,29 @@ end
 
 @static if VERSION < v"1.7beta"
     function init_cacheval(alg::FastQRFactorization{Val{false}}, A, b, u, Pl, Pr,
-        maxiters, abstol, reltol, verbose)
+                           maxiters, abstol, reltol, verbose)
         ws = QRWYWs(A; blocksize = alg.blocksize)
         return WorkspaceAndFactors(ws, LinearAlgebra.QRCompactWY(LAPACK.geqrt!(ws, A)...))
     end
 
     function init_cacheval(::FastQRFactorization{Val{true}}, A, b, u, Pl, Pr,
-        maxiters, abstol, reltol, verbose)
+                           maxiters, abstol, reltol, verbose)
         ws = QRpWs(A)
         return WorkspaceAndFactors(ws, LinearAlgebra.QRPivoted(LAPACK.geqp3!(ws, A)...))
     end
 else
     function init_cacheval(alg::FastQRFactorization{NoPivot}, A, b, u, Pl, Pr,
-        maxiters, abstol, reltol, verbose)
+                           maxiters, abstol, reltol, verbose)
         ws = QRWYWs(A; blocksize = alg.blocksize)
         return WorkspaceAndFactors(ws, LinearAlgebra.QRCompactWY(LAPACK.geqrt!(ws, A)...))
     end
     function init_cacheval(::FastQRFactorization{ColumnNorm}, A, b, u, Pl, Pr,
-        maxiters, abstol, reltol, verbose)
+                           maxiters, abstol, reltol, verbose)
         ws = QRpWs(A)
         return WorkspaceAndFactors(ws, LinearAlgebra.QRPivoted(LAPACK.geqp3!(ws, A)...))
     end
 end
 
-
-
 function SciMLBase.solve(cache::LinearCache, alg::FastQRFactorization{P}) where {P}
     A = cache.A
     A = convert(AbstractMatrix, A)

test/basictests.jl

@@ -119,6 +119,24 @@ end
         @test_throws ArgumentError solve(cache)
     end
 
+    @testset "FastLAPACK Factorizations" begin
+        A1 = A / 1
+        b1 = rand(n)
+        x1 = zero(b)
+        A2 = A / 2
+        b2 = rand(n)
+        x2 = zero(b)
+
+        prob1 = LinearProblem(A1, b1; u0 = x1)
+        prob2 = LinearProblem(A2, b2; u0 = x2)
+        test_interface(LinearSolve.FastLUFactorization(), prob1, prob2)
+        test_interface(LinearSolve.FastQRFactorization(), prob1, prob2)
+        
+        # TODO: Resizing tests. Upstream doesn't currently support it.
+        # Need to be absolutely certain we never segfault with incorrect
+        # ws sizes.
+    end
+
     @testset "Concrete Factorizations" begin for alg in (LUFactorization(),
                                                          QRFactorization(),
                                                          SVDFactorization(),