Merge pull request #634 from SciML/retcodes2

Fix retcodes on staticarray overloads

Author: ChrisRackauckas

src/common.jl

@@ -309,24 +309,8 @@ end
 
 function SciMLBase.solve(prob::StaticLinearProblem,
         alg::Nothing, args...; kwargs...)
-    if alg === nothing || alg isa DirectLdiv!
-        u = prob.A \ prob.b
-    elseif alg isa LUFactorization
-        u = lu(prob.A) \ prob.b
-    elseif alg isa QRFactorization
-        u = qr(prob.A) \ prob.b
-    elseif alg isa CholeskyFactorization
-        u = cholesky(prob.A) \ prob.b
-    elseif alg isa NormalCholeskyFactorization
-        u = cholesky(Symmetric(prob.A' * prob.A)) \ (prob.A' * prob.b)
-    elseif alg isa SVDFactorization
-        u = svd(prob.A) \ prob.b
-    else
-        # Slower Path but handles all cases
-        cache = init(prob, alg, args...; kwargs...)
-        return solve!(cache)
-    end
-    return SciMLBase.build_linear_solution(alg, u, nothing, prob)
+    u = prob.A \ prob.b
+    return SciMLBase.build_linear_solution(alg, u, nothing, prob; retcode = ReturnCode.Success)
 end
 
 function SciMLBase.solve(prob::StaticLinearProblem,
@@ -348,5 +332,5 @@ function SciMLBase.solve(prob::StaticLinearProblem,
         cache = init(prob, alg, args...; kwargs...)
         return solve!(cache)
     end
-    return SciMLBase.build_linear_solution(alg, u, nothing, prob)
+    return SciMLBase.build_linear_solution(alg, u, nothing, prob; retcode = ReturnCode.Success)
 end

test/retcodes.jl

@@ -1,4 +1,4 @@
-using LinearSolve, LinearAlgebra, RecursiveFactorization, Test
+using LinearSolve, LinearAlgebra, RecursiveFactorization, StaticArrays, Test
 
 alglist = (
     LUFactorization,
@@ -69,3 +69,26 @@ rankdeficientalgs = (
         @test SciMLBase.successful_retcode(sol.retcode)
     end
 end
+
+staticarrayalgs = (
+    DirectLdiv!(),
+    LUFactorization(),
+    CholeskyFactorization(),
+    NormalCholeskyFactorization(),
+    SVDFactorization()
+)
+@testset "StaticArray Success" begin
+    A = Float64[1 2 3; 4 3.5 1.7; 5.2 1.8 9.7]
+    A = A*A'
+    b = Float64[2, 5, 8]
+    prob1 = LinearProblem(SMatrix{3, 3}(A), SVector{3}(b))
+    sol = solve(prob1)
+    @test SciMLBase.successful_retcode(sol.retcode)
+
+    for alg in staticarrayalgs
+        sol = solve(prob1, alg)
+        @test SciMLBase.successful_retcode(sol.retcode)
+    end
+
+    @test_broken sol = solve(prob1, QRFactorization()) # Needs StaticArrays `qr` fix
+end