Merge pull request #295 from thomvet/main

Attempt to close #293

Author: ChrisRackauckas

src/factorization.jl

@@ -310,17 +310,6 @@ end
 
 # Fallback, tries to make nonsingular and just factorizes
 # Try to never use it.
-function init_cacheval(alg::GenericFactorization,
-                       A, b, u, Pl, Pr, maxiters::Int, abstol, reltol, verbose::Bool,
-                       assumptions::OperatorAssumptions)
-    newA = copy(convert(AbstractMatrix, A))
-    if newA isa AbstractSparseMatrix
-        fill!(nonzeros(newA), true)
-    else
-        fill!(newA, true)
-    end
-    do_factorization(alg, newA, b, u)
-end
 
 # Cholesky needs the posdef matrix, for GenericFactorization assume structure is needed
 function init_cacheval(alg::Union{GenericFactorization,
@@ -333,15 +322,6 @@ function init_cacheval(alg::Union{GenericFactorization,
 end
 
 # Ambiguity handling dispatch
-function init_cacheval(alg::Union{GenericFactorization,
-                                  GenericFactorization{typeof(cholesky)},
-                                  GenericFactorization{typeof(cholesky!)}},
-                       A::StridedMatrix{<:LinearAlgebra.BlasFloat}, b, u, Pl, Pr,
-                       maxiters::Int,
-                       abstol, reltol, verbose::Bool, assumptions::OperatorAssumptions)
-    newA = copy(convert(AbstractMatrix, A))
-    do_factorization(alg, newA, b, u)
-end
 
 ################################## Factorizations which require solve overloads
 

test/basictests.jl

@@ -39,6 +39,7 @@ function test_interface(alg, prob1, prob2)
     sol = solve(cache; cache_kwargs...)
     @test A2 * sol.u ≈ b1
 
+    cache = LinearSolve.set_A(cache, A2)
     cache = LinearSolve.set_b(cache, b2)
     sol = solve(cache; cache_kwargs...)
     @test A2 * sol.u ≈ b2
@@ -208,7 +209,7 @@ end
                                                              qr, qr!,
                                                              cholesky,
                                                              #cholesky!,
-                                                             #                ldlt, ldlt!,
+                                                             #ldlt, ldlt!,
                                                              bunchkaufman, bunchkaufman!,
                                                              lq, lq!,
                                                              svd, svd!,

test/runtests.jl

@@ -18,8 +18,6 @@ function activate_subpkg_env(subpkg)
     Pkg.instantiate()
 end
 
-@show GROUP, GROUP == "LinearSolvePardiso"
-
 if GROUP == "All" || GROUP == "Core"
     @time @safetestset "Basic Tests" begin include("basictests.jl") end
     @time @safetestset "Zero Initialization Tests" begin include("zeroinittests.jl") end