mark test_broken

Author: xtalax

src/derivative_operators/BC_operators.jl

@@ -1,6 +1,6 @@
 abstract type AbstractBC{T} end
 
-# robin, general, and in general neumann BCs are all affine opeartors, meaning that they take the form Qx = Qax + Qb. neumann0 is not however; is a specialization needed?
+# Robin, General, and in general Neumann and Dirichlet BCs are all affine opeartors, meaning that they take the form Qx = Qax + Qb.
 abstract type AffineBC{T,V} <: AbstractBC{T} end
 
 struct PeriodicBC{T} <: AbstractBC{T}
@@ -83,14 +83,13 @@ struct GeneralBC{T, V<:AbstractVector{T}} <:AffineBC{T,V}
     end
 end
 
+#implement Neumann and Dirichlet as special cases of RobinBC
 NeumannBC([l::T, r::T], [dx_l,dx_r], order) where T = RobinBC([zero(T), one(T), l], [zero(T), one(T), r], [dx_l,dx_r], order)
 NeumannBC([l::T, r::T], [dx_l,dx_r]) where T = RobinBC([zero(T), one(T), l], [zero(T), one(T), r], [dx_l,dx_r])
 
 DirichletBC([l::T, r::T], [dx_l,dx_r], order) where T = RobinBC([one(T), zero(T), l], [one(T), zero(T), r], [dx_l,dx_r], order)
 DirichletBC([l::T, r::T], [dx_l,dx_r]) where T = RobinBC([one(T), zero(T), l], [one(T), zero(T), r], [dx_l,dx_r])
 
-
-
 # other acceptable argument signatures
 RobinBC(al::T, bl::T, cl::T, dx_l::T, ar::T, br::T, cr::T, dx_r::T) where T = RobinBC([al,bl,cl], [ar, br, cr], [dx_l, dx_r])
 RobinBC(al::T, bl::T, cl::T, dx_l::T, ar::T, br::T, cr::T, dx_r::T, order::T) where T = RobinBC([al,bl,cl], [ar, br, cr], [dx_l, dx_r], order)

test/generic_operator_validation.jl

@@ -16,29 +16,29 @@ for dor in 1:6, aor in 1:8
     D1 = DerivativeOperator{Float64}(dor,aor,dx[1],length(x))
     D2 = DiffEqOperators.FiniteDifference{Float64}(dor,aor,dx,length(x))
     D = (D1,D2)
-    @test convert(Array, D1) ≈ convert(Array, D2)
+    @test_broken convert(Array, D1) ≈ convert(Array, D2)
 
     #take derivatives
     yprime1 = D1*y
     yprime2 = D2*y
 
     #test result
-    @test yprime1 ≈ (π^dor)*y_ # test operator with known derivative of exp(kx)
-    @test yprime2 ≈ (π^dor)*y_ # test operator with known derivative of exp(kx)
+    @test_broken yprime1 ≈ (π^dor)*y_ # test operator with known derivative of exp(kx)
+    @test_broken yprime2 ≈ (π^dor)*y_ # test operator with known derivative of exp(kx)
 
     #test equivalance
-    @test yprime1 ≈ yprime2
+    @test_broken yprime1 ≈ yprime2
 
     #take derivatives
     y_imprime1 = D1*y_im
     y_imprime2 = D2*y_im
 
     #test result
-    @test y_imprime1 ≈ ((pi*im)^dor)*yim_ # test operator with known derivative of exp(jkx)
-    @test y_imprime2 ≈ ((pi*im)^dor)*yim_ # test operator with known derivative of exp(jkx)
+    @test_broken y_imprime1 ≈ ((pi*im)^dor)*yim_ # test operator with known derivative of exp(jkx)
+    @test_broken y_imprime2 ≈ ((pi*im)^dor)*yim_ # test operator with known derivative of exp(jkx)
 
     #test equivalance
-    @test y_imprime1 ≈ y_imprime2
+    @test_broken y_imprime1 ≈ y_imprime2
 
     #TODO: implement specific tests for the left and right boundary regions, waiting until after update
     end

test/runtests.jl

@@ -6,7 +6,7 @@ import Base: isapprox
 @time @safetestset "JacVec Operators Interface" begin include("jacvec_operators.jl") end
 @time @safetestset "Composite Operators Interface" begin include("composite_operators_interface.jl") end
 @time @safetestset "Derivative Operators Interface" begin include("derivative_operators_interface.jl") end
-#@time @safetestset "Validate and Compare Generic Operators" begin include("generic_operator_validation.jl") end
+@time @safetestset "Validate and Compare Generic Operators" begin include("generic_operator_validation.jl") end
 #@time @safetestset "2nd order check" begin include("2nd_order_check.jl") end
 #@time @safetestset "KdV" begin include("KdV.jl") end # KdV times out and all fails
 #@time @safetestset "Heat Equation" begin include("heat_eqn.jl") end