add tests

Author: ChrisRackauckas

src/derivative_operators/BC_operators.jl

@@ -1,4 +1,4 @@
-abstract type AbstractBC{T} end
+abstract type AbstractBC{T} <: AbstractDiffEqLinearOperator{T} end
 
 """
 Robin, General, and in general Neumann and Dirichlet BCs are all affine opeartors, meaning that they take the form Qx = Qax + Qb.
@@ -92,13 +92,13 @@ DirichletBC(α::AbstractVector{T}, dx::AbstractVector{T}, order = 1) where T = R
 RobinBC(al::T, bl::T, cl::T, dx_l::T, ar::T, br::T, cr::T, dx_r::T, order = 1) where T = RobinBC([al,bl, cl], [ar, br, cr], [dx_l, dx_r], order)
 
 # this  is 'boundary padded vector' as opposed to 'boundary padded array' to distinguish it from the n dimensional implementation that will eventually be neeeded
-struct BoundaryPaddedVector{T,T2 <: AbstractVector{T}}
+struct BoundaryPaddedVector{T,T2 <: AbstractVector{T}} <: AbstractVector{T}
     l::T
     r::T
     u::T2
 end
 
-Base.:*(Q::AffineBC, u) = BoundaryPaddedVector(Q.a_l ⋅ u[1:length(Q.a_l)] + Q.b_l, Q.a_r ⋅ u[(end-length(Q.a_r)+1):end] + Q.b_r, u)
+Base.:*(Q::AffineBC, u::AbstractVector) = BoundaryPaddedVector(Q.a_l ⋅ u[1:length(Q.a_l)] + Q.b_l, Q.a_r ⋅ u[(end-length(Q.a_r)+1):end] + Q.b_r, u)
 
 Base.size(Q::AbstractBC) = (Inf, Inf) #Is this nessecary?
 Base.length(Q::BoundaryPaddedVector) = length(Q.u) + 2
@@ -139,4 +139,14 @@ function LinearAlgebra.Array(Q::BoundaryPaddedVector)
     return [Q.l; Q.u; Q.r]
 end
 
-#TODO: Implement Sparse concretization
+function Base.convert(::Type{Array},A::AbstractBC{T}) where T
+    Array(A)
+end
+
+function Base.convert(::Type{SparseMatrixCSC},A::AbstractBC{T}) where T
+    SparseMatrixCSC(A)
+end
+
+function Base.convert(::Type{AbstractMatrix},A::AbstractBC{T}) where T
+    SparseMatrixCSC(A)
+end

test/bc_coeff_compositions.jl

@@ -0,0 +1,34 @@
+using LinearAlgebra, DiffEqOperators, Random, Test, BandedMatrices
+
+# Generate random parameters
+al = rand()
+bl = rand()
+cl = rand()
+dx_l = rand()
+ar = rand()
+br = rand()
+cr = rand()
+dx_r = rand()
+
+Q = RobinBC(al, bl, cl, dx_l, ar, br, cr, dx_r)
+N = 20
+L = CenteredDifference(4,4, 1.0, N)
+L2 = CenteredDifference(2,4, 1.0, N)
+
+function coeff_func(du,u,p,t)
+  du .= u
+end
+
+cL = coeff_func*L
+coeffs = rand(N)
+DiffEqOperators.update_coefficients!(cL,coeffs,nothing,0.0)
+
+@test cL.coefficients == coeffs
+
+# Fails
+u = rand(20)
+@test_broken LQ = L*Q
+@test_broken LQ*u ≈ L*(Q*u)
+
+u = rand(22)
+@test (L + L2) * u ≈ convert(AbstractMatrix,L + L2) * u ≈ (BandedMatrix(L) + BandedMatrix(L2)) * u

test/derivative_operators_interface.jl

@@ -183,7 +183,6 @@ end
 end
 
 @testset "Linear combinations of operators" begin
-    # Only tests the additional functionality defined in "operator_combination.jl"
     N = 10
     Random.seed!(0); LA = DiffEqArrayOperator(rand(N,N+2))
     LD = CenteredDifference(2,2,1.0,N)

test/runtests.jl

@@ -5,6 +5,7 @@ import Base: isapprox
 @time @safetestset "Robin Boundary Condition Operators" begin include("robin.jl") end
 @time @safetestset "JacVec Operators Interface" begin include("jacvec_operators.jl") end
 @time @safetestset "Composite Operators Interface" begin include("composite_operators_interface.jl") end
+@time @safetestset "BC and Coefficient Compositions" begin include("bc_coeff_compositions.jl")
 @time @safetestset "Derivative Operators Interface" begin include("derivative_operators_interface.jl") end
 @time @safetestset "Validate and Compare Generic Operators" begin include("generic_operator_validation.jl") end
 #@time @safetestset "2nd order check" begin include("2nd_order_check.jl") end