concretization tests and fixed BandedMatrix initialization and convolve_right_BC

Author: ajozefiak

src/DiffEqOperators.jl

@@ -30,6 +30,7 @@ include("derivative_operators/derivative_irreg_operator.jl")
 include("derivative_operators/derivative_operator.jl")
 include("derivative_operators/abstract_operator_functions.jl")
 include("derivative_operators/convolutions.jl")
+include("derivative_operators/concretization.jl")
 
 ### Composite Operators
 include("composite_operators.jl")

src/derivative_operators/concretization.jl

@@ -43,7 +43,7 @@ function BandedMatrices.BandedMatrix(A::DerivativeOperator{T}) where T
     bl = A.boundary_length
     stl = A.stencil_length
     stl_2 = div(stl,2)
-    L = BandedMatrix{T}(undef, (N, N+2), (max(stl-3,0),max(stl-1,0)))
+    L = BandedMatrix{T}(Zeros(N, N+2), (max(stl-3,0),max(stl-1,0)))
     for i in 1:A.boundary_length
         L[i,1:stl] = A.low_boundary_coefs[i]
     end

src/derivative_operators/convolutions.jl

@@ -37,7 +37,7 @@ function convolve_BC_right!(x_temp::AbstractVector{T}, x::AbstractVector{T}, A::
     coeffs = A.high_boundary_coefs
     Threads.@threads for i in 1 : A.boundary_length
         xtempi = coeffs[i][end]*x[end]
-        @inbounds for idx in A.stencil_length:-1:1
+        @inbounds for idx in A.stencil_length-1:-1:1
             xtempi += coeffs[i][end-idx] * x[end-idx]
         end
         x_temp[end-A.boundary_length+i] = xtempi

test/derivative_operators_interface.jl

@@ -1,4 +1,4 @@
-using SparseArrays, DiffEqOperators, LinearAlgebra, Random, Test
+using SparseArrays, DiffEqOperators, LinearAlgebra, Random, Test, BandedMatrices
 
 function second_derivative_stencil(N)
   A = zeros(N,N+2)
@@ -30,15 +30,37 @@ end
     N = 10
     d_order = 2
     approx_order = 2
-    x = collect(1:1.0:N).^2
     correct = second_derivative_stencil(N)
     A = DerivativeOperator{Float64}(d_order,approx_order,1.0,N)
 
     @test convert_by_multiplication(Array,A,N) == correct
-    @test_broken Array(A) == second_derivative_stencil(N)
-    @test_broken sparse(A) == second_derivative_stencil(N)
+    @test Array(A) == second_derivative_stencil(N)
+    @test sparse(A) == second_derivative_stencil(N)
+    @test BandedMatrix(A) == second_derivative_stencil(N)
     @test_broken opnorm(A, Inf) == opnorm(correct, Inf)
 
+
+    # testing higher derivative and approximation concretization
+    N = 20
+    d_order = 4
+    approx_order = 4
+    A = DerivativeOperator{Float64}(d_order,approx_order,1.0,N)
+    correct = convert_by_multiplication(Array,A,N)
+
+    @test Array(A) == correct
+    @test sparse(A) == correct
+    @test BandedMatrix(A) == correct
+
+    N = 40
+    d_order = 8
+    approx_order = 8
+    A = DerivativeOperator{Float64}(d_order,approx_order,1.0,N)
+    correct = convert_by_multiplication(Array,A,N)
+
+    @test Array(A) == correct
+    @test sparse(A) == correct
+    @test BandedMatrix(A) == correct
+
     # testing correctness of multiplication
     N = 1000
     d_order = 4