Skip to content

Commit f09012e

Browse files
authored
Fix test for Cholesky factorization conversion (#211)
* Fix test for Cholesky factorization conversion * Update Julia versions for tests * Fix test for Cholesky factorization conversion * Update Julia versions for tests * Remove the cholesky test because its already converted
1 parent 97eb9e3 commit f09012e

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
matrix:
1717
version:
1818
- '1.6'
19-
- '1.7'
19+
- '1.8'
2020
- '1' # Leave this line unchanged. '1' will automatically expand to the latest stable 1.x release of Julia.
2121
os:
2222
- ubuntu-latest

test/runtests.jl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -617,10 +617,6 @@ end
617617
@test typeof(zrv0) === typeof(rv0)
618618
@test typeof(zrv0.r[1]) == typeof(rv0[1])
619619

620-
# Issue #100
621-
chol = cholesky(cmat + I)
622-
@test convert(Cholesky{Float32,Matrix{Float32}}, chol).factors isa Matrix{Float32}
623-
624620
# Issue #140
625621
@test ComponentArrays.ArrayInterface.indices_do_not_alias(typeof(ca)) == true
626622
@test ComponentArrays.ArrayInterface.instances_do_not_alias(typeof(ca)) == false

0 commit comments

Comments
 (0)