Error on duplicate symbols for Axis. Fixes #130

Author: jonniedie

Project.toml

@@ -1,7 +1,7 @@
 name = "ComponentArrays"
 uuid = "b0b7db55-cfe3-40fc-9ded-d10e2dbeff66"
 authors = ["Jonnie Diegelman <47193959+jonniedie@users.noreply.github.com>"]
-version = "0.11.16"
+version = "0.11.17"
 
 [deps]
 ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"

src/axis.jl

@@ -48,7 +48,7 @@ struct Axis{IdxMap} <: AbstractAxis{IdxMap} end
 @inline Axis(IdxMap::NamedTuple) = Axis{IdxMap}()
 Axis(;kwargs...) = Axis((;kwargs...))
 function Axis(symbols::Union{AbstractVector{Symbol}, NTuple{N,Symbol}}) where {N}
-    return Axis((;(symbols .=> eachindex(symbols))...))
+    return Axis(NamedTuple{(symbols...,)}((eachindex(symbols)...,)))
 end
 Axis(symbols::Symbol...) = Axis(symbols)
 

src/componentarray.jl

@@ -152,7 +152,7 @@ function make_idx(data, nt::NamedTuple, last_val)
     len = recursive_length(nt)
     kvs = []
     lv = 0
-    for (k,v) in zip(keys(nt), nt)
+    for (k,v) in zip(keys(nt), values(nt))
         (_,val) = make_idx(data, v, lv)
         push!(kvs, k => val)
         lv = val

test/autodiff_tests.jl

@@ -44,3 +44,19 @@ truth = ComponentArray(a = [32, 48], x = 156)
         end[1]
     end
 end
+
+
+# # This is commented out because the gradient operation itself is broken due to Zygote's inability
+# # to support mutation and ComponentArray's use of mutation for contstuction from a NamedTuple.
+# # It would be nice to support this eventually, so I'll just leave this commented (because @test_broken
+# # wouldn't work here because the error happens before the test)
+# @testset "Issues" begin
+#     function mysum(x::AbstractVector)
+#         y = ComponentVector(x=x)
+#         return sum(y)
+#     end
+
+#     Δ = Zygote.gradient(mysum, rand(10))
+
+#     @test Δ isa Vector{Float64}
+# end

test/runtests.jl

@@ -73,6 +73,7 @@ end
     @test Axis([:a, :b, :c]) == Axis(a = 1, b = 2, c = 3)
     @test Axis((:a, :b, :c)) == Axis(a = 1, b = 2, c = 3)
     @test Axis(:a, :b, :c) == Axis(a = 1, b = 2, c = 3)
+    @test_throws ErrorException Axis(:a, :a)
 
     # Issue #24
     @test ComponentVector(a = 1, b = 2.0f0) == ComponentVector{Float32}(a = 1.0, b = 2.0)