Merge pull request #130 from Scalr/feature/SCALRCORE-27243

penja · web-flow · commit 6f466d407725 · 2023-08-30T17:10:32.000+03:00
SCALRCORE-27243 Add dots to the error messages
diff --git a/access_policy_test.go b/access_policy_test.go
@@ -244,7 +244,7 @@ func TestAccessPoliciesDelete(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("IamAccessPolicy with ID '%v' not found or user unauthorized", apTest.ID),
+				Message: fmt.Sprintf("IamAccessPolicy with ID '%v' not found or user unauthorized.", apTest.ID),
 			}.Error(),
 			err.Error(),
 		)
diff --git a/access_token_test.go b/access_token_test.go
@@ -64,7 +64,7 @@ func TestAccessTokenUpdate(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("AccessToken with ID '%s' not found or user unauthorized", "at-123"),
+				Message: fmt.Sprintf("AccessToken with ID '%s' not found or user unauthorized.", "at-123"),
 			}.Error(),
 			err.Error(),
 		)
diff --git a/account_test.go b/account_test.go
@@ -28,7 +28,7 @@ func TestAccountRead(t *testing.T) {
 		_, err := client.Accounts.Read(ctx, accId)
 		assert.Equal(
 			t,
-			fmt.Sprintf("Clients with ID '%s' not found or user unauthorized", accId),
+			fmt.Sprintf("Clients with ID '%s' not found or user unauthorized.", accId),
 			err.Error(),
 		)
 	})
diff --git a/agent_pool_test.go b/agent_pool_test.go
@@ -217,7 +217,7 @@ func TestAgentPoolsCreate(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("Invalid Relationship\n\nAccount with ID '%s' not found or user unauthorized", accountId),
+				Message: fmt.Sprintf("Invalid Relationship\n\nAccount with ID '%s' not found or user unauthorized.", accountId),
 			}.Error(),
 			err.Error(),
 		)
@@ -233,7 +233,7 @@ func TestAgentPoolsCreate(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("Invalid Relationship\n\nEnvironment with ID '%s' not found or user unauthorized", envID),
+				Message: fmt.Sprintf("Invalid Relationship\n\nEnvironment with ID '%s' not found or user unauthorized.", envID),
 			}.Error(),
 			err.Error(),
 		)
@@ -274,7 +274,7 @@ func TestAgentPoolsCreate(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("Invalid Relationship\n\nRelationship 'workspaces' with ID '%s' not found or user unauthorized", wsID),
+				Message: fmt.Sprintf("Invalid Relationship\n\nRelationship 'workspaces' with ID '%s' not found or user unauthorized.", wsID),
 			}.Error(),
 			err.Error(),
 		)
@@ -305,7 +305,7 @@ func TestAgentPoolsRead(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("AgentPool with ID '%s' not found or user unauthorized", apID),
+				Message: fmt.Sprintf("AgentPool with ID '%s' not found or user unauthorized.", apID),
 			}.Error(),
 			err.Error(),
 		)
@@ -392,7 +392,7 @@ func TestAgentPoolsDelete(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("AgentPool with ID '%s' not found or user unauthorized", pool.ID),
+				Message: fmt.Sprintf("AgentPool with ID '%s' not found or user unauthorized.", pool.ID),
 			}.Error(),
 			err.Error(),
 		)
diff --git a/agent_pool_token_test.go b/agent_pool_token_test.go
@@ -30,7 +30,7 @@ func TestAgentPoolTokenList(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("AgentPool with ID '%s' not found or user unauthorized", "ap-123"),
+				Message: fmt.Sprintf("AgentPool with ID '%s' not found or user unauthorized.", "ap-123"),
 			}.Error(),
 			err.Error(),
 		)
@@ -89,7 +89,7 @@ func TestAgentPoolTokenCreate(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("AgentPool with ID '%s' not found or user unauthorized", apID),
+				Message: fmt.Sprintf("AgentPool with ID '%s' not found or user unauthorized.", apID),
 			}.Error(),
 			err.Error(),
 		)
diff --git a/configuration_version_test.go b/configuration_version_test.go
@@ -62,7 +62,7 @@ func TestConfigurationVersionsRead(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("ConfigurationVersion with ID '%s' not found or user unauthorized", cvName),
+				Message: fmt.Sprintf("ConfigurationVersion with ID '%s' not found or user unauthorized.", cvName),
 			}.Error(),
 			err.Error(),
 		)
diff --git a/environment_test.go b/environment_test.go
@@ -151,7 +151,7 @@ func TestEnvironmentsRead(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("Environment with ID '%s' not found or user unauthorized", envId),
+				Message: fmt.Sprintf("Environment with ID '%s' not found or user unauthorized.", envId),
 			}.Error(),
 			err.Error(),
 		)
@@ -261,7 +261,7 @@ func TestEnvironmentsDelete(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("Environment with ID '%s' not found or user unauthorized", envTest.ID),
+				Message: fmt.Sprintf("Environment with ID '%s' not found or user unauthorized.", envTest.ID),
 			}.Error(),
 			err.Error(),
 		)
@@ -273,7 +273,7 @@ func TestEnvironmentsDelete(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("Environment with ID '%s' not found or user unauthorized", envId),
+				Message: fmt.Sprintf("Environment with ID '%s' not found or user unauthorized.", envId),
 			}.Error(),
 			err.Error(),
 		)
diff --git a/module_test.go b/module_test.go
@@ -71,7 +71,7 @@ func TestModulesCreate(t *testing.T) {
 		})
 		assert.Nil(t, w)
 		assert.EqualError(t, err, ResourceNotFoundError{
-			Message: fmt.Sprintf("Invalid Relationship\n\nVcsProvider with ID '%s' not found or user unauthorized", badIdentifier),
+			Message: fmt.Sprintf("Invalid Relationship\n\nVcsProvider with ID '%s' not found or user unauthorized.", badIdentifier),
 		}.Error())
 	})
 
diff --git a/policy_group_test.go b/policy_group_test.go
@@ -145,7 +145,7 @@ func TestPolicyGroupsCreate(t *testing.T) {
 			t,
 			err,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("Clients with ID '%s' not found or user unauthorized", accID),
+				Message: fmt.Sprintf("Clients with ID '%s' not found or user unauthorized.", accID),
 			}.Error(),
 		)
 	})
@@ -165,7 +165,7 @@ func TestPolicyGroupsCreate(t *testing.T) {
 			t,
 			err,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("VcsProvider with ID '%s' not found or user unauthorized", vcsID),
+				Message: fmt.Sprintf("VcsProvider with ID '%s' not found or user unauthorized.", vcsID),
 			}.Error(),
 		)
 	})
@@ -268,7 +268,7 @@ func TestPolicyGroupsDelete(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("PolicyGroups with ID '%s' not found or user unauthorized", policyGroup.ID),
+				Message: fmt.Sprintf("PolicyGroups with ID '%s' not found or user unauthorized.", policyGroup.ID),
 			}.Error(),
 			err.Error(),
 		)
diff --git a/provider_configuration_link_test.go b/provider_configuration_link_test.go
@@ -109,7 +109,7 @@ func TestProviderConfigurationLinkDelete(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("ProviderConfigurationLink with ID '%s' not found or user unauthorized", link.ID),
+				Message: fmt.Sprintf("ProviderConfigurationLink with ID '%s' not found or user unauthorized.", link.ID),
 			}.Error(),
 			err.Error(),
 		)
diff --git a/provider_configuration_parameter_test.go b/provider_configuration_parameter_test.go
@@ -169,7 +169,7 @@ func TestProviderConfigurationParameterDelete(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("ProviderConfigurationParameter with ID '%s' not found or user unauthorized", parameter.ID),
+				Message: fmt.Sprintf("ProviderConfigurationParameter with ID '%s' not found or user unauthorized.", parameter.ID),
 			}.Error(),
 			err.Error(),
 		)
diff --git a/provider_configuration_test.go b/provider_configuration_test.go
@@ -607,7 +607,7 @@ func TestProviderConfigurationDelete(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("ProviderConfiguration with ID '%s' not found or user unauthorized", configuration.ID),
+				Message: fmt.Sprintf("ProviderConfiguration with ID '%s' not found or user unauthorized.", configuration.ID),
 			}.Error(),
 			err.Error(),
 		)
diff --git a/role_test.go b/role_test.go
@@ -139,7 +139,7 @@ func TestRolesCreate(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("Invalid Relationship\n\nAccount with ID '%s' not found or user unauthorized", accountId),
+				Message: fmt.Sprintf("Invalid Relationship\n\nAccount with ID '%s' not found or user unauthorized.", accountId),
 			}.Error(),
 			err.Error(),
 		)
@@ -259,7 +259,7 @@ func TestRolesDelete(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("IamRole with ID '%s' not found or user unauthorized", rTest.ID),
+				Message: fmt.Sprintf("IamRole with ID '%s' not found or user unauthorized.", rTest.ID),
 			}.Error(),
 			err.Error(),
 		)
diff --git a/run_test.go b/run_test.go
@@ -28,7 +28,7 @@ func TestRunsRead(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("Run with ID '%s' not found or user unauthorized", runId),
+				Message: fmt.Sprintf("Run with ID '%s' not found or user unauthorized.", runId),
 			}.Error(),
 			err.Error(),
 		)
diff --git a/run_triggers_test.go b/run_triggers_test.go
@@ -138,7 +138,7 @@ func TestRunTriggersDelete(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("RunTrigger with ID '%s' not found or user unauthorized", createdTrigger.ID),
+				Message: fmt.Sprintf("RunTrigger with ID '%s' not found or user unauthorized.", createdTrigger.ID),
 			}.Error(),
 			err.Error(),
 		)
diff --git a/service_account_test.go b/service_account_test.go
@@ -137,7 +137,7 @@ func TestServiceAccountsCreate(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("Invalid Relationship\n\nAccount with ID '%s' not found or user unauthorized", accountId),
+				Message: fmt.Sprintf("Invalid Relationship\n\nAccount with ID '%s' not found or user unauthorized.", accountId),
 			}.Error(),
 			err.Error(),
 		)
@@ -165,7 +165,7 @@ func TestServiceAccountsRead(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("ServiceAccount with ID '%s' not found or user unauthorized", saID),
+				Message: fmt.Sprintf("ServiceAccount with ID '%s' not found or user unauthorized.", saID),
 			}.Error(),
 			err.Error(),
 		)
@@ -225,7 +225,7 @@ func TestServiceAccountsDelete(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("ServiceAccount with ID '%s' not found or user unauthorized", saTest.ID),
+				Message: fmt.Sprintf("ServiceAccount with ID '%s' not found or user unauthorized.", saTest.ID),
 			}.Error(),
 			err.Error(),
 		)
diff --git a/service_account_token_test.go b/service_account_token_test.go
@@ -42,7 +42,7 @@ func TestServiceAccountTokenList(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("ServiceAccount with ID '%s' not found or user unauthorized", saId),
+				Message: fmt.Sprintf("ServiceAccount with ID '%s' not found or user unauthorized.", saId),
 			}.Error(),
 			err.Error(),
 		)
@@ -102,7 +102,7 @@ func TestServiceAccountTokenCreate(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("ServiceAccount with ID '%s' not found or user unauthorized", saID),
+				Message: fmt.Sprintf("ServiceAccount with ID '%s' not found or user unauthorized.", saID),
 			}.Error(),
 			err.Error(),
 		)
diff --git a/tag_test.go b/tag_test.go
@@ -106,7 +106,7 @@ func TestTagsCreate(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("Invalid Relationship\n\nAccount with ID '%s' not found or user unauthorized", accountId),
+				Message: fmt.Sprintf("Invalid Relationship\n\nAccount with ID '%s' not found or user unauthorized.", accountId),
 			}.Error(),
 			err.Error(),
 		)
@@ -189,7 +189,7 @@ func TestTagsDelete(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("AccountTag with ID '%s' not found or user unauthorized", tagTest.ID),
+				Message: fmt.Sprintf("AccountTag with ID '%s' not found or user unauthorized.", tagTest.ID),
 			}.Error(),
 			err.Error(),
 		)
diff --git a/team_test.go b/team_test.go
@@ -290,7 +290,7 @@ func TestTeamsDelete(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("Team with ID '%s' not found or user unauthorized", testTeam.ID),
+				Message: fmt.Sprintf("Team with ID '%s' not found or user unauthorized.", testTeam.ID),
 			}.Error(),
 			err.Error(),
 		)
diff --git a/variable_test.go b/variable_test.go
@@ -173,7 +173,7 @@ func TestVariablesRead(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("Variable with ID '%s' not found or user unauthorized", variableId),
+				Message: fmt.Sprintf("Variable with ID '%s' not found or user unauthorized.", variableId),
 			}.Error(),
 			err.Error(),
 		)
@@ -270,7 +270,7 @@ func TestVariablesDelete(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("Variable with ID '%s' not found or user unauthorized", variableId),
+				Message: fmt.Sprintf("Variable with ID '%s' not found or user unauthorized.", variableId),
 			}.Error(),
 			err.Error(),
 		)
diff --git a/vcs_provider_test.go b/vcs_provider_test.go
@@ -146,7 +146,7 @@ func TestVcsProvidersCreate(t *testing.T) {
 			t,
 			ResourceNotFoundError{
 				Message: fmt.Sprintf(
-					"Invalid Relationship\n\nRelationship 'environments' with ID '%s' not found or user unauthorized",
+					"Invalid Relationship\n\nRelationship 'environments' with ID '%s' not found or user unauthorized.",
 					badIdentifier,
 				),
 			}.Error(),
@@ -273,7 +273,7 @@ func TestVcsProvidersDelete(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("VcsProvider with ID '%s' not found or user unauthorized", vcsTest.ID),
+				Message: fmt.Sprintf("VcsProvider with ID '%s' not found or user unauthorized.", vcsTest.ID),
 			}.Error(),
 			err.Error(),
 		)
diff --git a/vcs_revision_test.go b/vcs_revision_test.go
@@ -19,7 +19,7 @@ func TestVCSRevisionRead(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("VcsRevisionBinding with ID '%s' not found or user unauthorized", vcsId),
+				Message: fmt.Sprintf("VcsRevisionBinding with ID '%s' not found or user unauthorized.", vcsId),
 			}.Error(),
 			err.Error(),
 		)
diff --git a/webhook_integration_test.go b/webhook_integration_test.go
@@ -155,7 +155,7 @@ func TestWebhookIntegrationsDelete(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("Webhook with ID '%s' not found or user unauthorized", whTest.ID),
+				Message: fmt.Sprintf("Webhook with ID '%s' not found or user unauthorized.", whTest.ID),
 			}.Error(),
 			err.Error(),
 		)
diff --git a/workspace_test.go b/workspace_test.go
@@ -182,7 +182,7 @@ func TestWorkspacesCreate(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("Invalid Relationship\n\nEnvironment with ID '%s' not found or user unauthorized", badIdentifier),
+				Message: fmt.Sprintf("Invalid Relationship\n\nEnvironment with ID '%s' not found or user unauthorized.", badIdentifier),
 			}.Error(),
 			err.Error(),
 		)
@@ -481,7 +481,7 @@ func TestWorkspacesDelete(t *testing.T) {
 		assert.Equal(
 			t,
 			ResourceNotFoundError{
-				Message: fmt.Sprintf("Workspace with ID '%s' not found or user unauthorized", wTest.ID),
+				Message: fmt.Sprintf("Workspace with ID '%s' not found or user unauthorized.", wTest.ID),
 			}.Error(),
 			err.Error(),
 		)

Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ func TestAccessPoliciesDelete(t *testing.T) {`
`244`	`244`	`assert.Equal(`
`245`	`245`	`t,`
`246`	`246`	`ResourceNotFoundError{`
`247`		`- Message: fmt.Sprintf("IamAccessPolicy with ID '%v' not found or user unauthorized", apTest.ID),`
	`247`	`+ Message: fmt.Sprintf("IamAccessPolicy with ID '%v' not found or user unauthorized.", apTest.ID),`
`248`	`248`	`}.Error(),`
`249`	`249`	`err.Error(),`
`250`	`250`	`)`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ func TestAccessTokenUpdate(t *testing.T) {`
`64`	`64`	`assert.Equal(`
`65`	`65`	`t,`
`66`	`66`	`ResourceNotFoundError{`
`67`		`- Message: fmt.Sprintf("AccessToken with ID '%s' not found or user unauthorized", "at-123"),`
	`67`	`+ Message: fmt.Sprintf("AccessToken with ID '%s' not found or user unauthorized.", "at-123"),`
`68`	`68`	`}.Error(),`
`69`	`69`	`err.Error(),`
`70`	`70`	`)`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ func TestAccountRead(t *testing.T) {`
`28`	`28`	`_, err := client.Accounts.Read(ctx, accId)`
`29`	`29`	`assert.Equal(`
`30`	`30`	`t,`
`31`		`- fmt.Sprintf("Clients with ID '%s' not found or user unauthorized", accId),`
	`31`	`+ fmt.Sprintf("Clients with ID '%s' not found or user unauthorized.", accId),`
`32`	`32`	`err.Error(),`
`33`	`33`	`)`
`34`	`34`	`})`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ func TestConfigurationVersionsRead(t *testing.T) {`
`62`	`62`	`assert.Equal(`
`63`	`63`	`t,`
`64`	`64`	`ResourceNotFoundError{`
`65`		`- Message: fmt.Sprintf("ConfigurationVersion with ID '%s' not found or user unauthorized", cvName),`
	`65`	`+ Message: fmt.Sprintf("ConfigurationVersion with ID '%s' not found or user unauthorized.", cvName),`
`66`	`66`	`}.Error(),`
`67`	`67`	`err.Error(),`
`68`	`68`	`)`
Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ func TestProviderConfigurationLinkDelete(t *testing.T) {`
`109`	`109`	`assert.Equal(`
`110`	`110`	`t,`
`111`	`111`	`ResourceNotFoundError{`
`112`		`- Message: fmt.Sprintf("ProviderConfigurationLink with ID '%s' not found or user unauthorized", link.ID),`
	`112`	`+ Message: fmt.Sprintf("ProviderConfigurationLink with ID '%s' not found or user unauthorized.", link.ID),`
`113`	`113`	`}.Error(),`
`114`	`114`	`err.Error(),`
`115`	`115`	`)`