Skip to content

Commit c2edd48

Browse files
committed
pipe query params directly into restAPI httpx requests
1 parent 3593bff commit c2edd48

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

synapseclient/api/submission_services.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ async def get_evaluation_submissions(
9494
if status:
9595
query_params["status"] = status
9696

97-
response = await client.rest_get_async(uri, **query_params)
97+
response = await client.rest_get_async(uri, params=query_params)
9898

9999
return response
100100

@@ -135,7 +135,7 @@ async def get_user_submissions(
135135
if user_id:
136136
query_params["userId"] = user_id
137137

138-
response = await client.rest_get_async(uri, **query_params)
138+
response = await client.rest_get_async(uri, params=query_params)
139139

140140
return response
141141

@@ -170,7 +170,7 @@ async def get_submission_count(
170170
if status:
171171
query_params["status"] = status
172172

173-
response = await client.rest_get_async(uri, **query_params)
173+
response = await client.rest_get_async(uri, params=query_params)
174174

175175
return response
176176

@@ -339,7 +339,7 @@ async def get_all_submission_statuses(
339339
if status:
340340
query_params["status"] = status
341341

342-
response = await client.rest_get_async(uri, **query_params)
342+
response = await client.rest_get_async(uri, params=query_params)
343343

344344
return response
345345

@@ -438,7 +438,7 @@ async def get_evaluation_submission_bundles(
438438
if status:
439439
query_params["status"] = status
440440

441-
response = await client.rest_get_async(uri, **query_params)
441+
response = await client.rest_get_async(uri, params=query_params)
442442

443443
return response
444444

@@ -475,6 +475,6 @@ async def get_user_submission_bundles(
475475
uri = f"/evaluation/{evaluation_id}/submission/bundle"
476476
query_params = {"limit": limit, "offset": offset}
477477

478-
response = await client.rest_get_async(uri, **query_params)
478+
response = await client.rest_get_async(uri, params=query_params)
479479

480480
return response

synapseclient/models/__init__.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@
1515
from synapseclient.models.mixins.table_components import QueryMixin
1616
from synapseclient.models.project import Project
1717
from synapseclient.models.services import FailureStrategy
18+
from synapseclient.models.submission import Submission
19+
from synapseclient.models.submission_bundle import SubmissionBundle
20+
from synapseclient.models.submission_status import SubmissionStatus
1821
from synapseclient.models.submissionview import SubmissionView
1922
from synapseclient.models.table import Table
2023
from synapseclient.models.table_components import (
@@ -111,6 +114,9 @@
111114
"EntityRef",
112115
"DatasetCollection",
113116
# Submission models
117+
"Submission",
118+
"SubmissionBundle",
119+
"SubmissionStatus",
114120
"SubmissionView",
115121
]
116122

0 commit comments

Comments
 (0)