Patch

Author: BryanFauble

synapseclient/api/team_services.py

@@ -26,13 +26,6 @@ async def post_team_list(
 
     Returns:
         List of dictionaries representing <https://rest-docs.synapse.org/rest/org/sagebionetworks/repo/model/Team.html>
-
-    Example: Get teams by their IDs
-        Retrieve specific teams by providing their IDs.
-
-        ```python
-
-        ```
     """
     from synapseclient import Synapse
 

synapseclient/api/user_services.py

@@ -26,13 +26,6 @@ async def get_user_group_headers_batch(
     Returns:
         List representing "children" in
         <https://rest-docs.synapse.org/rest/org/sagebionetworks/repo/model/UserGroupHeaderResponsePage.html>
-
-    Example: Get user group headers by their IDs
-        Retrieve specific user/group headers by providing their IDs.
-
-        ```python
-
-        ```
     """
     from synapseclient import Synapse
 

synapseclient/models/mixins/access_control.py

@@ -710,7 +710,6 @@ async def _process_folder_permission_deletion(
         Raises:
             Exception: For any errors that may occur during processing, which are caught and logged.
         """
-        # For non-recursive processing, track entities with benefactor_tracker
         if not recursive and benefactor_tracker and not dry_run:
             track_tasks = [
                 benefactor_tracker.track_entity_benefactor([folder.id], client)
@@ -1530,10 +1529,6 @@ def _normalize_entity_type(self, entity_type: str) -> str:
             entity_type = entity_type.split(".")[-1]
             if entity_type == "FileEntity":
                 return "File"
-            elif entity_type == "Folder":
-                return "Folder"
-            elif entity_type == "Project":
-                return "Project"
 
         return entity_type
 

tests/unit/synapseclient/models/unit_test_permissions.py

@@ -578,7 +578,7 @@ async def test_track_entities_parallel(self):
             side_effect=benefactor_responses,
         ):
             # WHEN tracking multiple entities in parallel
-            tracker.track_entity_benefactor(entity_ids, mock_client)
+            await tracker.track_entity_benefactor(entity_ids, mock_client)
 
             # THEN all entities should be tracked
             assert len(tracker.entity_benefactors) == 3
@@ -603,7 +603,7 @@ async def test_track_entities_parallel_skip_processed(self):
             return_value=MagicMock(id="syn999"),
         ) as mock_get_benefactor:
             # WHEN tracking entities
-            tracker.track_entity_benefactor(entity_ids, mock_client)
+            await tracker.track_entity_benefactor(entity_ids, mock_client)
 
             # THEN only unprocessed entity should be fetched
             mock_get_benefactor.assert_called_once()