fix test in sync folder just like async; remove confusing comment; update docstring

Author: Lingling Peng

synapseclient/client.py

@@ -7724,8 +7724,7 @@ def _uploadCsv(
             ```python
             import asyncio
             from synapseclient import Synapse
-            from synapseclient.models import Table
-            from synapseclient.models.mixins.table_components import CsvTableDescriptor
+            from synapseclient.models import Table, CsvTableDescriptor
 
             TABLE_ID ="syn123"  # Replace with your table ID
             PATH = "/path/to/table.csv"

tests/integration/synapseclient/models/async/test_table_async.py

@@ -1079,7 +1079,6 @@ async def test_upsert_operations_with_various_data_sources(
             }
         )
 
-        # Reset the spy to count just this operation
         spy_table_update = mocker.spy(table_module, "_push_row_updates_to_synapse")
 
         await table.upsert_rows_async(

tests/integration/synapseclient/models/synchronous/test_entityview.py

@@ -236,8 +236,42 @@ async def test_update_rows_and_annotations(
         entityview = entityview.store(synapse_client=self.syn)
         self.schedule_for_cleanup(entityview.id)
 
-        # SPY on the CSV conversion function to verify different input paths
-        spy_csv_file_conversion = mocker.spy(table_module, "csv_to_pandas_df")
+        # Custom wrapper to capture call stack
+        original_csv_to_pandas_df = table_module.csv_to_pandas_df
+        call_info = []
+
+        def csv_wrapper(*args, **kwargs):
+            import traceback
+
+            stack = traceback.extract_stack()
+
+            # Find the calling function (skip the wrapper itself)
+            calling_function = None
+            for frame in reversed(stack[:-1]):  # Skip current frame
+                if "_upsert_rows_async" in frame.name:
+                    calling_function = "_upsert_rows_async"
+                    break
+                elif "query_async" in frame.name:
+                    calling_function = "query_async"
+                    break
+                else:
+                    pass
+
+            call_info.append(
+                {
+                    "caller": calling_function,
+                    "args": args,
+                    "kwargs": kwargs,
+                    "filepath": kwargs.get("filepath", args[0] if args else None),
+                }
+            )
+
+            return original_csv_to_pandas_df(*args, **kwargs)
+
+        # Patch the csv_to_pandas_df function to use the wrapper
+        mock_csv_to_pandas_df = mocker.patch.object(
+            table_module, "csv_to_pandas_df", side_effect=csv_wrapper
+        )
 
         # Create test data for all files
         test_data = {
@@ -257,7 +291,7 @@ async def test_update_rows_and_annotations(
 
         for method in update_methods:
             # Reset the spy for each method
-            spy_csv_file_conversion.reset_mock()
+            call_info.clear()
 
             # WHEN I update rows using different input types
             if method == "csv":
@@ -276,7 +310,10 @@ async def test_update_rows_and_annotations(
                 )
 
                 # THEN the CSV conversion function should be called
-                spy_csv_file_conversion.assert_called_once()
+                _upsert_rows_async_calls = [
+                    call for call in call_info if call["caller"] == "_upsert_rows_async"
+                ]
+                assert len(_upsert_rows_async_calls) == 1
 
             elif method == "dataframe":
                 # Use DataFrame
@@ -288,7 +325,10 @@ async def test_update_rows_and_annotations(
                 )
 
                 # THEN the CSV conversion function should NOT be called
-                spy_csv_file_conversion.assert_not_called()
+                _upsert_rows_async_calls = [
+                    call for call in call_info if call["caller"] == "_upsert_rows_async"
+                ]
+                assert len(_upsert_rows_async_calls) == 0
 
             else:  # dict
                 # Use dictionary
@@ -300,7 +340,10 @@ async def test_update_rows_and_annotations(
                 )
 
                 # THEN the CSV conversion function should NOT be called
-                spy_csv_file_conversion.assert_not_called()
+                _upsert_rows_async_calls = [
+                    call for call in call_info if call["caller"] == "_upsert_rows_async"
+                ]
+                assert len(_upsert_rows_async_calls) == 0
 
             # THEN the columns should exist in the entity view
             assert "column_string" in entityview.columns