From bceb687793659b8a91396909c82d5e480ff8d93c Mon Sep 17 00:00:00 2001 From: "Christopher J. Brody" Date: Wed, 10 Jul 2019 16:09:54 -0400 Subject: [PATCH] Updated links for RN 0.60 in generated Gradle (comments in generated Android build.gradle file) --- templates/android.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/templates/android.js b/templates/android.js index 83a71c8..f53aaca 100644 --- a/templates/android.js +++ b/templates/android.js @@ -10,8 +10,8 @@ module.exports = platform => [{ } dependencies { - // Matches the RN Hello World template - // https://github.com/facebook/react-native/blob/1e8f3b11027fe0a7514b4fc97d0798d3c64bc895/local-cli/templates/HelloWorld/android/build.gradle#L8 + // Matches recent template from React Native (0.60) + // https://github.com/facebook/react-native/blob/0.60-stable/template/android/build.gradle#L16 classpath("com.android.tools.build:gradle:${safeExtGet('gradlePluginVersion', '3.4.1')}") } } @@ -19,6 +19,8 @@ module.exports = platform => [{ apply plugin: 'com.android.library' apply plugin: 'maven' +// Matches values in recent template from React Native (0.59 ... 0.60) +// https://github.com/facebook/react-native/blob/0.60-stable/template/android/build.gradle#L5-L9 def DEFAULT_COMPILE_SDK_VERSION = 28 def DEFAULT_BUILD_TOOLS_VERSION = "28.0.3" def DEFAULT_MIN_SDK_VERSION = 16